fix: preserve custom name/description on SupervisorAgent#536
Open
nuthalapativarun wants to merge 1 commit into
Open
fix: preserve custom name/description on SupervisorAgent#536nuthalapativarun wants to merge 1 commit into
nuthalapativarun wants to merge 1 commit into
Conversation
Options-provided name and description were unconditionally overwritten with the lead_agent's values. Use them as fallback only when the caller did not supply their own. Fixes 2FastLabs#254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link (REQUIRED)
Fixes #254
Summary
Changes
SupervisorAgentunconditionally overwroteoptions.nameandoptions.descriptionwith the lead agent's values, even when the caller supplied their own. Changed both Python and TypeScript implementations to use the caller-provided values and fall back to the lead agent's values only when none were given.Python (
python/src/agent_squad/agents/supervisor_agent.py):TypeScript (
typescript/src/agents/supervisorAgent.ts):User experience
Before: passing
name="My Supervisor"toSupervisorAgentOptionshad no effect — the name was replaced by the lead agent's name.After: user-supplied
name/descriptionare preserved; the lead agent's values are used only as defaults when none are provided.Checklist
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.