fix(ci): update actions and use codecov - #29
Merged
Merged
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
110CodingP
force-pushed
the
fix_ci
branch
3 times, most recently
from
July 13, 2026 06:24
0cf821f to
7673379
Compare
110CodingP
commented
Aug 1, 2026
110CodingP
left a comment
Owner
Author
There was a problem hiding this comment.
🤖 Code Review by Antigravity
Thank you for opening this PR! The workflow modernizations and justfile cleanups are a great improvement. Here is a detailed breakdown of the review.
🌟 Positives & Enhancements
- Modern Action Setup: Switched from deprecated
actions-rs/toolchainandactions-rs/clippy-checktoactions-rust-lang/setup-rust-toolchain@v1, which standardizes Rust installation and caching. - Automated MSRV Detection: Configured
actions-rust-lang/msrvto pull MSRV dynamically fromCargo.toml(1.89.0), eliminating redundantrust-versiontracking. - Documentation Verification: Added a dedicated
docs_checkstep (cargo doc --all-features --no-deps) with warning enforcement (RUSTDOCFLAGS='-D warnings'). - Codecov Integration: Updated coverage reporting to use
cargo-llvm-covwithcodecov/codecov-action. - Justfile Refactoring: Removed redundant recipe commands in
build,doc, andcode_cov.
⚠️ Critical Findings & Issues
1. Non-Existent Action Major Versions (actions/checkout@v6, actions/upload-artifact@v7)
- In
.github/workflows/code_coverage.ymland.github/workflows/cont_integration.yml, the workflow referencesactions/checkout@v6andactions/upload-artifact@v7. actions/checkoutandactions/upload-artifactare currently at major versionv4. Referencing@v6or@v7will cause GitHub Actions workflow runs to fail immediately with action resolution errors.- Recommendation: Revert
@v6and@v7to@v4in both workflow files.
2. Duplicate Test Executions in Code Coverage Workflow
- In
.github/workflows/code_coverage.yml,cargo llvm-covis run twice:- name: Generate coverage data run: cargo llvm-cov --all-features --branch --quiet --lcov --output-path lcov.info - name: Generate HTML coverage report run: cargo llvm-cov --all-features --branch --quiet --html
- Both commands re-run the full test suite from scratch.
- Recommendation: Combine LCOV and HTML generation into a single step or use
cargo llvm-cov report --htmlfor the second step to avoid running tests twice.
3. Slow Source Compilation of cargo-llvm-cov in CI
- In
.github/workflows/code_coverage.yml:- name: Install cargo-llvm-cov run: cargo install cargo-llvm-cov
cargo install cargo-llvm-covcompiles the binary from source on every CI run (~1–2 minutes overhead). - Recommendation: Use
taiki-e/install-action@cargo-llvm-covto fetch prebuilt binaries instantly.
4. Least Privilege Workflow Permissions
- In
.github/workflows/code_coverage.yml,pull-requests: writepermission is granted. Since Codecov upload usestoken: ${{ secrets.CODECOV_TOKEN }},pull-requests: writeis unnecessary unless automated PR commenting is explicitly configured. Keeping permissions restricted tocontents: readis recommended.
💡 Summary Recommendation
Overall, this PR moves CI infrastructure in the right direction! Fixing the action versions (v4 instead of v6/v7) and optimizing the coverage step will make the pipeline fast, reliable, and clean.
Modified code_cov recipe to use cargo-llvm-cov's flags to generate html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed extraneous commands from the justfile.