MS1 架构主干空骨架(Refs #3 · 会合并入库)#5
Open
johnnyzhang-eng wants to merge 2 commits into
Open
Conversation
| @@ -0,0 +1,24 @@ | |||
| """首个可串联版本 · 空跑冒烟:证明主干串联成立(数据 mock,无真实行为)。 | |||
| 运行:cd skeleton && python3 smoke.py""" | |||
There was a problem hiding this comment.
The run instruction points users to cd skeleton, but this PR adds smoke.py at the repository root and no skeleton/ directory exists. Following the documented command fails before the smoke test can run; update it to the actual invocation, e.g. python3 smoke.py from the repo root.
接口为真、实现桩空、可编译、主干串联可空跑(数据 mock)。 修正 smoke 运行说明为仓库根目录执行(原 cd skeleton 无对应目录,见评审反馈)。 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
4d55842 to
b7a87d9
Compare
Author
|
已处理评审反馈:
|
Member
|
@johnnyzhang-eng 你们的结构设计文档在哪里?一个简单的解释; |
去掉过时的"仅证伪/不接入主管线"表述。week1 spike 已实测图生视频(kling i2v) 一致性/平滑度可用、boy 用例甚至优于逐帧;对齐 PR#2 老师 L201(视频是各工作流之一)。 当前主线仍为逐帧 route A(保单帧可重画),route B 待 MS2 实现。 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

承接 #3。以"代码即架构"入库架构主干空骨架。
内容
gac/models.py领域数据模型(项目/角色/角色卡/基准帧/动作/帧序列/生成记录/版本/交付包)gac/interfaces.py模块对外接口契约(Generator/Matter/Aligner/LoopCloser/Packager/EngineExporter/AssetStore)gac/generationgac/lastmilegac/packaging.pygac/exportgac/assetstore.pygac/evaluation.py各模块(接口为真、实现桩空)gac/pipeline.py编排器,串联主干smoke.py冒烟串联;tests/冒烟测试符合 MS1 交付③④
python -m compileall gac通过;python smoke.py空跑产出 mock 交付包v0.1.0-ms1说明
真实现(生成 API / rembg / 对齐算法等)留 MS2 逐模块 PR 填,各自关联独立 Issue。技术选型见 #4。