fix(ethrpc): preserve non-batch errors in BatchCall - #215
Open
wangjingshuiku wants to merge 1 commit into
Open
Conversation
Signed-off-by: wangjingshuiku <wangjingshuiku@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BatchCallcurrently shadows the error returned byProvider.Dowhile checking whether it is aBatchError. When the assertion fails, the non-batch branch wraps the zero value introduced by the assertion instead of the original transport or RPC error.This change keeps the original error in scope and adds a regression test that uses a failing HTTP transport to verify that callers can still inspect it with
errors.Is.The targeted package test requires the repository's testchain during package initialization. In my environment it stops before running the selected test with
ethtest: unable to connect to testchain.