refactor(rpc/get_account): batch storage map proofs - #2439
Open
kkovaacs wants to merge 2 commits into
Open
Conversation
GetAccount now returns a PartialSmt with all requested key-value pairs. - A request for explicit map keys always returns one partial SMT covering those keys. - Partial SMTs are scoped to one storage map at one block. Proofs from different maps or roots are never merged. - The response carries the original, unhashed `StorageMapKey`s. The SMT contains hashed keys, so the raw keys cannot be recovered from the tree. - Values are not duplicated outside the SMT. A client obtains a value by hashing the raw key and calling `PartialSmt::get_value()`. - `too_many_entries`, `all_entries`, and `partial_map` become mutually exclusive results. - The removed `entries_with_proofs` field number and name are reserved. Even though compatibility is intentionally broken, reusing the field could make an old client try to decode the new length-delimited message as the old one. - The compact protobuf representation mirrors `miden_crypto::merkle::smt::UniqueNodes`. Do not encode `PartialSmt` as an opaque byte string.
kkovaacs
force-pushed
the
krisztian/get-account-batched-storage-proofs
branch
from
August 5, 2026 14:01
5ae4953 to
1a99dc6
Compare
Collaborator
Author
|
Looks like there is a bug in |
kkovaacs
marked this pull request as ready for review
August 5, 2026 15:34
Contributor
Once 0xMiden/miden-vm#3471 is merged, we should be able to do a patch release and it'll flow through to here immediately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetAccount now returns a PartialSmt with all requested key-value pairs.
StorageMapKeys. The SMT contains hashed keys, so the raw keys cannot be recovered from the tree.PartialSmt::get_value().too_many_entries,all_entries, andpartial_mapbecome mutually exclusive results.entries_with_proofsfield number and name are reserved. Even though compatibility is intentionally broken, reusing the field could make an old client try to decode the new length-delimited message as the old one.miden_crypto::merkle::smt::UniqueNodes. Do not encodePartialSmtas an opaque byte string.Closes #617
Changelog