chore: update protocol - #2421
Open
juan518munoz wants to merge 6 commits into
Open
Conversation
juan518munoz
marked this pull request as ready for review
August 3, 2026 17:26
Collaborator
There was a problem hiding this comment.
This file shouldn't be changed.
Comment on lines
+1193
to
+1203
| let has_allowed_notes = allowlist_entries(NetworkAccountNoteAllowlist::slot_name()) | ||
| .is_some_and(|entries| entries.as_map().values().any(|value| *value != Word::empty())); | ||
| let allows_expiration_tx_script = | ||
| allowlist_entries(NetworkAccountTxScriptAllowlist::slot_name()).is_some_and(|entries| { | ||
| entries | ||
| .as_map() | ||
| .get(&StorageMapKey::new(ExpirationTransactionScript::script_root().as_word())) | ||
| .is_some_and(|value| *value != Word::empty()) | ||
| }); | ||
| let is_network_account = | ||
| account_id.is_public() && has_allowed_notes && allows_expiration_tx_script; |
Collaborator
There was a problem hiding this comment.
I actually wonder if we still need to do this song and dance at all - @SantiagoPittella I believe this was likely a remnant of the ntx builders old sync?
Collaborator
There was a problem hiding this comment.
I guess this means once fee's are turned on our monitor will be dead unless we somehow get it gas?
Collaborator
There was a problem hiding this comment.
Why is this so much more complex?
Comment on lines
+1214
to
+1222
| /// Draw a random [`Word`] from `rng`. | ||
| fn random_word(rng: &mut ChaCha20Rng) -> Word { | ||
| Word::new([ | ||
| Felt::new_unchecked(rng.random()), | ||
| Felt::new_unchecked(rng.random()), | ||
| Felt::new_unchecked(rng.random()), | ||
| Felt::new_unchecked(rng.random()), | ||
| ]) | ||
| } |
Collaborator
There was a problem hiding this comment.
Do we still not have rand implemented for these 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR does not work for chains which base fee is not zero (e.g network monitor and benchark binaries are only able to operate with fee-less chains). Full fee implementation is left as a follow-up PR.
Changelog