refactor(validator): wrap database handles in reader/writer structs - #2403
Merged
Conversation
SantiagoPittella
force-pushed
the
add-validator-db-wrapper
branch
from
July 29, 2026 16:08
c8be314 to
38a90c0
Compare
sergerad
self-requested a review
August 3, 2026 07:07
sergerad
reviewed
Aug 4, 2026
sergerad
approved these changes
Aug 4, 2026
SantiagoPittella
force-pushed
the
add-validator-db-wrapper
branch
4 times, most recently
from
August 7, 2026 14:52
f855850 to
6b72d61
Compare
SantiagoPittella
force-pushed
the
add-validator-db-wrapper
branch
from
August 7, 2026 14:56
6b72d61 to
4bdbac5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2368
Summary
Copies the ntx-builder's database wrapper (#2353) into the validator:
ValidatorDbReader/ValidatorDbWriterexpose one method per query, so rawDbReader/DbWriterhandles no longer escapesrc/db/. Queries move to one directory per query, matching the ntx-builder layout.Also fixes two things:
find_unvalidated_transactionsnow uses a single rarray query instead of oneEXISTSper id, and parameters bind through the blob codec /SqlTypeConvertinstead ofto_bytes().Changelog