fix(store): move local block proving off async runtime#2108
Open
Ollie202 wants to merge 3 commits into
Open
Conversation
b62a7c2 to
0146c60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #1976.
Problem
BlockProver::proveis async, but the local store prover path callsLocalBlockProver::provedirectly. Local block proving is CPU-heavy synchronous work, so running it on a Tokio worker can starve the async runtime.Changes
spawn_blocking_in_current_span.StoreProverErrorvariant for blocking task join failures.Testing
rustfmt crates/store/src/server/block_prover_client.rsgit diff --checkI also tried
cargo check -p miden-node-storeandcargo check --manifest-path crates/store/Cargo.toml, but both stop before compiling because the current protocol git dependency tries to check out an agglayer submodule file with:in the filename on Windows:tools/addRollupType/addRollupMainnet10/add_rollup_type_10_output-2025-03-11T15:54:21.263Z.json