fix(tests): don't clean up RocksDB directory before store shutdown#2107
Open
kkovaacs wants to merge 1 commit into
Open
fix(tests): don't clean up RocksDB directory before store shutdown#2107kkovaacs wants to merge 1 commit into
kkovaacs wants to merge 1 commit into
Conversation
Due to missing store shutdown on panic test failures could cause the temporary directory to be cleaned up while the store was still running. This would then cause a panic when the LargeSmt RocksDB storage backend was being dropped because we're doing an explicit flush there. This change fixes this by introducing a `TestStore` wrapper around the store and the temporary directory that makes sure that the store runtime is stopped before deleting the temporary directory.
kkovaacs
added
the
no changelog
Mirko-von-Leipzig
approved these changes
May 20, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Thank you!
I guess ideally we would have a proper shutdown channel to the server(s)?
sergerad
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to missing store shutdown on panic test failures could cause the temporary directory to be cleaned up while the store was still running.
This would then cause a panic when the LargeSmt RocksDB storage backend was being dropped because we're doing an explicit flush there.
This change fixes this by introducing a
TestStorewrapper around the store and the temporary directory that makes sure that the store runtime is stopped before deleting the temporary directory.