feat: port diesel migrations to the new framework#2104
Merged
Conversation
sergerad
approved these changes
May 21, 2026
Collaborator
sergerad
left a comment
There was a problem hiding this comment.
LGTM but I don't follow why those 3 byte arrays are now nullable when other ones in the same schema aren't?
Collaborator
Author
If you look at the original sqlite for it, they were actually nullable, but the diesel macros for them for whatever reason were altered to be non-null. So when we redid this manually, the more "correct" diesel was generated. I'll fix the schema to match what we want. |
diesel migrations to the new framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the sqlite migrations to the new framework introduced in #2093.
I also made some changes to the framework after dog fooding it here.