Skip to content

Log filters issues #141 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abdotop wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Log filters issues #141 #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions web/pages/DeploymentPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,8 +993,8 @@ const logsPending = new Signal(false)
const fetchLogs = async (reset = false) => {
const { dep, lq, sbi } = url.params
if (!dep || sbi !== 'deployment') return
if (logsPending.value) return
if (!reset && !logsHasMore.value) return
if (logsPending.peek()) return
if (!reset && !logsHasMore.peek()) return

logsPending.value = true
const filterRows = parseFilters('l').filter((r) => r.key !== 'key' && r.value)
Expand All @@ -1010,7 +1010,7 @@ const fetchLogs = async (reset = false) => {
order: r.dir === 'asc' ? 'ASC' : 'DESC' as Order,
}))

const offset = reset ? 0 : logsList.value.length
const offset = reset ? 0 : logsList.peek().length
try {
const data = await api['POST/api/deployment/logs'].fetch({
deployment: dep || '',
Expand Down Expand Up @@ -1038,9 +1038,7 @@ const fetchLogs = async (reset = false) => {
effect(() => {
const { dep, sbi } = url.params
if (dep && sbi === 'deployment') {
untracked(() => {
fetchLogs(true)
})
fetchLogs(true)
}
})

Expand Down
Loading