Skip to content

Commit 151bb97

Browse files
chore(druid): Add 33.0.0, Remove 30.0.0 (#1110)
* chore(druid): Remove 30.0.0 * chore(druid): Add 33.0.0 * Fix build * TRY fixing 30 and 31 * try fix * bash stuff.... works locally but who knows... * Apply suggestions from code review * update inline comment * Apply suggestions from code review --------- Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.tech> Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
1 parent 53e93ce commit 151bb97

16 files changed

+139
-138
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ All notable changes to this project will be documented in this file.
1111
- airflow: Add `2.10.5` ([#1108]).
1212
- druid: check for correct permissions and ownerships in /stackable folder via
1313
`check-permissions-ownership.sh` provided in stackable-base image ([#1039]).
14+
- druid: Add `33.0.0` ([#1110]).
1415
- hadoop: check for correct permissions and ownerships in /stackable folder via
1516
`check-permissions-ownership.sh` provided in stackable-base image ([#1029]).
1617
- hbase: check for correct permissions and ownerships in /stackable folder via
@@ -78,6 +79,7 @@ All notable changes to this project will be documented in this file.
7879
- Remove ubi8-rust-builder image ([#1091]).
7980
- opa: Remove `0.67.1` ([#1103]).
8081
- opa: Remove legacy bundle-builder from container build ([#1103]).
82+
- druid: Remove `30.0.0` ([#1110]).
8183

8284
[#1025]: https://github.com/stackabletech/docker-images/pull/1025
8385
[#1027]: https://github.com/stackabletech/docker-images/pull/1027
@@ -107,6 +109,7 @@ All notable changes to this project will be documented in this file.
107109
[#1103]: https://github.com/stackabletech/docker-images/pull/1103
108110
[#1106]: https://github.com/stackabletech/docker-images/pull/1106
109111
[#1108]: https://github.com/stackabletech/docker-images/pull/1108
112+
[#1110]: https://github.com/stackabletech/docker-images/pull/1110
110113
[#1116]: https://github.com/stackabletech/docker-images/pull/1116
111114

112115
## [25.3.0] - 2025-03-21

druid/Dockerfile

+18-2
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,29 @@ COPY --chown=${STACKABLE_USER_UID}:0 druid/stackable/patches/${PRODUCT} /stackab
4343
# with a "directory not empty" error on the first builder to finish, as other builders
4444
# are still working in the cache directory.
4545

46+
# Let's have patchable as a dedicated step, as it fetches the druid sourcecode over the network,
47+
# thus taking a bit (which is annoying while development)
48+
RUN /stackable/patchable --images-repo-root=src checkout druid ${PRODUCT} > /tmp/DRUID_SOURCE_DIR
49+
4650
RUN --mount=type=cache,id=maven-${PRODUCT},uid=${STACKABLE_USER_UID},target=/stackable/.m2/repository \
4751
--mount=type=cache,id=npm-${PRODUCT},uid=${STACKABLE_USER_UID},target=/stackable/.npm \
4852
--mount=type=cache,id=cache-${PRODUCT},uid=${STACKABLE_USER_UID},target=/stackable/.cache \
4953
<<EOF
50-
cd "$(/stackable/patchable --images-repo-root=src checkout druid ${PRODUCT})"
54+
cd "$(cat /tmp/DRUID_SOURCE_DIR)" || exit 1
55+
rm /tmp/DRUID_SOURCE_DIR
56+
57+
mvn \
58+
--batch-mode \
59+
--no-transfer-progress \
60+
clean install \
61+
-Pdist,stackable-bundle-contrib-exts \
62+
-Dmaven.test.skip `# Skip test compilation` \
63+
-DskipTests `# Skip test execution` \
64+
-Dcheckstyle.skip `# Skip checkstyle checks. We dont care if the code is properly formatted, it just wastes time` \
65+
-Dmaven.javadoc.skip=true `# Dont generate javadoc` \
66+
-Dmaven.gitcommitid.skip=true `# The gitcommitid plugin cannot work with git workspaces (ie: patchable)` \
67+
$(if [[ ${PRODUCT} != 30.* ]]; then echo --projects '!quidem-ut'; fi) `# This is just a maven module for tests. https://github.com/apache/druid/pull/16867 added https://raw.githubusercontent.com/kgyrtkirk/datasets/repo/ as a Maven repository, which fails to pull for us (Failed to execute goal on project druid-quidem-ut: Could not resolve dependencies for project org.apache.druid:druid-quidem-ut:jar:33.0.0: com.github.kgyrtkirk.datasets:kttm-nested:jar:0.1 was not found in https://build-repo.stackable.tech/repository/maven-public/). By disabling the maven module we dont pull in this weird dependency...`
5168

52-
mvn --batch-mode --no-transfer-progress clean install -Pdist,stackable-bundle-contrib-exts -DskipTests -Dmaven.javadoc.skip=true
5369
mv distribution/target/apache-druid-${PRODUCT}-bin/apache-druid-${PRODUCT} /stackable/
5470
mv distribution/target/bom.json /stackable/apache-druid-${PRODUCT}/apache-druid-${PRODUCT}.cdx.json
5571
rm -rf /stackable/apache-druid-${PRODUCT}-src

druid/stackable/patches/30.0.0/0001-Removes-all-traces-of-the-druid-ranger-extension.patch

-35
This file was deleted.

druid/stackable/patches/30.0.0/patchable.toml

-2
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
From 0517d9fb940879ced639eb0d717ba4b5f67d9670 Mon Sep 17 00:00:00 2001
2+
From: Lars Francke <git@lars-francke.de>
3+
Date: Wed, 10 Jul 2024 17:07:13 +0200
4+
Subject: Removes all traces of the druid ranger extension
5+
6+
---
7+
distribution/pom.xml | 2 --
8+
pom.xml | 1 -
9+
2 files changed, 3 deletions(-)
10+
11+
diff --git a/distribution/pom.xml b/distribution/pom.xml
12+
index 8ee50f9029..cb54001d20 100644
13+
--- a/distribution/pom.xml
14+
+++ b/distribution/pom.xml
15+
@@ -458,8 +458,6 @@
16+
<argument>org.apache.druid.extensions.contrib:druid-rabbit-indexing-service</argument>
17+
<argument>-c</argument>
18+
<argument>org.apache.druid.extensions.contrib:grpc-query</argument>
19+
- <argument>-c</argument>
20+
- <argument>org.apache.druid.extensions.contrib:druid-ranger-security</argument>
21+
</arguments>
22+
</configuration>
23+
</execution>
24+
diff --git a/pom.xml b/pom.xml
25+
index 1f7d6a69df..09daa8b2e9 100644
26+
--- a/pom.xml
27+
+++ b/pom.xml
28+
@@ -258,7 +258,6 @@
29+
<module>extensions-contrib/druid-deltalake-extensions</module>
30+
<module>extensions-contrib/spectator-histogram</module>
31+
<module>extensions-contrib/rabbit-stream-indexing-service</module>
32+
- <module>extensions-contrib/druid-ranger-security</module>
33+
<!-- distribution packaging -->
34+
<module>distribution</module>
35+
<!-- Revised integration tests -->

druid/stackable/patches/30.0.0/0002-Include-Prometheus-emitter-in-distribution.patch renamed to druid/stackable/patches/33.0.0/0002-Include-Prometheus-emitter-in-distribution.patch

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
From 0cee640900bb8119ba6be12911578927aeb191ed Mon Sep 17 00:00:00 2001
1+
From 7cd9440c7f484db79ca4a7b107fc0404dc9421a0 Mon Sep 17 00:00:00 2001
22
From: Lars Francke <git@lars-francke.de>
33
Date: Mon, 17 Feb 2025 16:42:34 +0100
44
Subject: Include Prometheus emitter in distribution
@@ -8,10 +8,10 @@ Subject: Include Prometheus emitter in distribution
88
1 file changed, 46 insertions(+)
99

1010
diff --git a/distribution/pom.xml b/distribution/pom.xml
11-
index e27329e96d..d5918710ef 100644
11+
index cb54001d20..c8b7e13054 100644
1212
--- a/distribution/pom.xml
1313
+++ b/distribution/pom.xml
14-
@@ -464,6 +464,52 @@
14+
@@ -466,6 +466,52 @@
1515
</plugins>
1616
</build>
1717
</profile>

druid/stackable/patches/30.0.0/0003-Stop-building-unused-extensions.patch renamed to druid/stackable/patches/33.0.0/0003-Stop-building-unused-extensions.patch

+7-9
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
From 62f340d66dae20da8d7566f992b56223d29d4174 Mon Sep 17 00:00:00 2001
1+
From 2259629e248db402a660b42d7eca75f17e164b7f Mon Sep 17 00:00:00 2001
22
From: Lars Francke <git@lars-francke.de>
33
Date: Mon, 17 Feb 2025 16:42:34 +0100
44
Subject: Stop building unused extensions.
@@ -7,18 +7,16 @@ By default Druid builds all community extensions and then discards them
77
while assembling the final distribution. This patch removes unused
88
extensions from the build.
99
---
10-
pom.xml | 32 +-------------------------------
11-
1 file changed, 1 insertion(+), 31 deletions(-)
10+
pom.xml | 31 -------------------------------
11+
1 file changed, 31 deletions(-)
1212

1313
diff --git a/pom.xml b/pom.xml
14-
index 3ab467e468..171a98f803 100644
14+
index 09daa8b2e9..df781fac63 100644
1515
--- a/pom.xml
1616
+++ b/pom.xml
17-
@@ -200,39 +200,9 @@
18-
<module>extensions-core/google-extensions</module>
17+
@@ -226,38 +226,7 @@
1918
<module>extensions-core/druid-catalog</module>
2019
<module>extensions-core/testing-tools</module>
21-
+
2220
<!-- Community extensions -->
2321
- <module>extensions-contrib/compressed-bigdecimal</module>
2422
- <module>extensions-contrib/influx-extensions</module>
@@ -47,11 +45,11 @@ index 3ab467e468..171a98f803 100644
4745
- <module>extensions-contrib/aliyun-oss-extensions</module>
4846
<module>extensions-contrib/prometheus-emitter</module>
4947
- <module>extensions-contrib/opentelemetry-emitter</module>
50-
- <module>extensions-contrib/kubernetes-overlord-extensions</module>
48+
- <module>extensions-contrib/grpc-query</module>
5149
- <module>extensions-contrib/druid-iceberg-extensions</module>
5250
- <module>extensions-contrib/druid-deltalake-extensions</module>
5351
- <module>extensions-contrib/spectator-histogram</module>
5452
- <module>extensions-contrib/rabbit-stream-indexing-service</module>
55-
5653
<!-- distribution packaging -->
5754
<module>distribution</module>
55+
<!-- Revised integration tests -->

0 commit comments

Comments
 (0)