change error code name

Author: rmorshea

README.md

@@ -20,7 +20,7 @@ pip install -e .
 Run the tests
 
 ```bash
-tox
+nox -s test
 ```
 
 # Errors
@@ -31,34 +31,34 @@ tox
         <th>Message</th>
     </tr>
     <tr>
-        <td>ROH100</td>
+        <td>REACTPY100</td>
         <td>Hook is defined as a closure</td>
     </tr>
     <tr>
-        <td>ROH101</td>
+        <td>REACTPY101</td>
         <td>Hook was used outside component or hook definition</td>
     </tr>
     <tr>
-        <td>ROH102</td>
+        <td>REACTPY102</td>
         <td>Hook was used inside a conditional or loop statement</td>
     </tr>
     <tr>
-        <td>ROH103</td>
+        <td>REACTPY103</td>
         <td>Hook was used after an early return</td>
     </tr>
     <tr>
-        <td>ROH200</td>
+        <td>REACTPY200</td>
         <td>
             A hook's dependency is not destructured - dependencies should be refered to
             directly, not via an attribute or key of an object
         </td>
     </tr>
     <tr>
-        <td>ROH201</td>
+        <td>REACTPY201</td>
         <td>Hook dependency args should be a literal list, tuple or None</td>
     </tr>
     <tr>
-        <td>ROH202</td>
+        <td>REACTPY202</td>
         <td>
             Hook dependency is not specified
         </td>
@@ -81,7 +81,7 @@ example, `exhaustive_hook_deps` would become `--exhaustive-hook-deps`.
         <td><code>exhaustive_hook_deps</code></td>
         <td>Boolean</td>
         <td><code>False</code></td>
-        <td>Enable <code>ROH2**</code> errors (recommended)</td>
+        <td>Enable <code>REACTPY2**</code> errors (recommended)</td>
     </tr>
     <tr>
         <td><code>component_decorator_pattern</code></td>

reactpy_flake8/common.py

@@ -27,7 +27,9 @@ def __init__(
         self._component_decorator_pattern = re.compile(component_decorator_pattern)
 
     def add_error(self, error_code: int, node: ast.AST, message: str) -> None:
-        self.errors.append((node.lineno, node.col_offset, f"ROH{error_code} {message}"))
+        self.errors.append(
+            (node.lineno, node.col_offset, f"REACTPY{error_code} {message}")
+        )
 
     def is_hook_def(self, node: ast.FunctionDef) -> bool:
         return self.is_hook_name(node.name)

setup.py

@@ -18,7 +18,7 @@
 package = {
     "name": name,
     "packages": setuptools.find_packages(exclude=["tests*"]),
-    "entry_points": {"flake8.extension": ["ROH=reactpy_flake8:plugin"]},
+    "entry_points": {"flake8.extension": ["REACTPY=reactpy_flake8:plugin"]},
     "python_requires": ">=3.6",
     "description": "Flake8 plugin to enforce the rules of hooks for ReactPy",
     "author": "Ryan Morshead",

tests/cases/custom_component_decorator_pattern.py

@@ -1,12 +1,12 @@
 @component
 def check_normal_pattern():
     if True:
-        # error: ROH102 hook 'use_state' used inside if statement
+        # error: REACTPY102 hook 'use_state' used inside if statement
         use_state()
 
 
 @custom_component
 def check_custom_pattern():
     if True:
-        # error: ROH102 hook 'use_state' used inside if statement
+        # error: REACTPY102 hook 'use_state' used inside if statement
         use_state()

tests/cases/custom_hook_function_pattern.py

@@ -3,5 +3,5 @@ def check():
     if True:
         # this get's ignored because of custom pattern
         use_ignore_this()
-        # error: ROH102 hook 'use_state' used inside if statement
+        # error: REACTPY102 hook 'use_state' used inside if statement
         use_state()

tests/cases/exhaustive_deps.py

@@ -1,4 +1,4 @@
-# error: ROH101 hook 'use_effect' used outside component or hook definition
+# error: REACTPY101 hook 'use_effect' used outside component or hook definition
 use_effect(lambda: x)  # no need to check deps outside component/hook
 
 
@@ -12,7 +12,7 @@ def check_effects():
 
     use_effect(
         lambda: (
-            # error: ROH202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
+            # error: REACTPY202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
             x
             + y
         ),
@@ -21,49 +21,49 @@ def check_effects():
 
     use_effect(
         lambda: (
-            # error: ROH202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
+            # error: REACTPY202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
             x
         )
     )
 
     use_effect(
         lambda: (
-            # error: ROH202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
+            # error: REACTPY202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
             x.y
         ),
         [
-            # error: ROH200 dependency arg of 'use_effect' is not destructured - dependencies should be refered to directly, not via an attribute or key of an object
+            # error: REACTPY200 dependency arg of 'use_effect' is not destructured - dependencies should be refered to directly, not via an attribute or key of an object
             x.y
         ],
     )
 
     module.use_effect(
         lambda: (
-            # error: ROH202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
+            # error: REACTPY202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
             x
         ),
         [],
     )
 
     module.submodule.use_effect(
         lambda: (
-            # error: ROH202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
+            # error: REACTPY202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
             x
         ),
         [],
     )
 
     use_effect(
         lambda: (
-            # error: ROH202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
+            # error: REACTPY202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
             x
         ),
         args=[],
     )
 
     use_effect(
         function=lambda: (
-            # error: ROH202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
+            # error: REACTPY202 dependency 'x' of function 'lambda' is not specified in declaration of 'use_effect'
             x
         ),
         args=[],
@@ -75,7 +75,7 @@ def my_effect():
 
     @use_effect(args=[])
     def my_effect():
-        # error: ROH202 dependency 'x' of function 'my_effect' is not specified in declaration of 'use_effect'
+        # error: REACTPY202 dependency 'x' of function 'my_effect' is not specified in declaration of 'use_effect'
         x
 
     @use_effect(args=[])
@@ -86,7 +86,7 @@ def my_effect(*args, **kwargs):
 
     @module.use_effect(args=[])
     def my_effect():
-        # error: ROH202 dependency 'x' of function 'my_effect' is not specified in declaration of 'use_effect'
+        # error: REACTPY202 dependency 'x' of function 'my_effect' is not specified in declaration of 'use_effect'
         x
 
     @not_a_decorator_we_care_about
@@ -104,7 +104,7 @@ def impropper_usage_of_effect_as_decorator():
 
     use_effect(
         lambda: None,
-        # error: ROH201 dependency args of 'use_effect' should be a literal list, tuple, or None - not expression type 'Name'
+        # error: REACTPY201 dependency args of 'use_effect' should be a literal list, tuple, or None - not expression type 'Name'
         not_a_list_or_tuple,
     )
 

tests/cases/hook_usage.py

@@ -14,7 +14,7 @@ def HookInIfNoCall():
 @component
 def HookInIf():
     if True:
-        # error: ROH102 hook 'use_state' used inside if statement
+        # error: REACTPY102 hook 'use_state' used inside if statement
         use_state()
 
 
@@ -24,7 +24,7 @@ def HookInIfInExpression():
         (
             None
             or
-            # error: ROH102 hook 'use_state' used inside if statement
+            # error: REACTPY102 hook 'use_state' used inside if statement
             use_state
         )()
 
@@ -34,7 +34,7 @@ def HookInElif():
     if False:
         pass
     elif True:
-        # error: ROH102 hook 'use_state' used inside if statement
+        # error: REACTPY102 hook 'use_state' used inside if statement
         use_state()
 
 
@@ -43,14 +43,14 @@ def HookInElse():
     if False:
         pass
     else:
-        # error: ROH102 hook 'use_state' used inside if statement
+        # error: REACTPY102 hook 'use_state' used inside if statement
         use_state()
 
 
 @component
 def HookInIfExp():
     (
-        # error: ROH102 hook 'use_state' used inside inline if expression
+        # error: REACTPY102 hook 'use_state' used inside inline if expression
         use_state()
         if True
         else None
@@ -63,15 +63,15 @@ def HookInElseOfIfExp():
         None
         if True
         else
-        # error: ROH102 hook 'use_state' used inside inline if expression
+        # error: REACTPY102 hook 'use_state' used inside inline if expression
         use_state()
     )
 
 
 @component
 def HookInTry():
     try:
-        # error: ROH102 hook 'use_state' used inside try statement
+        # error: REACTPY102 hook 'use_state' used inside try statement
         use_state()
     except:
         pass
@@ -82,7 +82,7 @@ def HookInExcept():
     try:
         raise ValueError()
     except:
-        # error: ROH102 hook 'use_state' used inside try statement
+        # error: REACTPY102 hook 'use_state' used inside try statement
         use_state()
 
 
@@ -91,32 +91,32 @@ def HookInFinally():
     try:
         pass
     finally:
-        # error: ROH102 hook 'use_state' used inside try statement
+        # error: REACTPY102 hook 'use_state' used inside try statement
         use_state()
 
 
 @component
 def HookInForLoop():
     for i in range(3):
-        # error: ROH102 hook 'use_state' used inside for loop
+        # error: REACTPY102 hook 'use_state' used inside for loop
         use_state()
 
 
 @component
 def HookInWhileLoop():
     while True:
-        # error: ROH102 hook 'use_state' used inside while loop
+        # error: REACTPY102 hook 'use_state' used inside while loop
         use_state()
 
 
 def outer_function():
-    # error: ROH100 hook 'use_state' defined as closure in function 'outer_function'
+    # error: REACTPY100 hook 'use_state' defined as closure in function 'outer_function'
     def use_state():
         ...
 
 
 def generic_function():
-    # error: ROH101 hook 'use_state' used outside component or hook definition
+    # error: REACTPY101 hook 'use_state' used outside component or hook definition
     use_state()
 
 
@@ -146,12 +146,12 @@ def use_custom_hook():
 # ok since use state is not called
 module.use_effect
 
-# error: ROH101 hook 'use_effect' used outside component or hook definition
+# error: REACTPY101 hook 'use_effect' used outside component or hook definition
 module.use_effect()
 
 
 def not_hook_or_component():
-    # error: ROH101 hook 'use_state' used outside component or hook definition
+    # error: REACTPY101 hook 'use_state' used outside component or hook definition
     use_state()
 
 
@@ -188,7 +188,7 @@ def use_other():
 def example():
     if True:
         return None
-    # error: ROH103 hook 'use_state' used after an early return on line 190
+    # error: REACTPY103 hook 'use_state' used after an early return on line 190
     use_state()
 
 

tests/cases/match_statement.py

@@ -2,5 +2,5 @@
 def example():
     match something:
         case int:
-            # error: ROH102 hook 'use_state' used inside match statement
+            # error: REACTPY102 hook 'use_state' used inside match statement
             use_state()

tests/cases/no_exhaustive_deps.py

@@ -1,6 +1,6 @@
 # confirm that we're still checking for other errors
 def generic_function():
-    # error: ROH101 hook 'use_state' used outside component or hook definition
+    # error: REACTPY101 hook 'use_state' used outside component or hook definition
     use_state()