You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This regex breaks for beta releases, e.g. 2.0.0-beta.5. We're about to release 2.0 so we won't have beta releases for a while, but we may want this working for the future when we do beta 3.0 releases.
Expected Behavior
The regex should match strings like 2.0.0-beta.5 too.
hey @davepagurek , i would like to take this on and update regex to not break.
The regex should accept beta versions too — e.g., 2.0.0-beta.5 right?
if there are any other things that you would like me to keep in mind, please state that, i will address those.
@webermayank thanks for volunteering, and yes, both "1.2.3" and "1.2.3-beta.4" should be covered (so that 'v' is correctly prepended). Please make 2 PRs for both main and 2.0. Thank you!
Most appropriate sections of the p5.js website?
Reference
What is your operating system?
Mac OS
Web browser and version
Firefox
Actual Behavior
In the reference builder, we add a
v
to the start of the latest release if it seems to all be numeric:p5.js-website/src/scripts/parsers/reference.ts
Lines 26 to 28 in df16dae
This regex breaks for beta releases, e.g.
2.0.0-beta.5
. We're about to release 2.0 so we won't have beta releases for a while, but we may want this working for the future when we do beta 3.0 releases.Expected Behavior
The regex should match strings like
2.0.0-beta.5
too.Steps to reproduce
Manually edit this
p5.js-website/src/globals/p5-version.ts
Line 1 in df16dae
Would you like to work on the issue?
Feel free to take this on for me!
The text was updated successfully, but these errors were encountered: