Skip to content

clicking on line number erases parameters #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vladak opened this issue Aug 22, 2017 · 1 comment · Fixed by #1760
Closed

clicking on line number erases parameters #1745

vladak opened this issue Aug 22, 2017 · 1 comment · Fixed by #1760
Labels
Milestone

Comments

@vladak
Copy link
Member

vladak commented Aug 22, 2017

When a line number is clicked in a file whose particular revision displayed (i.e. the URL is in the form of http://localhost:8080/source/xref/mercurial/main.c?r=12%3Aec47d2e13931 - with the r parameter), the parameter disappears (i.e. the URL becomes http://localhost:8080/source/xref/mercurial/main.c#44 if line 44 is clicked on - the expected behavior is that the URL becomes http://localhost:8080/source/xref/mercurial/main.c?r=12%3Aec47d2e13931#44).

This blocks the fix for #1736.

@vladak vladak added the bug label Aug 22, 2017
@vladak vladak changed the title clicking on line number clicking on line number erases parameters Aug 22, 2017
@vladak
Copy link
Member Author

vladak commented Aug 22, 2017

For completeness, this happens in FF 52.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant