Added support for insert append for direct path inserts fixing ER #174

Author: aosingh

Makefile

@@ -1,5 +1,5 @@
 # Configuration variables
-VERSION=1.9.1
+VERSION=1.9.2
 PROJ_DIR?=$(shell pwd)
 VENV_DIR?=${PROJ_DIR}/.bldenv
 BUILD_DIR=${PROJ_DIR}/build

dbt/include/oracle/macros/materializations/incremental/strategies.sql

@@ -94,12 +94,15 @@
 
 {% macro oracle__get_incremental_append_sql(args_dict) %}
     {%- set parallel = config.get('parallel', none) -%}
+    {%- set insert_mode = config.get('insert_mode', none) -%}
     {%- set dest_columns = args_dict["dest_columns"] -%}
     {%- set temp_relation = args_dict["temp_relation"] -%}
     {%- set target_relation = args_dict["target_relation"] -%}
     {%- set dest_column_names = dest_columns | map(attribute='name') | list -%}
     {%- set dest_cols_csv = get_quoted_column_csv(model, dest_column_names)  -%}
-    INSERT {% if parallel %} /*+PARALLEL({{ parallel }})*/ {% endif %} INTO {{ target_relation }} ({{ dest_cols_csv }})
+    INSERT {% if parallel %} /*+PARALLEL({{ parallel }})*/ {% endif %}
+    {% if insert_mode == 'append' %} /*+ append */ {% endif %}
+    INTO {{ target_relation }} ({{ dest_cols_csv }})
     (
        SELECT {{ dest_cols_csv }}
        FROM {{ temp_relation }}
@@ -108,6 +111,7 @@
 
 {% macro oracle__get_incremental_merge_sql(args_dict) %}
     {%- set parallel = config.get('parallel', none) -%}
+    {%- set insert_mode = config.get('insert_mode', none) -%}
     {%- set dest_columns = args_dict["dest_columns"] -%}
     {%- set temp_relation = args_dict["temp_relation"] -%}
     {%- set target_relation = args_dict["target_relation"] -%}
@@ -138,7 +142,9 @@
             {% endfor -%}
           )
     {%- else -%}
-    insert {% if parallel %} /*+parallel({{ parallel }})*/ {% endif %} into  {{ target_relation }} ({{ dest_cols_csv }})
+    insert {% if parallel %} /*+parallel({{ parallel }})*/ {% endif %}
+    {% if insert_mode == 'append' %} /*+ append */ {% endif %}
+    into  {{ target_relation }} ({{ dest_cols_csv }})
     (
        select {{ dest_cols_csv }}
        from {{ temp_relation }}
@@ -178,6 +184,7 @@
 
 {% macro oracle__get_incremental_delete_insert_sql(args_dict) %}
     {%- set parallel = config.get('parallel', none) -%}
+    {%- set insert_mode = config.get('insert_mode', none) -%}
     {%- set dest_columns = args_dict["dest_columns"] -%}
     {%- set temp_relation = args_dict["temp_relation"] -%}
     {%- set target_relation = args_dict["target_relation"] -%}
@@ -188,12 +195,16 @@
     {%- if unique_key or incremental_predicates -%}
         BEGIN
         EXECUTE IMMEDIATE  '{{ oracle__get_delete_sql_for_delete_insert_strategy(target_relation, temp_relation, unique_key, incremental_predicates) }}';
-        EXECUTE IMMEDIATE 'insert {% if parallel %} /*+parallel({{ parallel }})*/ {% endif %} into  {{ target_relation }} ({{ dest_cols_csv }})(
+        EXECUTE IMMEDIATE 'insert {% if parallel %} /*+parallel({{ parallel }})*/ {% endif %}
+           {% if insert_mode == 'append' %} /*+ append */ {% endif %}
+           into {{ target_relation }} ({{ dest_cols_csv }})(
            select {{ dest_cols_csv }}
            from {{ temp_relation }})';
         END;
     {%- else -%}
-    insert {% if parallel %} /*+parallel({{ parallel }})*/ {% endif %} into  {{ target_relation }} ({{ dest_cols_csv }})
+    insert {% if parallel %} /*+parallel({{ parallel }})*/ {% endif %}
+    {% if insert_mode == 'append' %} /*+ append */ {% endif %}
+    into  {{ target_relation }} ({{ dest_cols_csv }})
     (
        select {{ dest_cols_csv }}
        from {{ temp_relation }}

dbt_adbs_test_project/models/us_product_delete_insert.sql

@@ -20,6 +20,7 @@
         incremental_predicates=["DBT_INTERNAL_DEST.calendar_month_desc > TO_CHAR(sysdate, ''yyyy/mm/dd'')"],
         incremental_strategy='delete+insert',
         parallel=4,
+        insert_mode="append",
         partition_config={"clause": "PARTITION BY HASH(PROD_NAME) PARTITIONS 4"},
         table_compression_clause='COLUMN STORE COMPRESS FOR QUERY LOW')
 }}

setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = dbt-oracle
-version = 1.9.1
+version = 1.9.2
 description = dbt (data build tool) adapter for Oracle Autonomous Database
 long_description = file: README.md
 long_description_content_type = text/markdown

setup.py

@@ -61,7 +61,7 @@
 
 url = 'https://github.com/oracle/dbt-oracle'
 
-VERSION = '1.9.1'
+VERSION = '1.9.2'
 setup(
     author="Oracle",
     python_requires='>=3.9',