Skip to content

Required custom atttribute for Addresses fail to pass validation in checkout #39864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 5 tasks
andirosu opened this issue Apr 25, 2025 · 3 comments
Open
1 of 5 tasks
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.8 Indicates original Magento version for the Issue report.

Comments

@andirosu
Copy link

Preconditions and environment

In a freshly updated 2.4.8. instance, I tried to order as guest. I have some required attributes for the Billing Address, created via a 3rd party module. They fail validation because of the call to \Magento\Quote\Model\CustomerManagement::validateAddresses , where someone hardcoded what attributes should the address have prior testing for validation.
This is the commit which introduced this: e565531

Steps to reproduce

  1. Create a required attribute for billing address.
  2. from the frontend, add items and try to checkout.
  3. complete all required inputs, including the newly-created one.
  4. try to submit your order.

Expected result

Order is placed successfully.

Actual result

Order isn't placed, error "$attribute is required" is thrown by the validator, where $attribute is the label of the newly created attribute in step #1.

Additional information

Let's call the newly-created custom attribute house_number.
When the billing address is saved to the quote, the house_number is saved as expected.
However, when creating and assigning the data to the new customer address in CustomerManagement.php#L164-L172, house_number isn't being transferred, thus triggering the validation error.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Apr 25, 2025

Hi @andirosu. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Apr 25, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.8 Indicates original Magento version for the Issue report. label Apr 25, 2025
@engcom-Bravo
Copy link
Contributor

Hi @andirosu,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the attached video.

Screen.Recording.2025-04-30.at.3.22.41.pm.mov

We are able to place the order successfully.

Kindly recheck the issue in latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.If the issue is related third party module please contact Corresponding extension owners(support).

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Apr 30, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.8 Indicates original Magento version for the Issue report.
Projects
Development

No branches or pull requests

2 participants