Skip to content

Commit 6d69a32

Browse files
committed
fix notifications config pydantic to orm data conversion for create_job_def
1 parent a38af7a commit 6d69a32

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

jupyter_scheduler/scheduler.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,20 @@ def create_job_definition(self, model: CreateJobDefinition) -> str:
549549
if not self.file_exists(model.input_uri):
550550
raise InputUriError(model.input_uri)
551551

552-
job_definition = JobDefinition(**model.dict(exclude_none=True, exclude={"input_uri"}))
552+
orm_notifications_config = None
553+
if model.notifications_config:
554+
orm_notifications_config = NotificationsConfigTable(
555+
**model.notifications_config.dict()
556+
)
557+
session.add(orm_notifications_config)
558+
session.flush()
559+
560+
job_definition_data = model.dict(
561+
exclude={"input_uri", "notifications_config"}, exclude_none=True
562+
)
563+
job_definition = JobDefinition(
564+
**job_definition_data, notifications_config=orm_notifications_config
565+
)
553566
session.add(job_definition)
554567
session.commit()
555568

0 commit comments

Comments
 (0)