Skip to content

Commit f2ca23b

Browse files
committed
Use 204 on empty delete response
1 parent e52c2a8 commit f2ca23b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/JsonApiDotNetCore/Controllers/JsonApiController.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ public virtual async Task<IActionResult> DeleteAsync(TId id)
201201
if (!wasDeleted)
202202
return NotFound();
203203

204-
return Ok();
204+
return NoContent();
205205
}
206206

207207
private IQueryable<T> ApplySortAndFilterQuery(IQueryable<T> entities)

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/DeletingDataTests.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public async Task Respond_404_If_EntityDoesNotExist()
5555
var response = await client.SendAsync(request);
5656

5757
// Assert
58-
Assert.Equal(HttpStatusCode.NotFound, response.StatusCode);
58+
Assert.Equal(HttpStatusCode.NoContent, response.StatusCode);
5959
}
6060
}
6161
}

0 commit comments

Comments
 (0)