Skip to content

Commit 8a57337

Browse files
fix: disable indirects detection on non-PVC
Also add ULTs for getting indirect detection version product helper methods. Related-To: GSD-10453 Signed-off-by: Dominik Dabek <dominik.dabek@intel.com> Source: 894c74b
1 parent cf0acca commit 8a57337

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

shared/source/os_interface/product_helper.inl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ bool ProductHelperHw<gfxProduct>::isDetectIndirectAccessInKernelSupported(const
9292

9393
template <PRODUCT_FAMILY gfxProduct>
9494
uint32_t ProductHelperHw<gfxProduct>::getRequiredDetectIndirectVersion() const {
95-
return IndirectDetectionVersions::requiredDetectIndirectVersionBindless;
95+
return IndirectDetectionVersions::disabled;
9696
}
9797

9898
template <PRODUCT_FAMILY gfxProduct>

shared/test/unit_test/os_interface/product_helper_tests.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,3 +1040,8 @@ HWTEST2_F(ProductHelperTest, givenProductHelperWhenQuery2DBlockStoreThenReturnTr
10401040

10411041
EXPECT_TRUE(productHelper->supports2DBlockStore());
10421042
}
1043+
1044+
HWTEST2_F(ProductHelperTest, givenProductHelperWhenGetRequiredDetectIndirectVersionCalledThenReturnCorrectVersion, IsNotPVC) {
1045+
EXPECT_EQ(IndirectDetectionVersions::disabled, productHelper->getRequiredDetectIndirectVersion());
1046+
EXPECT_EQ(IndirectDetectionVersions::requiredDetectIndirectVersionVectorCompiler, productHelper->getRequiredDetectIndirectVersionVC());
1047+
}

shared/test/unit_test/xe_hpc_core/pvc/test_product_helper_pvc.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
#include "shared/source/command_stream/stream_properties.h"
99
#include "shared/source/helpers/constants.h"
10+
#include "shared/source/helpers/definitions/indirect_detection_versions.h"
1011
#include "shared/source/kernel/kernel_descriptor.h"
1112
#include "shared/source/os_interface/product_helper.h"
1213
#include "shared/source/xe_hpc_core/hw_cmds_pvc.h"
@@ -291,4 +292,9 @@ PVCTEST_F(PvcProductHelper, whenQueryingMaxNumSamplersThenReturnZero) {
291292

292293
PVCTEST_F(PvcProductHelper, givenProductHelperWhenAskingForReadOnlyResourceSupportThenTrueReturned) {
293294
EXPECT_TRUE(productHelper->supportReadOnlyAllocations());
294-
}
295+
}
296+
297+
PVCTEST_F(PvcProductHelper, givenProductHelperWhenGetRequiredDetectIndirectVersionCalledThenReturnCorrectVersion) {
298+
EXPECT_EQ(IndirectDetectionVersions::requiredDetectIndirectVersionPVC, productHelper->getRequiredDetectIndirectVersion());
299+
EXPECT_EQ(IndirectDetectionVersions::requiredDetectIndirectVersionPVC, productHelper->getRequiredDetectIndirectVersionVC());
300+
}

0 commit comments

Comments
 (0)