Skip to content

Commit 068acba

Browse files
fix: apply suggestions from code review
Co-authored-by: Hiroyuki Sato <hiroysato@gmail.com>
1 parent e9cc945 commit 068acba

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/embulk/output/bigquery.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ def self.configure(config, schema, task_count)
240240

241241
if Helper.has_partition_decorator?(task['table'])
242242
if task['range_partitioning']
243-
raise ConfigError.new "partition decorator doesn't support with `range_partition`"
243+
raise ConfigError.new "Partition decorators(`#{task['table']}`) don't support `range_partition`"
244244
end
245245
task['time_partitioning'] = {'type' => 'DAY'}
246246
end
@@ -272,7 +272,7 @@ def self.configure(config, schema, task_count)
272272
unless range['interval'].is_a?(Integer)
273273
raise ConfigError.new "`range_partitioning.range.interval` must be an integer"
274274
end
275-
if range['start'] + range['interval'] > range['end']
275+
if range['start'] + range['interval'] >= range['end']
276276
raise ConfigError.new "`range_partitioning.range.start` + `range_partitioning.range.interval` must be less than `range_partitioning.range.end`"
277277
end
278278
end

test/test_configure.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ def test_time_partitioning
271271
end
272272

273273
def test_range_partitioning
274-
config = least_config.merge('range_partitioning' => {'field' => 'foo', 'range' => { 'start' => 1, 'end' => 2, 'interval' => 1 }})
274+
config = least_config.merge('range_partitioning' => {'field' => 'foo', 'range' => { 'start' => 1, 'end' => 3, 'interval' => 1 }})
275275
assert_nothing_raised { Bigquery.configure(config, schema, processor_count) }
276276

277277
# field is required

0 commit comments

Comments
 (0)