Skip to content

Commit b1ac074

Browse files
authored
Merge pull request #627 from emberjs/tooling-may-06
add notes for tooling 6th May
2 parents 14a773b + ca054ac commit b1ac074

File tree

2 files changed

+57
-1
lines changed

2 files changed

+57
-1
lines changed

st-embroider/2024/2025-05-06.md

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
# 2025-05-06
2+
3+
Note Taker: Chris Manson
4+
Time Keeper: Chris Manson
5+
6+
## Attendees
7+
8+
Add yourself to the list if you attend and check the box!
9+
10+
- [x] Ed Faulkner (EF)
11+
- [x] Chris Manson (CM)
12+
- [x] Alex (A)
13+
- [x] Preston Sego (PS)
14+
- [x] Simon Ihmig (SI)
15+
- [ ] Katie Gengler (KG)
16+
- [ ] Peter Meehan (PM)
17+
- [ ] Krystan HuffMenne (KH)
18+
- [ ] Peter Wagenet (PW)
19+
- [ ] James Davis (JD)
20+
21+
## Topics
22+
23+
### Project planning
24+
25+
- dicsussions around the project planning board
26+
- all blueprint addons need to be v2
27+
- we are ready to fix ember-auto-import issues
28+
- we can just remove it and work through the breakages
29+
-
30+
31+
### Review https://github.com/embroider-build/embroider/pull/2466 <ef4>
32+
33+
- (deep dive into the proposed fix)
34+
- found a better solution
35+
- commented on the PR
36+
37+
### Macros unintentional breaking change <ef4>
38+
39+
- (discussed to figure out how fix this)
40+
- https://github.com/embroider-build/embroider/pull/2439 is a good CI failing
41+
- EF: I've added a todo to fix this
42+
43+
### Review https://github.com/embroider-build/embroider/pull/2464 <@NullVoxPopuli>
44+
45+
- approved
46+
- github having issues, waiting for CI to pass
47+
48+
### template-tag-codemod can’t find helpers from @ember/string <@mansona>
49+
50+
- ember string never provided any helpers
51+
- this is likely an issue with some other addon exporting the helper
52+
- to debug: step into the capitalize helper using `{{debugger}}` in the hbs and see where the file is actually coming from
53+
- (discussion about custom resolver not allowing you to have named imports)
54+
- agreement: we can optionally return an object with the named import that we want to support
55+
56+
<5 min> Review https://github.com/embroider-build/embroider/issues/2461 <ef4>
57+
<10 min> Review remaining work for v2 addon blueprint to be default - including blueprints <ef4>

st-embroider/template.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ Add yourself to the list if you attend and check the box!
99

1010
- [ ] Ed Faulkner (EF)
1111
- [ ] Chris Manson (CM)
12-
- [ ] Aaron Chambers (AC)
1312
- [ ] Alex (A)
1413
- [ ] Preston Sego (PS)
1514
- [ ] Simon Ihmig (SI)

0 commit comments

Comments
 (0)