Replies: 9 comments
-
@vishnus17 thanks for your suggestion, we will take a look and get back to you |
Beta Was this translation helpful? Give feedback.
-
Thanks @dougtoppin |
Beta Was this translation helpful? Give feedback.
-
Hi @dougtoppin . Any updates on this? |
Beta Was this translation helpful? Give feedback.
-
@vishnus17 we have not gotten to your approach yet but it is on our list to take a look at, thanks for submitting it |
Beta Was this translation helpful? Give feedback.
-
Hi @dougtoppin . |
Beta Was this translation helpful? Give feedback.
-
@vishnus17 thanks for the update, we will take a look and give you feedback on any comments that we have |
Beta Was this translation helpful? Give feedback.
-
Hi @dougtoppin. |
Beta Was this translation helpful? Give feedback.
-
@vishnus17 This is more appropriate as a discussion rather that an issue, it was moved here. We were not sure what simplifications that you made but it looks like the cdk.json context is being used more extensively. Since the js files are controlled rather than the ts files for the Lambdas it was difficult to do a side-by-side comparison to ensure that all the same capabilities are being supported. If you want to explain the simplification changes and the reason for controlling js, rather than ts, we can continue the discussion here. |
Beta Was this translation helpful? Give feedback.
-
@dougtoppin I've recreated the solution to a CDK project which helps to customize the solution as a whole from one stack - like the SIH lambda environment variables to make modifications or changes to CloudFront etc. You can read more about it here: https://vishnusblog.tech/serverless-image-handler-cdk-v2-simplified-implementation-sih-cdk-solution#heading-modifying-the-serverless-image-handler-solution |
Beta Was this translation helpful? Give feedback.
-
Implementing CDKv2 of the SIH solution.
I found it hard to modify the SIH solution and wanted the flexibility to deploy it using CDK so I designed a CDK v2 version of the solution so that users can modify the solution easily.
Please review it here and let me know what you think of it: https://github.com/vishnus17/serverless-image-handler-cdkv2
Thanks
Beta Was this translation helpful? Give feedback.
All reactions