From 49be153622b11ac4490036276fd6fdb02792bc53 Mon Sep 17 00:00:00 2001
From: PhelixWanty <phelixw2003@gmail.com>
Date: Thu, 1 May 2025 00:15:49 -0400
Subject: [PATCH 1/2] Improve documentation for binary search algorithm

---
 searches/binary_search.py | 58 +++++++++++++++++++--------------------
 1 file changed, 28 insertions(+), 30 deletions(-)

diff --git a/searches/binary_search.py b/searches/binary_search.py
index 2e66b672d5b4..519ef1ab304e 100644
--- a/searches/binary_search.py
+++ b/searches/binary_search.py
@@ -178,42 +178,40 @@ def insort_right(
     sorted_collection.insert(bisect_right(sorted_collection, item, lo, hi), item)
 
 
-def binary_search(sorted_collection: list[int], item: int) -> int:
-    """Pure implementation of a binary search algorithm in Python
+# Binary Search Algorithm
+# Binary Search is an efficient algorithm for finding an item from a sorted list of items.
+# It works by repeatedly dividing in half the portion of the list that could contain the item,
+# until you've narrowed the possible locations to just one.
 
-    Be careful collection must be ascending sorted otherwise, the result will be
-    unpredictable
+def binary_search(arr, x):
+    """
+    Perform a binary search to find the element `x` in the sorted list `arr`.
 
-    :param sorted_collection: some ascending sorted collection with comparable items
-    :param item: item value to search
-    :return: index of the found item or -1 if the item is not found
+    Parameters:
+    arr (list): A sorted list of elements
+    x (int or float): The element to search for in the list
 
-    Examples:
-    >>> binary_search([0, 5, 7, 10, 15], 0)
-    0
-    >>> binary_search([0, 5, 7, 10, 15], 15)
-    4
-    >>> binary_search([0, 5, 7, 10, 15], 5)
-    1
-    >>> binary_search([0, 5, 7, 10, 15], 6)
-    -1
+    Returns:
+    int: The index of the element `x` in the list `arr`. If `x` is not found, returns -1.
     """
-    if list(sorted_collection) != sorted(sorted_collection):
-        raise ValueError("sorted_collection must be sorted in ascending order")
-    left = 0
-    right = len(sorted_collection) - 1
-
-    while left <= right:
-        midpoint = left + (right - left) // 2
-        current_item = sorted_collection[midpoint]
-        if current_item == item:
-            return midpoint
-        elif item < current_item:
-            right = midpoint - 1
+    low = 0
+    high = len(arr) - 1
+
+    while low <= high:
+        mid = (low + high) // 2
+
+        # If x is found at the mid index
+        if arr[mid] == x:
+            return mid
+        # If x is smaller than mid, search in the left half
+        elif arr[mid] > x:
+            high = mid - 1
+        # If x is larger than mid, search in the right half
         else:
-            left = midpoint + 1
-    return -1
+            low = mid + 1
 
+    # Return -1 if element is not present in the list
+    return -1
 
 def binary_search_std_lib(sorted_collection: list[int], item: int) -> int:
     """Pure implementation of a binary search algorithm in Python using stdlib

From 58a27b791c3e5d163902f7879fbb7c03fcabd008 Mon Sep 17 00:00:00 2001
From: "pre-commit-ci[bot]"
 <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date: Thu, 1 May 2025 04:16:39 +0000
Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
---
 searches/binary_search.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/searches/binary_search.py b/searches/binary_search.py
index 519ef1ab304e..3ae8a4ecbdec 100644
--- a/searches/binary_search.py
+++ b/searches/binary_search.py
@@ -183,6 +183,7 @@ def insort_right(
 # It works by repeatedly dividing in half the portion of the list that could contain the item,
 # until you've narrowed the possible locations to just one.
 
+
 def binary_search(arr, x):
     """
     Perform a binary search to find the element `x` in the sorted list `arr`.
@@ -213,6 +214,7 @@ def binary_search(arr, x):
     # Return -1 if element is not present in the list
     return -1
 
+
 def binary_search_std_lib(sorted_collection: list[int], item: int) -> int:
     """Pure implementation of a binary search algorithm in Python using stdlib