Skip to content

Commit 34526b3

Browse files
author
Ron Radtke
committed
Fixing small issue
1 parent 7fa26be commit 34526b3

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

android/src/main/java/com/ReactNativeBlobUtil/ReactNativeBlobUtil.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,6 +465,10 @@ public void copyToMediaStore(ReadableMap filedata, String mt, String path, Promi
465465
promise.reject("ReactNativeBlobUtil.createMediaFile", "invalid mediatype");
466466
return;
467467
}
468+
if (path == null) {
469+
promise.reject("ReactNativeBlobUtil.createMediaFile", "invalid path");
470+
return;
471+
}
468472

469473
FileDescription file = new FileDescription(filedata.getString("name"), filedata.getString("mimeType"), filedata.getString("parentFolder"));
470474
Uri fileuri = ReactNativeBlobUtilMediaCollection.createNewMediaFile(file, ReactNativeBlobUtilMediaCollection.MediaType.valueOf(mt));
@@ -476,7 +480,7 @@ public void copyToMediaStore(ReadableMap filedata, String mt, String path, Promi
476480

477481
boolean res = ReactNativeBlobUtilMediaCollection.writeToMediaFile(fileuri, path, promise);
478482

479-
if(res) promise.resolve(fileuri);
483+
if(res) promise.resolve(fileuri.toString());
480484
}
481485

482486
}

android/src/main/java/com/ReactNativeBlobUtil/ReactNativeBlobUtilMediaCollection.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ public static boolean writeToMediaFile(Uri fileUri, String data, Promise promise
130130
File src = new File(normalizedData);
131131
if (!src.exists()) {
132132
promise.reject("ENOENT", "No such file ('" + normalizedData + "')");
133-
return;
133+
return false;
134134
}
135135
byte[] buf = new byte[10240];
136136
int read;
@@ -179,7 +179,9 @@ public static boolean writeToMediaFile(Uri fileUri, String data, Promise promise
179179

180180
} catch (IOException e) {
181181
promise.reject("ReactNativeBlobUtil.createMediaFile", "Cannot write to file, file might not exist");
182+
return false;
182183
}
184+
return true;
183185
}
184186

185187
public static void copyToInternal(Uri contenturi, String destpath, Promise promise) {

0 commit comments

Comments
 (0)