Skip to content

Commit fbaaf3f

Browse files
committed
Workaround for StackBlitz bug: don't bump version in demo on release
StackBlitz still can't see new releases immediately (stackblitz/core#624). Because the StackBlitz demo is taken from master, it fails if we bump the react-lifecycle-visualizer version before the package is visible on StackBlitz.
1 parent 3e9b08c commit fbaaf3f

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

examples/parent-child-demo/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@
1515
"react": "^16.12.0",
1616
"react-dom": "^16.12.0",
1717
"react-hot-loader": "^4.12.18",
18-
"react-lifecycle-visualizer": "^2.2.6"
18+
"react-lifecycle-visualizer": "^2.2.5"
1919
}
2020
}

scripts/tag-release.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ then
3434
echo "Bumping version from ${vMajor}.${vMinor}.${vPatch} to ${newVersion}"
3535

3636
sed -i '' -e "s/\(\"version\": *\"\).*\(\".*\)$/\1${newVersion}\2/" package.json
37-
sed -i '' -e "s/\(\"react-lifecycle-visualizer\": *\"[\^~]\{0,1\}\).*\(\".*\)$/\1${newVersion}\2/" examples/parent-child-demo/package.json
37+
# Don't update demo dependency on release, as StackBlitz still has problems seeing newly released packages.
38+
# sed -i '' -e "s/\(\"react-lifecycle-visualizer\": *\"[\^~]\{0,1\}\).*\(\".*\)$/\1${newVersion}\2/" examples/parent-child-demo/package.json
3839
npm i
3940
git add package.json package-lock.json examples/parent-child-demo/package.json
4041
git commit -m "Release ${newVersion}"

0 commit comments

Comments
 (0)