Skip to content

Keep displaying Spinner when Assets is downloaded after navigating #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danieldanielecki opened this issue Jun 16, 2024 · 2 comments · Fixed by #44
Closed

Keep displaying Spinner when Assets is downloaded after navigating #30

danieldanielecki opened this issue Jun 16, 2024 · 2 comments · Fixed by #44
Assignees
@b3n3w
Labels
enhancement New feature or request hacktoberfest

Comments

@danieldanielecki
Copy link
Member

Whenever the user navigates when the assets are being downloaded, but not finished, and navigating back, the screen is stuck and it's not possible to enter the course anymore. Would make sense to retry downloaded assets, whether to start from the moment it finished (best scenario), or simply retry all over.

image
@danieldanielecki danieldanielecki added the bug Something isn't working label Jun 16, 2024
@danieldanielecki danieldanielecki changed the title Retry Download Assets after navigatinf Retry Download Assets after navigating Jun 16, 2024
@danieldanielecki
Copy link
Member Author

Update: it looks like somehow it retries & downloads, so it's just about displaying the spinner to the user.

image

@danieldanielecki
Copy link
Member Author

Proof of showing it works, somehow.

image

@danieldanielecki danieldanielecki changed the title Retry Download Assets after navigating (keep) Display spinner Download Assets after navigating Jun 16, 2024
@danieldanielecki danieldanielecki changed the title (keep) Display spinner Download Assets after navigating Keep displaying Spinner when Assets is downloaded after navigating Jun 16, 2024
@danieldanielecki danieldanielecki added enhancement New feature or request and removed bug Something isn't working labels Jun 16, 2024
@b3n3w b3n3w linked a pull request Oct 29, 2024 that will close this issue
30 keep displaying spinner when assets is downloaded after navigating #44
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b3n3w b3n3w

Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

30 keep displaying spinner when assets is downloaded after navigating Ditectrev/CloudMaster-Swift
2 participants
@danieldanielecki @b3n3w