Fixed some scrutinizer issues

maab16 · maab16 · commit 77d74220d9dd · 2020-01-07T06:48:29.000+06:00
diff --git a/src/Http/Controllers/CrudController.php b/src/Http/Controllers/CrudController.php
@@ -22,7 +22,7 @@ public function index()
     /**
      * Create|Update CRUD
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function storeOrUpdate(Request $request)
     {
@@ -70,7 +70,7 @@ public function storeOrUpdate(Request $request)
      *
      * @param array $table
      *
-     * @return \Illuminate\Http\Response|true
+     * @return \Illuminate\Http\JsonResponse|true
      */
     public function makeModel($table)
     {
@@ -163,7 +163,7 @@ public function addOrUpdateField($column, $object)
     /**
      * Delete CRUD
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function delete(Request $request)
     {
@@ -188,7 +188,7 @@ public function delete(Request $request)
      *
      * @param array $errors
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     protected function generateError($errors)
     {
diff --git a/src/Http/Controllers/DatabaseController.php b/src/Http/Controllers/DatabaseController.php
@@ -24,7 +24,7 @@ public function index()
     /**
      * Create CRUD
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function create(Request $request)
     {
@@ -150,7 +150,7 @@ public function updateMongoDbTable($table)
      * @param array $column
      * @param array $fieldNames
      *
-     * @return \Illuminate\Http\Response|void
+     * @return \Illuminate\Http\JsonResponse|void
      */
     public function addOrUpdateCrudField($object, $column, &$fieldNames)
     {
@@ -249,7 +249,7 @@ public function updateCrudFields($table)
     /**
      * Update Table
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function update(Request $request)
     {
@@ -302,7 +302,7 @@ public function update(Request $request)
     /**
      * Create Table
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function delete(Request $request)
     {
diff --git a/src/Http/Controllers/ObjectController.php b/src/Http/Controllers/ObjectController.php
@@ -14,7 +14,7 @@ class ObjectController extends Controller
     /**
      * Get all objects
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function all(Request $request)
     {
@@ -76,7 +76,7 @@ public function filterCrudTables($tables)
     /**
      * Get Object details
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function getObjectDetails(Request $request)
     {
@@ -217,7 +217,7 @@ public function getRelationshipDetails($tableName)
      *
      * @param array $errors
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     protected function generateError($errors)
     {
diff --git a/src/Http/Controllers/PermissionController.php b/src/Http/Controllers/PermissionController.php
@@ -19,7 +19,7 @@ public function index()
     /**
      * Get all users with permissions
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function all(Request $request)
     {
@@ -83,7 +83,7 @@ public function all(Request $request)
     /**
      * Assign Permissions to User
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function assignUserPermissions(Request $request)
     {
@@ -106,7 +106,7 @@ public function assignUserPermissions(Request $request)
     /**
      * Update User Permissions
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function syncUserPermissions(Request $request)
     {
@@ -129,7 +129,7 @@ public function syncUserPermissions(Request $request)
     /**
      * Delete User Permissions
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function deleteUserPermissions(Request $request)
     {
diff --git a/src/Http/Controllers/RecordController.php b/src/Http/Controllers/RecordController.php
@@ -24,7 +24,7 @@ public function index()
     /**
      * Create Record
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function store(Request $request)
     {
@@ -103,7 +103,7 @@ public function processStoreData($request, $object)
     /**
      * Update Record
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function update(Request $request)
     {
@@ -187,7 +187,7 @@ public function processUpdateData($request, $object)
     /**
      * Delete Record
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function delete(Request $request)
     {
@@ -234,7 +234,7 @@ public function delete(Request $request)
     /**
      * Get Table Details
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function getTableDetails(Request $request)
     {
diff --git a/src/Http/Controllers/RelationController.php b/src/Http/Controllers/RelationController.php
@@ -14,7 +14,7 @@ class RelationController extends Controller
     /**
      * Get Relation
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function get(Request $request)
     {
@@ -66,7 +66,7 @@ public function prepareRelationshipField($fields, $field)
     /**
      * Create Relation
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function add(Request $request)
     {
@@ -106,7 +106,7 @@ public function add(Request $request)
     /**
      * Check Errors
      *
-     * @return \Illuminate\Http\Response|true
+     * @return \Illuminate\Http\JsonResponse|true
      */
     public function checkErrors($relationship)
     {
@@ -166,7 +166,7 @@ public function prepareSettings($relationship)
     /**
      * Update Relationship
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function update(Request $request)
     {
@@ -197,7 +197,7 @@ public function update(Request $request)
     /**
      * Delete Relation
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function delete(Request $request)
     {
@@ -224,7 +224,7 @@ public function delete(Request $request)
      *
      * @param array $errors
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     protected function generateError($errors)
     {
diff --git a/src/Http/Controllers/TableController.php b/src/Http/Controllers/TableController.php
@@ -11,7 +11,7 @@ class TableController extends Controller
     /**
      * Get all Tables
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function all(Request $request)
     {
@@ -54,7 +54,7 @@ public function all(Request $request)
     /**
      * Get Table Details
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function getTable(Request $request)
     {
@@ -106,7 +106,7 @@ public function getTable(Request $request)
     /**
      * Get Table Columns
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function getTableColumns(Request $request)
     {
diff --git a/src/Http/Controllers/TemplateController.php b/src/Http/Controllers/TemplateController.php
@@ -38,7 +38,7 @@ public function updateTemplates(Request $request)
     /**
      * Create a new template
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function save(Request $request)
     {
@@ -78,7 +78,7 @@ public function save(Request $request)
     /**
      * Remove a template
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function remove(Request $request)
     {
diff --git a/src/Http/Controllers/UserController.php b/src/Http/Controllers/UserController.php
@@ -23,7 +23,7 @@ public function showLoginForm()
     /**
      * Login User for API
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function login(Request $request)
     {
@@ -61,7 +61,7 @@ public function login(Request $request)
     /**
      * Get access token for API
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function getPersonalAccessToken(Request $request)
     {
diff --git a/src/Manager.php b/src/Manager.php
@@ -335,7 +335,7 @@ public function checkPermission($prefix, $slug)
     /**
      * Check user authorization
      *
-     * @return \Illuminate\Http\Response|true
+     * @return \Illuminate\Http\JsonResponse|true
      */
     public function authorize($permission)
     {

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public function index()`
`22`	`22`	`/**`
`23`	`23`	`* Create\|Update CRUD`
`24`	`24`	`*`
`25`		`- * @return \Illuminate\Http\Response`
	`25`	`+ * @return \Illuminate\Http\JsonResponse`
`26`	`26`	`*/`
`27`	`27`	`public function storeOrUpdate(Request $request)`
`28`	`28`	`{`
`@@ -70,7 +70,7 @@ public function storeOrUpdate(Request $request)`
`70`	`70`	`*`
`71`	`71`	`* @param array $table`
`72`	`72`	`*`
`73`		`- * @return \Illuminate\Http\Response\|true`
	`73`	`+ * @return \Illuminate\Http\JsonResponse\|true`
`74`	`74`	`*/`
`75`	`75`	`public function makeModel($table)`
`76`	`76`	`{`
`@@ -163,7 +163,7 @@ public function addOrUpdateField($column, $object)`
`163`	`163`	`/**`
`164`	`164`	`* Delete CRUD`
`165`	`165`	`*`
`166`		`- * @return \Illuminate\Http\Response`
	`166`	`+ * @return \Illuminate\Http\JsonResponse`
`167`	`167`	`*/`
`168`	`168`	`public function delete(Request $request)`
`169`	`169`	`{`
`@@ -188,7 +188,7 @@ public function delete(Request $request)`
`188`	`188`	`*`
`189`	`189`	`* @param array $errors`
`190`	`190`	`*`
`191`		`- * @return \Illuminate\Http\Response`
	`191`	`+ * @return \Illuminate\Http\JsonResponse`
`192`	`192`	`*/`
`193`	`193`	`protected function generateError($errors)`
`194`	`194`	`{`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public function index()`
`24`	`24`	`/**`
`25`	`25`	`* Create CRUD`
`26`	`26`	`*`
`27`		`- * @return \Illuminate\Http\Response`
	`27`	`+ * @return \Illuminate\Http\JsonResponse`
`28`	`28`	`*/`
`29`	`29`	`public function create(Request $request)`
`30`	`30`	`{`
`@@ -150,7 +150,7 @@ public function updateMongoDbTable($table)`
`150`	`150`	`* @param array $column`
`151`	`151`	`* @param array $fieldNames`
`152`	`152`	`*`
`153`		`- * @return \Illuminate\Http\Response\|void`
	`153`	`+ * @return \Illuminate\Http\JsonResponse\|void`
`154`	`154`	`*/`
`155`	`155`	`public function addOrUpdateCrudField($object, $column, &$fieldNames)`
`156`	`156`	`{`
`@@ -249,7 +249,7 @@ public function updateCrudFields($table)`
`249`	`249`	`/**`
`250`	`250`	`* Update Table`
`251`	`251`	`*`
`252`		`- * @return \Illuminate\Http\Response`
	`252`	`+ * @return \Illuminate\Http\JsonResponse`
`253`	`253`	`*/`
`254`	`254`	`public function update(Request $request)`
`255`	`255`	`{`
`@@ -302,7 +302,7 @@ public function update(Request $request)`
`302`	`302`	`/**`
`303`	`303`	`* Create Table`
`304`	`304`	`*`
`305`		`- * @return \Illuminate\Http\Response`
	`305`	`+ * @return \Illuminate\Http\JsonResponse`
`306`	`306`	`*/`
`307`	`307`	`public function delete(Request $request)`
`308`	`308`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ class ObjectController extends Controller`
`14`	`14`	`/**`
`15`	`15`	`* Get all objects`
`16`	`16`	`*`
`17`		`- * @return \Illuminate\Http\Response`
	`17`	`+ * @return \Illuminate\Http\JsonResponse`
`18`	`18`	`*/`
`19`	`19`	`public function all(Request $request)`
`20`	`20`	`{`
`@@ -76,7 +76,7 @@ public function filterCrudTables($tables)`
`76`	`76`	`/**`
`77`	`77`	`* Get Object details`
`78`	`78`	`*`
`79`		`- * @return \Illuminate\Http\Response`
	`79`	`+ * @return \Illuminate\Http\JsonResponse`
`80`	`80`	`*/`
`81`	`81`	`public function getObjectDetails(Request $request)`
`82`	`82`	`{`
`@@ -217,7 +217,7 @@ public function getRelationshipDetails($tableName)`
`217`	`217`	`*`
`218`	`218`	`* @param array $errors`
`219`	`219`	`*`
`220`		`- * @return \Illuminate\Http\Response`
	`220`	`+ * @return \Illuminate\Http\JsonResponse`
`221`	`221`	`*/`
`222`	`222`	`protected function generateError($errors)`
`223`	`223`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public function index()`
`19`	`19`	`/**`
`20`	`20`	`* Get all users with permissions`
`21`	`21`	`*`
`22`		`- * @return \Illuminate\Http\Response`
	`22`	`+ * @return \Illuminate\Http\JsonResponse`
`23`	`23`	`*/`
`24`	`24`	`public function all(Request $request)`
`25`	`25`	`{`
`@@ -83,7 +83,7 @@ public function all(Request $request)`
`83`	`83`	`/**`
`84`	`84`	`* Assign Permissions to User`
`85`	`85`	`*`
`86`		`- * @return \Illuminate\Http\Response`
	`86`	`+ * @return \Illuminate\Http\JsonResponse`
`87`	`87`	`*/`
`88`	`88`	`public function assignUserPermissions(Request $request)`
`89`	`89`	`{`
`@@ -106,7 +106,7 @@ public function assignUserPermissions(Request $request)`
`106`	`106`	`/**`
`107`	`107`	`* Update User Permissions`
`108`	`108`	`*`
`109`		`- * @return \Illuminate\Http\Response`
	`109`	`+ * @return \Illuminate\Http\JsonResponse`
`110`	`110`	`*/`
`111`	`111`	`public function syncUserPermissions(Request $request)`
`112`	`112`	`{`
`@@ -129,7 +129,7 @@ public function syncUserPermissions(Request $request)`
`129`	`129`	`/**`
`130`	`130`	`* Delete User Permissions`
`131`	`131`	`*`
`132`		`- * @return \Illuminate\Http\Response`
	`132`	`+ * @return \Illuminate\Http\JsonResponse`
`133`	`133`	`*/`
`134`	`134`	`public function deleteUserPermissions(Request $request)`
`135`	`135`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ class RelationController extends Controller`
`14`	`14`	`/**`
`15`	`15`	`* Get Relation`
`16`	`16`	`*`
`17`		`- * @return \Illuminate\Http\Response`
	`17`	`+ * @return \Illuminate\Http\JsonResponse`
`18`	`18`	`*/`
`19`	`19`	`public function get(Request $request)`
`20`	`20`	`{`
`@@ -66,7 +66,7 @@ public function prepareRelationshipField($fields, $field)`
`66`	`66`	`/**`
`67`	`67`	`* Create Relation`
`68`	`68`	`*`
`69`		`- * @return \Illuminate\Http\Response`
	`69`	`+ * @return \Illuminate\Http\JsonResponse`
`70`	`70`	`*/`
`71`	`71`	`public function add(Request $request)`
`72`	`72`	`{`
`@@ -106,7 +106,7 @@ public function add(Request $request)`
`106`	`106`	`/**`
`107`	`107`	`* Check Errors`
`108`	`108`	`*`
`109`		`- * @return \Illuminate\Http\Response\|true`
	`109`	`+ * @return \Illuminate\Http\JsonResponse\|true`
`110`	`110`	`*/`
`111`	`111`	`public function checkErrors($relationship)`
`112`	`112`	`{`
`@@ -166,7 +166,7 @@ public function prepareSettings($relationship)`
`166`	`166`	`/**`
`167`	`167`	`* Update Relationship`
`168`	`168`	`*`
`169`		`- * @return \Illuminate\Http\Response`
	`169`	`+ * @return \Illuminate\Http\JsonResponse`
`170`	`170`	`*/`
`171`	`171`	`public function update(Request $request)`
`172`	`172`	`{`
`@@ -197,7 +197,7 @@ public function update(Request $request)`
`197`	`197`	`/**`
`198`	`198`	`* Delete Relation`
`199`	`199`	`*`
`200`		`- * @return \Illuminate\Http\Response`
	`200`	`+ * @return \Illuminate\Http\JsonResponse`
`201`	`201`	`*/`
`202`	`202`	`public function delete(Request $request)`
`203`	`203`	`{`
`@@ -224,7 +224,7 @@ public function delete(Request $request)`
`224`	`224`	`*`
`225`	`225`	`* @param array $errors`
`226`	`226`	`*`
`227`		`- * @return \Illuminate\Http\Response`
	`227`	`+ * @return \Illuminate\Http\JsonResponse`
`228`	`228`	`*/`
`229`	`229`	`protected function generateError($errors)`
`230`	`230`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ class TableController extends Controller`
`11`	`11`	`/**`
`12`	`12`	`* Get all Tables`
`13`	`13`	`*`
`14`		`- * @return \Illuminate\Http\Response`
	`14`	`+ * @return \Illuminate\Http\JsonResponse`
`15`	`15`	`*/`
`16`	`16`	`public function all(Request $request)`
`17`	`17`	`{`
`@@ -54,7 +54,7 @@ public function all(Request $request)`
`54`	`54`	`/**`
`55`	`55`	`* Get Table Details`
`56`	`56`	`*`
`57`		`- * @return \Illuminate\Http\Response`
	`57`	`+ * @return \Illuminate\Http\JsonResponse`
`58`	`58`	`*/`
`59`	`59`	`public function getTable(Request $request)`
`60`	`60`	`{`
`@@ -106,7 +106,7 @@ public function getTable(Request $request)`
`106`	`106`	`/**`
`107`	`107`	`* Get Table Columns`
`108`	`108`	`*`
`109`		`- * @return \Illuminate\Http\Response`
	`109`	`+ * @return \Illuminate\Http\JsonResponse`
`110`	`110`	`*/`
`111`	`111`	`public function getTableColumns(Request $request)`
`112`	`112`	`{`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function updateTemplates(Request $request)`
`38`	`38`	`/**`
`39`	`39`	`* Create a new template`
`40`	`40`	`*`
`41`		`- * @return \Illuminate\Http\Response`
	`41`	`+ * @return \Illuminate\Http\JsonResponse`
`42`	`42`	`*/`
`43`	`43`	`public function save(Request $request)`
`44`	`44`	`{`
`@@ -78,7 +78,7 @@ public function save(Request $request)`
`78`	`78`	`/**`
`79`	`79`	`* Remove a template`
`80`	`80`	`*`
`81`		`- * @return \Illuminate\Http\Response`
	`81`	`+ * @return \Illuminate\Http\JsonResponse`
`82`	`82`	`*/`
`83`	`83`	`public function remove(Request $request)`
`84`	`84`	`{`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ public function showLoginForm()`
`23`	`23`	`/**`
`24`	`24`	`* Login User for API`
`25`	`25`	`*`
`26`		`- * @return \Illuminate\Http\Response`
	`26`	`+ * @return \Illuminate\Http\JsonResponse`
`27`	`27`	`*/`
`28`	`28`	`public function login(Request $request)`
`29`	`29`	`{`
`@@ -61,7 +61,7 @@ public function login(Request $request)`
`61`	`61`	`/**`
`62`	`62`	`* Get access token for API`
`63`	`63`	`*`
`64`		`- * @return \Illuminate\Http\Response`
	`64`	`+ * @return \Illuminate\Http\JsonResponse`
`65`	`65`	`*/`
`66`	`66`	`public function getPersonalAccessToken(Request $request)`
`67`	`67`	`{`
Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ public function checkPermission($prefix, $slug)`
`335`	`335`	`/**`
`336`	`336`	`* Check user authorization`
`337`	`337`	`*`
`338`		`- * @return \Illuminate\Http\Response\|true`
	`338`	`+ * @return \Illuminate\Http\JsonResponse\|true`
`339`	`339`	`*/`
`340`	`340`	`public function authorize($permission)`
`341`	`341`	`{`