Skip to content

Commit f13d924

Browse files
committed
feat - add "cancel" to bookmarks & snippets update forms
1 parent 8ee09bc commit f13d924

File tree

7 files changed

+32
-12
lines changed

7 files changed

+32
-12
lines changed

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ services:
2323
POSTGRES_PASSWORD: password
2424
keycloak:
2525
container_name: codever-keycloak
26-
image: jboss/keycloak:6.0.1
26+
image: jboss/keycloak:7.0.0
2727
networks:
2828
- backend
2929
environment:

frontend/src/app/my-bookmarks/save-bookmark-form/save-bookmark-form.component.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,9 @@
173173
<button type="submit" class="btn btn-primary" [disabled]="!bookmarkForm.valid || personalBookmarkPresent">
174174
Save bookmark
175175
</button>
176+
<button type="button" class="btn btn-secondary ml-2" (click)="cancelUpdate()">
177+
Cancel <i class="far fa-times-circle"></i>
178+
</button>
176179
</form>
177180
</div>
178181

frontend/src/app/my-bookmarks/save-bookmark-form/save-bookmark-form.component.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ import { textSizeValidator } from '../../core/validators/text-size.validator';
3535
import { StackoverflowHelper } from '../../core/helper/stackoverflow.helper';
3636
import { UserDataPinnedStore } from '../../core/user/userdata.pinned.store';
3737
import { MatChipInputEvent } from '@angular/material/chips';
38+
import { Location } from '@angular/common';
3839
import { MatAutocompleteActivatedEvent, MatAutocompleteSelectedEvent } from '@angular/material/autocomplete';
3940
import iziToast, { IziToastSettings } from 'izitoast';
4041

@@ -118,6 +119,7 @@ export class SaveBookmarkFormComponent implements OnInit {
118119
private userDataPinnedStore: UserDataPinnedStore,
119120
private stackoverflowHelper: StackoverflowHelper,
120121
private datePipe: DatePipe,
122+
private _location: Location,
121123
private logger: Logger,
122124
private router: Router,
123125
private route: ActivatedRoute,
@@ -584,6 +586,11 @@ export class SaveBookmarkFormComponent implements OnInit {
584586
const link = [`./my-bookmarks/${this.existingPersonalBookmark._id}/edit`];
585587
this.router.navigate(link, {state: {bookmark: this.existingPersonalBookmark}});
586588
}
589+
590+
cancelUpdate() {
591+
this._location.back();
592+
console.log('goBAck()...');
593+
}
587594
}
588595

589596

frontend/src/app/my-snippets/create-snippet-form/create-snippet-form.component.html

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,9 @@
5959
<div class="form-group mb-0">
6060
<div class="form-group">
6161
<label for="comment-{{i}}">Comment before (optional) - <i class="fab fa-markdown"></i> <a
62-
class="markdown-link" href="https://daringfireball.net/projects/markdown/" target="_blank">Markdown is
63-
supported</a></label>
62+
class="markdown-link" href="https://daringfireball.net/projects/markdown/" target="_blank">Markdown
63+
support
64+
</a></label>
6465
<textarea class="form-control"
6566
style="height: 5rem"
6667
id="comment-{{i}}"
@@ -83,8 +84,8 @@
8384
</div>
8485
<div class="form-group">
8586
<label for="commentAfter-{{i}}">Comment after (optional) - <i class="fab fa-markdown"></i> <a
86-
class="markdown-link" href="https://daringfireball.net/projects/markdown/" target="_blank">Markdown is
87-
supported</a></label>
87+
class="markdown-link" href="https://daringfireball.net/projects/markdown/" target="_blank">Markdown
88+
support</a></label>
8889
<textarea class="form-control"
8990
style="height: 5rem"
9091
id="commentAfter-{{i}}"

frontend/src/app/my-snippets/update-snippet-form/update-snippet-form.component.html

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@
5858
<div class="form-group mb-0">
5959
<div class="form-group">
6060
<label for="comment-{{i}}">Comment before (optional)- <i class="fab fa-markdown"></i> <a
61-
class="markdown-link" href="https://daringfireball.net/projects/markdown/" target="_blank">Markdown is
62-
supported</a></label>
61+
class="markdown-link" href="https://daringfireball.net/projects/markdown/" target="_blank">Markdown
62+
support</a></label>
6363
<textarea class="form-control"
6464
style="height: 5rem"
6565
id="comment-{{i}}"
@@ -116,7 +116,7 @@
116116
title="Remove code section"
117117
[disabled]="codeSnippetsFormArray.controls.length < 2"
118118
(click)="removeCodeSnippet(i)">
119-
<i class="far fa-trash-alt"></i> Remove
119+
<i class="far fa-trash-alt"></i> Remove code section
120120
</button>
121121
</div>
122122

@@ -157,8 +157,11 @@
157157
</ng-template>
158158
</button>
159159
</ng-template>
160-
<button type="button" class="btn btn-danger" (click)="openDeleteDialog()">
161-
Delete <i class="far fa-trash-alt"></i>
160+
<button type="button" class="btn btn-secondary" title="Cancel update" (click)="cancelUpdate()">
161+
Cancel <i class="far fa-times-circle"></i>
162+
</button>
163+
<button type="button" class="btn btn-danger float-right" title="Delete snippet" (click)="openDeleteDialog()">
164+
Delete <i class="fas fa-trash-alt"></i>
162165
</button>
163166
</form>
164167
</div>

frontend/src/app/my-snippets/update-snippet-form/update-snippet-form.component.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import { DeleteSnippetDialogComponent } from '../delete-snippet-dialog/delete-sn
1212
import { MatDialog, MatDialogConfig } from '@angular/material/dialog';
1313
import { PublicSnippetsService } from '../../public/snippets/public-snippets.service';
1414
import { SnippetFormBaseComponent } from '../snippet-form-base/snippet-form.base.component';
15+
import { Location } from '@angular/common';
1516

1617
@Component({
1718
selector: 'app-update-snippet-form',
@@ -46,7 +47,8 @@ export class UpdateSnippetFormComponent extends SnippetFormBaseComponent impleme
4647
protected router: Router,
4748
private route: ActivatedRoute,
4849
protected errorService: ErrorService,
49-
private deleteDialog: MatDialog
50+
private deleteDialog: MatDialog,
51+
private _location: Location
5052
) {
5153
super(formBuilder, personalSnippetsService, suggestedTagsStore, userInfoStore, router, errorService);
5254
}
@@ -149,6 +151,10 @@ export class UpdateSnippetFormComponent extends SnippetFormBaseComponent impleme
149151
});
150152
}
151153

154+
cancelUpdate() {
155+
this._location.back();
156+
console.log('goBAck()...');
157+
}
152158
}
153159

154160

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "Codever",
3-
"version": "4.10.2",
3+
"version": "5.1.0",
44
"description": "Codever - bookmarks and snippets manager for developers & co",
55
"scripts": {
66
"test": "echo \"Error: no test specified\" && exit 1",

0 commit comments

Comments
 (0)