Skip to content

date_time_picker not respecting readonly/disabled flags #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
toddhuish opened this issue May 3, 2021 · 2 comments
Open

date_time_picker not respecting readonly/disabled flags #491

toddhuish opened this issue May 3, 2021 · 2 comments

Comments

@toddhuish
Copy link

Connects to PR #490
I found a bug where class-acf-field-date_time_picker.php was missing some functionality that had been added at some time in the past to class-acf-field-date_picker.php which I was also expecting to work in date_time_picker. I've modified the code and created a PR for it.
@elliotcondon
Copy link
Contributor

Thanks @toddhuish. Looks like we completely missed these attributes in the DateTimePicker class. I'll also take a look into the TimePicker class and will be sure to include this fix in the next release :)

@elliotcondon
Copy link
Contributor

Update: I've manually added this missing logic to both the DateTimePicker and the TimePicket fields and will include in the next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toddhuish @elliotcondon