Maintenance – Added order by in search function#130
Open
derpixler wants to merge 3 commits into
Open
Conversation
mgruner
requested changes
Jun 9, 2026
mgruner
left a comment
Contributor
There was a problem hiding this comment.
Can we have some test coverage here, please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Added sort_by and order_by parameters to search()
Based on #43 by @mostafaqanbaryan — thanks for the initial contribution!
References
What it does
Adds sort_by and order_by as optional parameters to Resource\AbstractResource::search(), allowing search results to be sorted server-side via the Zammad REST API:
Changes
search()andsearchWithoutPagination()both accept$sort_byand$order_byas optional parameters (backwards compatible)$order_byvalidated — must be "asc" or "desc",throws \RuntimeExceptionotherwiseTag::search()signature updated for parent class compatibilityThanks
@mostafaqanbaryan for the original PR #43