Request: publish a new version to npm

[zhuxiaojt]

@twlite

Since 0.1.4 was published on Jan 11, a few meaningful changes have landed on main, I think it's a good time to publish.

By the way, I noticed the Linux platform packages (e.g. @webviewjs/webview-linux-x64-gnu) don't exist on npm yet. If the OIDC setup requires the package to exist first, a dummy release or manual first publish might be needed. Just flagging this in case.

Give a brief overview of the changes:

Linux desktop support + CI (#25, #26) — new platform

window menu API — new feature

BrowserWindow.setSize() (#35) — new API

And I noticed there are some unmerged changes here, I think they are really useful:

Add getSize/setPosition/getPosition + logical/physical mode + open_file_dialog() + setMin/MaxSize() (#38, #36, #39) — new API

Are there any blockers for a new npm release? If everything looks good, could you publish 0.1.5 or 0.2.0?

Happy to help if anything needs to be done on my side.

[twlite]

hi @zhuxiaojt, yes I would like to publish the new update. I havent been able to look at this project since I am occupied by other things (see #30). You could add me on Discord if you would like to discuss it further (same @handle as my github)

[zhuxiaojt]

@twlite Thanks for the quick reply!

I don't have a Discord account, so I'd prefer to continue the discussion here on GitHub if that's okay. Also, I'm not always available on GitHub, but I'll keep an eye on this thread.

I noticed that #38 and #39 seems to have been superseded by commit cf8cc47 — the same functions are already in main. I'm planning to close #39, but let me know if you think it should stay open for any reason.

For the next release, it looks like the CI is already set up to publish when a commit message like 0.2.0 is pushed to main. I'm happy to help test the Linux packages before the release if needed.

[twlite]

No worries @zhuxiaojt, please try it on linux and let me know how it goes 🙂

[zhuxiaojt]

@twlite Did you forget to add js-bindings.js to the files?

node:internal/modules/cjs/loader:1244
  const err = new Error(message);
              ^

Error: Cannot find module './js-bindings.js'
Require stack:
- /home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.0/node_modules/@webviewjs/webview/index.js
    at Function._resolveFilename (node:internal/modules/cjs/loader:1244:15)
    at Function._load (node:internal/modules/cjs/loader:1070:27)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
    at Module.require (node:internal/modules/cjs/loader:1335:12)
    at require (node:internal/modules/helpers:136:16)
    at Object.<anonymous> (/home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.0/node_modules/@webviewjs/webview/index.js:1:23)
    at Module._compile (node:internal/modules/cjs/loader:1562:14)
    at Object..js (node:internal/modules/cjs/loader:1699:10)
    at Module.load (node:internal/modules/cjs/loader:1313:32) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.0/node_modules/@webviewjs/webview/index.js'
  ]
}

Node.js v22.13.0

[twlite]

lol sorry for that. Did not notice it earlier

[zhuxiaojt]

@twlite It seems like the .node file didn't get downloaded during the installation. Is this my problem?

I don't see any .node files in the node_modules tree under @webviewjs/webview-linux-x64-gnu, so it looks like pnpm didn't actually download the platform package.

administrator@W11-LENStev:~/webviewjstest$ node ./index.js
/home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/js-bindings.js:573
    const error = new Error(
                  ^

Error: Cannot find native binding. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.
    at Object.<anonymous> (/home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/js-bindings.js:573:19)
    at Module._compile (node:internal/modules/cjs/loader:1562:14)
    at Object..js (node:internal/modules/cjs/loader:1699:10)
    at Module.load (node:internal/modules/cjs/loader:1313:32)
    at Function._load (node:internal/modules/cjs/loader:1123:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    ... 2 lines matching cause stack trace ...
    at require (node:internal/modules/helpers:136:16)
    at Object.<anonymous> (/home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/index.js:1:23) {
  cause: Error: Cannot find module '@webviewjs/webview-linux-x64-gnu'
  Require stack:
  - /home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/js-bindings.js
  - /home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/index.js
      at Function._resolveFilename (node:internal/modules/cjs/loader:1244:15)
      ... 4 lines matching cause stack trace ...
      at require (node:internal/modules/helpers:136:16)
      at requireNative (/home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/js-bindings.js:288:27)
      at Object.<anonymous> (/home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/js-bindings.js:526:17)
      at Module._compile (node:internal/modules/cjs/loader:1562:14)
      at Object..js (node:internal/modules/cjs/loader:1699:10) {
    code: 'MODULE_NOT_FOUND',
    requireStack: [
      '/home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/js-bindings.js',
      '/home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/index.js'
    ],
    cause: Error: Cannot find module './webview.linux-x64-gnu.node'
    Require stack:
    - /home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/js-bindings.js
    - /home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/index.js
        at Function._resolveFilename (node:internal/modules/cjs/loader:1244:15)
        at Function._load (node:internal/modules/cjs/loader:1070:27)
        at TracingChannel.traceSync (node:diagnostics_channel:322:14)
        at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
        at Module.require (node:internal/modules/cjs/loader:1335:12)
        at require (node:internal/modules/helpers:136:16)
        at requireNative (/home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/js-bindings.js:283:18)
        at Object.<anonymous> (/home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/js-bindings.js:526:17)
        at Module._compile (node:internal/modules/cjs/loader:1562:14)
        at Object..js (node:internal/modules/cjs/loader:1699:10) {
      code: 'MODULE_NOT_FOUND',
      requireStack: [
        '/home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/js-bindings.js',
        '/home/administrator/webviewjstest/node_modules/.pnpm/@webviewjs+webview@0.2.1/node_modules/@webviewjs/webview/index.js'
      ]
    }
  }
}

Node.js v22.13.0
administrator@W11-LENStev:~/webviewjstest$ pnpm -v
11.1.2

[zhuxiaojt]

@twlite Also, I noticed that undecorated windows on Windows can't be resized anymore. Could this be because tao was replaced with winit?

[twlite]

@twlite It seems like the .node file didn't get downloaded during the installation. Is this my problem?

I don't see any .node files in the node_modules tree under @webviewjs/webview-linux-x64-gnu, so it looks like pnpm didn't actually download the platform package.

something to do with pnpm i think. npm does have a .node file

[twlite]

@twlite Also, I noticed that undecorated windows on Windows can't be resized anymore. Could this be because tao was replaced with winit?

could be.... ☹️

[zhuxiaojt]

@twlite Also, I noticed that undecorated windows on Windows can't be resized anymore. Could this be because tao was replaced with winit?

could be.... ☹️

@twlite Just out of curiosity, what was the reason for switching from tao to winit? From my perspective, tao seems to work better — especially for things like undecorated window resizing on Windows. Was there a specific issue or goal behind the change?

[zhuxiaojt]

@twlite It seems like the .node file didn't get downloaded during the installation. Is this my problem?
I don't see any .node files in the node_modules tree under @webviewjs/webview-linux-x64-gnu, so it looks like pnpm didn't actually download the platform package.

something to do with pnpm i think. npm does have a .node file

NPM can also have this error.

administrator@W11-LENStev:~/webviewjstest$ rm -R ./node_modules
administrator@W11-LENStev:~/webviewjstest$ npm install
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@webviewjs/webview@0.2.1',
npm warn EBADENGINE   required: { node: '>= 24' },
npm warn EBADENGINE   current: { node: 'v22.13.0', npm: '10.9.2' }
npm warn EBADENGINE }

added 1 package in 25s
administrator@W11-LENStev:~/webviewjstest$ node ./index.js
/home/administrator/webviewjstest/node_modules/@webviewjs/webview/js-bindings.js:573
    const error = new Error(
                  ^

Error: Cannot find native binding. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.
    at Object.<anonymous> (/home/administrator/webviewjstest/node_modules/@webviewjs/webview/js-bindings.js:573:19)
    at Module._compile (node:internal/modules/cjs/loader:1562:14)
    at Object..js (node:internal/modules/cjs/loader:1699:10)
    at Module.load (node:internal/modules/cjs/loader:1313:32)
    at Function._load (node:internal/modules/cjs/loader:1123:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    ... 2 lines matching cause stack trace ...
    at require (node:internal/modules/helpers:136:16)
    at Object.<anonymous> (/home/administrator/webviewjstest/node_modules/@webviewjs/webview/index.js:1:23) {
  cause: Error: Cannot find module '@webviewjs/webview-linux-x64-gnu'
  Require stack:
  - /home/administrator/webviewjstest/node_modules/@webviewjs/webview/js-bindings.js
  - /home/administrator/webviewjstest/node_modules/@webviewjs/webview/index.js
      at Function._resolveFilename (node:internal/modules/cjs/loader:1244:15)
      ... 4 lines matching cause stack trace ...
      at require (node:internal/modules/helpers:136:16)
      at requireNative (/home/administrator/webviewjstest/node_modules/@webviewjs/webview/js-bindings.js:288:27)
      at Object.<anonymous> (/home/administrator/webviewjstest/node_modules/@webviewjs/webview/js-bindings.js:526:17)
      at Module._compile (node:internal/modules/cjs/loader:1562:14)
      at Object..js (node:internal/modules/cjs/loader:1699:10) {
    code: 'MODULE_NOT_FOUND',
    requireStack: [
      '/home/administrator/webviewjstest/node_modules/@webviewjs/webview/js-bindings.js',
      '/home/administrator/webviewjstest/node_modules/@webviewjs/webview/index.js'
    ],
    cause: Error: Cannot find module './webview.linux-x64-gnu.node'
    Require stack:
    - /home/administrator/webviewjstest/node_modules/@webviewjs/webview/js-bindings.js
    - /home/administrator/webviewjstest/node_modules/@webviewjs/webview/index.js
        at Function._resolveFilename (node:internal/modules/cjs/loader:1244:15)
        at Function._load (node:internal/modules/cjs/loader:1070:27)
        at TracingChannel.traceSync (node:diagnostics_channel:322:14)
        at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
        at Module.require (node:internal/modules/cjs/loader:1335:12)
        at require (node:internal/modules/helpers:136:16)
        at requireNative (/home/administrator/webviewjstest/node_modules/@webviewjs/webview/js-bindings.js:283:18)
        at Object.<anonymous> (/home/administrator/webviewjstest/node_modules/@webviewjs/webview/js-bindings.js:526:17)
        at Module._compile (node:internal/modules/cjs/loader:1562:14)
        at Object..js (node:internal/modules/cjs/loader:1699:10) {
      code: 'MODULE_NOT_FOUND',
      requireStack: [
        '/home/administrator/webviewjstest/node_modules/@webviewjs/webview/js-bindings.js',
        '/home/administrator/webviewjstest/node_modules/@webviewjs/webview/index.js'
      ]
    }
  }
}

Node.js v22.13.0

[twlite]

@twlite Also, I noticed that undecorated windows on Windows can't be resized anymore. Could this be because tao was replaced with winit?

could be.... ☹️

@twlite Just out of curiosity, what was the reason for switching from tao to winit? From my perspective, tao seems to work better — especially for things like undecorated window resizing on Windows. Was there a specific issue or goal behind the change?

Old version of this lib blocked the main thread after app.run() which made it very hard to work with async i/o which is a natural feature of nodejs. winit seems to be more flexible in terms of it's event loop. I wanted this lib to be non-blocking and the feature was easy to implement with winit. I also did some research on tao about this and it seemed like tao did not support this feature properly. Running the application on a worker is an option but this doesn't guarantee cross platform compatibility because macos requires GUI to run on the main thread.

About binding issue, i see this

npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@webviewjs/webview@0.2.1',
npm warn EBADENGINE   required: { node: '>= 24' },
npm warn EBADENGINE   current: { node: 'v22.13.0', npm: '10.9.2' }
npm warn EBADENGINE }

Could you try upgrading to node 24 or ignore engines check?