Skip to content

Flip BINARY_VERSION URLs to unified after mirror consolidation #738

@waltsims

Description

@waltsims

Goal

Once the 5 mirror binary repos are consolidated into waltsims/kspacefirstorder-unified (tracked at waltsims/kspacefirstorder-unified#13), flatten URL_DICT in kwave/__init__.py to point at unified release URLs instead of 5 separate mirror URLs.

Today

# 5 separate per-platform mirror URLs:
URL_BASE + "kspaceFirstOrder-CUDA-linux/releases/download/{VERSION}/..."
URL_BASE + "kspaceFirstOrder-CUDA-windows/releases/download/{VERSION}/..."
URL_BASE + "kspaceFirstOrder-OMP-linux/releases/download/{VERSION}/..."
URL_BASE + "kspaceFirstOrder-OMP-windows/releases/download/{VERSION}/..."
URL_BASE + "k-wave-omp-darwin/releases/download/{VERSION}/..."

Goal

# Single unified release with platform-named assets:
URL_BASE + "kspacefirstorder-unified/releases/download/{VERSION}/kspaceFirstOrder-CUDA-linux"
# etc.

Why

  • One URL pin to maintain per release (not 5)
  • Provenance: one release tag → one set of binaries, all built from the same SHA
  • Drops get_windows_release_urls() indirection
  • Eliminates the per-platform version drift that v0.6.2 already had to clean up (CUDA-linux at v1.3.1, others at v1.3.0, darwin at v0.3.0rc3)

Blocked by

waltsims/kspacefirstorder-unified#13 — until unified actually hosts releases with the per-platform assets, k-wave-python has nowhere to point.

Timing

Slot for k-wave-python v0.6.3 or whatever release follows the upstream consolidation. Captured in plans/release-strategy.md.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions