Skip to content

How should timestamps be handled for audio discarded during decoding? #944

Description

@dalecurtis

While trying to fix the negative timestamp test failures in Chromium:

I've run into a question about how things like Opus pre-skip should be handled. The opus test file in this case has a pre-skip of 312 samples (6500us), which Chromium's decoding system happily discards. To ensure timestamps are accurate we adjust the -42 forward (to 6548us).

As I see it, we have a couple choices:

  • AudioDecoder shouldn't discard anything.
  • AudioDecoder shouldn't adjust timestamps for discarded audio (not sure how this works when full packets can end up discarded).
  • Agree that timestamps should be adjusted for discarded audio.
  • Do nothing and switch to a Opus test file with zero pre-skip

@padenot @youennf @tguilbert-google WDYT?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions