While trying to fix the negative timestamp test failures in Chromium:
I've run into a question about how things like Opus pre-skip should be handled. The opus test file in this case has a pre-skip of 312 samples (6500us), which Chromium's decoding system happily discards. To ensure timestamps are accurate we adjust the -42 forward (to 6548us).
As I see it, we have a couple choices:
- AudioDecoder shouldn't discard anything.
- AudioDecoder shouldn't adjust timestamps for discarded audio (not sure how this works when full packets can end up discarded).
- Agree that timestamps should be adjusted for discarded audio.
- Do nothing and switch to a Opus test file with zero pre-skip
@padenot @youennf @tguilbert-google WDYT?
While trying to fix the negative timestamp test failures in Chromium:
I've run into a question about how things like Opus pre-skip should be handled. The opus test file in this case has a pre-skip of 312 samples (6500us), which Chromium's decoding system happily discards. To ensure timestamps are accurate we adjust the -42 forward (to 6548us).
As I see it, we have a couple choices:
@padenot @youennf @tguilbert-google WDYT?