From 2d36e88946981b2bc87ec6cc775d0e74df560b33 Mon Sep 17 00:00:00 2001 From: Vyncint Ng Date: Sun, 2 Aug 2026 20:28:17 +0700 Subject: [PATCH] fix: don't abort install.sh when the OpenShell gateway health-check fails MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit install.sh installs OpenShell before it installs this driver and runs `setup`. The OpenShell installer starts and health-checks its gateway, which cannot become reachable until `setup` wires in the compute driver afterwards — so it exits non-zero ("local gateway listener did not become reachable within 30s"). Under `set -eu` that aborted the whole script, leaving OpenShell and apple/container installed but the driver never set up: the gateway then crash-loops with "no compute driver configured". Tolerate the expected non-zero exit from the OpenShell installer and assert the `openshell` binary actually landed instead, then continue on to install the driver and run `setup`, which brings the gateway up. Signed-off-by: Vyncint Ng --- CHANGELOG.md | 9 +++++++++ install.sh | 7 ++++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b44d8c0..75c1cf0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,15 @@ All notable changes to this project are documented here. The format follows ## [Unreleased] +### Fixed + +- The `install.sh` one-line installer no longer aborts when the OpenShell installer it invokes + reports its gateway as unreachable. That health check cannot pass until the driver's `setup` + runs afterwards, so its non-zero exit is expected; the installer now tolerates it (after + confirming the `openshell` binary was installed) and continues on to install the driver and + run `setup`, which brings the gateway up. Without this, a fresh `curl … | sh` left OpenShell + and apple/container installed but the driver never set up. + ## [0.2.3] - 2026-08-02 ### Fixed diff --git a/install.sh b/install.sh index e96b72a..97549d5 100755 --- a/install.sh +++ b/install.sh @@ -137,7 +137,12 @@ check_openshell() { fi info "OpenShell is not installed (https://github.com/NVIDIA/OpenShell)" if confirm "Install OpenShell now (runs the official installer)?"; then - curl -LsSf "$OPENSHELL_INSTALL_URL" | sh + # The official installer starts and health-checks the gateway, which + # cannot pass until this driver's `setup` runs afterwards — so a + # non-zero exit here is expected. Tolerate it and verify the binary + # landed instead; `setup` (run later) brings the gateway up. + curl -LsSf "$OPENSHELL_INSTALL_URL" | sh || true + need openshell || err "OpenShell installation failed" else err "OpenShell is required" fi