diff --git a/.github/scripts/run-sql-bench.sh b/.github/scripts/run-sql-bench.sh index 96c2e2f19dc..bdbcae3f7a0 100755 --- a/.github/scripts/run-sql-bench.sh +++ b/.github/scripts/run-sql-bench.sh @@ -22,6 +22,9 @@ set -Eeu -o pipefail +export VORTEX_EXPERIMENTAL_PATCHED_ARRAY=1 +export FLAT_LAYOUT_INLINE_ARRAY_NODE=1 + subcommand="$1" targets="$2" shift 2 diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml index f392f1a6e45..d3de66765dc 100644 --- a/.github/workflows/bench-pr.yml +++ b/.github/workflows/bench-pr.yml @@ -60,7 +60,7 @@ jobs: env: RUSTFLAGS: "-C target-cpu=native" run: | - cargo build --package ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} + cargo build --package ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} --features unstable_encodings - name: Setup Polar Signals if: github.event.pull_request.head.repo.fork == false @@ -76,6 +76,8 @@ jobs: shell: bash env: RUST_BACKTRACE: full + VORTEX_EXPERIMENTAL_PATCHED_ARRAY: "1" + FLAT_LAYOUT_INLINE_ARRAY_NODE: "1" run: | bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o results.json diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index 558a5bd51ff..abc80c1d93e 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -74,7 +74,7 @@ jobs: env: RUSTFLAGS: "-C target-cpu=native" run: | - cargo build --bin ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} + cargo build --bin ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} --features unstable_encodings - name: Setup Polar Signals uses: polarsignals/gh-actions-ps-profiling@v0.8.1 @@ -89,6 +89,8 @@ jobs: shell: bash env: RUST_BACKTRACE: full + VORTEX_EXPERIMENTAL_PATCHED_ARRAY: "1" + FLAT_LAYOUT_INLINE_ARRAY_NODE: "1" run: | bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.id }} --formats ${{ matrix.benchmark.formats }} -d gh-json -o results.json diff --git a/.github/workflows/sql-benchmarks.yml b/.github/workflows/sql-benchmarks.yml index 4c114f00bda..c12a5fe7bea 100644 --- a/.github/workflows/sql-benchmarks.yml +++ b/.github/workflows/sql-benchmarks.yml @@ -144,7 +144,7 @@ jobs: if [ "${{ matrix.build_lance }}" = "true" ]; then packages="$packages --bin lance-bench" fi - cargo build $packages --profile release_debug + cargo build $packages --profile release_debug --features unstable_encodings - name: Generate data shell: bash diff --git a/benchmarks/compress-bench/Cargo.toml b/benchmarks/compress-bench/Cargo.toml index 4c72a20f712..baff1daad74 100644 --- a/benchmarks/compress-bench/Cargo.toml +++ b/benchmarks/compress-bench/Cargo.toml @@ -34,6 +34,7 @@ vortex-bench = { workspace = true } [features] lance = ["dep:lance-bench"] +unstable_encodings = ["vortex/unstable_encodings"] [lints] workspace = true diff --git a/benchmarks/datafusion-bench/Cargo.toml b/benchmarks/datafusion-bench/Cargo.toml index eea6e70e8aa..d0015dd2995 100644 --- a/benchmarks/datafusion-bench/Cargo.toml +++ b/benchmarks/datafusion-bench/Cargo.toml @@ -46,6 +46,7 @@ custom-labels = { workspace = true } [features] cuda = ["dep:vortex-cuda"] +unstable_encodings = ["vortex/unstable_encodings"] [lints] workspace = true diff --git a/benchmarks/duckdb-bench/Cargo.toml b/benchmarks/duckdb-bench/Cargo.toml index ad9ece90fc3..b70375cf963 100644 --- a/benchmarks/duckdb-bench/Cargo.toml +++ b/benchmarks/duckdb-bench/Cargo.toml @@ -27,6 +27,7 @@ vortex-duckdb = { workspace = true } [features] cuda = ["dep:vortex-cuda"] +unstable_encodings = ["vortex/unstable_encodings"] [lints] workspace = true diff --git a/benchmarks/lance-bench/Cargo.toml b/benchmarks/lance-bench/Cargo.toml index acfe39ef531..e5c6044e4f5 100644 --- a/benchmarks/lance-bench/Cargo.toml +++ b/benchmarks/lance-bench/Cargo.toml @@ -29,5 +29,8 @@ tokio = { workspace = true, features = ["full"] } tracing = { workspace = true } vortex-bench = { workspace = true } +[features] +unstable_encodings = ["vortex-bench/unstable_encodings"] + [lints] workspace = true diff --git a/benchmarks/random-access-bench/Cargo.toml b/benchmarks/random-access-bench/Cargo.toml index c22736b65d4..cde8fb6f81a 100644 --- a/benchmarks/random-access-bench/Cargo.toml +++ b/benchmarks/random-access-bench/Cargo.toml @@ -26,6 +26,7 @@ vortex-bench = { workspace = true } [features] lance = ["dep:lance-bench"] +unstable_encodings = ["vortex-bench/unstable_encodings"] [lints] workspace = true diff --git a/vortex-bench/Cargo.toml b/vortex-bench/Cargo.toml index 62d302f12e1..8b2bb6efe25 100644 --- a/vortex-bench/Cargo.toml +++ b/vortex-bench/Cargo.toml @@ -63,3 +63,6 @@ vortex = { workspace = true, features = [ "tokio", "zstd", ] } + +[features] +unstable_encodings = ["vortex/unstable_encodings"]