docs-ci: build the site - #124
Merged
Merged
Conversation
Every check in this workflow reads content and compares it against something. None of them ran Next. That is how a docs site that could not be built sat on main behind a green tick — twice: a floating base-image tag that took the Docker build with it, and a duplicated @base-ui/react that left a React context unresolvable at prerender. Neither was visible to a single gate in this file. A separate job, so it runs alongside the content checks and a failure says which half broke. It installs with --frozen-lockfile, because the committed lockfile is what deploys and a build that only passes after resolution drifts is not a pass. It runs Next through Node directly, the same command web-docs/Dockerfile runs, with the same NEXT_PUBLIC_URL — gating the path that ships rather than a convenient approximation. Pinned in fchub-ci-contract so the gate cannot quietly disappear later. Mutation-checked: replace the build step with an echo and the contract fails.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every check in Docs CI reads content and compares it against something. None of them ran Next.
That is how a docs site that could not be built sat on
mainbehind a green tick — twice tonight. A floatingoven/bun:1tag that took the Docker build with it, and a duplicated@base-ui/reactthat left a React context unresolvable at prerender. Neither was visible to a single gate in this workflow.What it does
A separate
buildjob, so it runs alongside the content checks and a failure tells you which half broke.bun install --frozen-lockfile— the committed lockfile is what deploys. A build that only passes once resolution drifts is not a pass, and that drift is precisely what hid the base-ui duplication.node ./node_modules/next/dist/bin/next build— the same commandweb-docs/Dockerfileruns, with the sameNEXT_PUBLIC_URL. Gating the path that ships rather than a convenient local approximation. Bun installs; Node builds.No exact page count is asserted. The build failing is the signal; pinning 223 would just break every time a page is added.
Pinned so it cannot quietly go away
fchub-ci-contract.test.mjsnow asserts the job runs both commands. Mutation-checked rather than assumed: replacing the build step with anechofails the contract.Had this existed this morning, both of tonight's breakages would have failed on the commit that introduced them instead of being found by hand.