test(webapp): chat.agent durability regression suite by kathiekiwi · Pull Request #4550 · triggerdotdev/trigger.dev

kathiekiwi · 2026-08-10T10:38:55Z

What & why

Test-only hardening for chat.agent durability. chat.agent gets its durability from the primitive — object-store snapshot + S2 .in/.out replay + continuation boot — but several store-level mechanisms that replay lands on had no regression test, and two of them were criticals in the 2026-06-10 chat.agent audit: cross-tenant isolation and no duplicate mid-stream turn. This adds those cases against a real Postgres table (testcontainers, no mocks). TRI-11166.

Stack

Stacked on #4549 (query boundary). Merge that first.

What's inside

#	Mechanism	Test	Coverage	Control-broken
1	Cross-tenant isolation (audit critical)	`dashboardAgentTenantIsolation.test.ts`	Full at the store seam we own: getChatMessages / getSession / chatExists / listChats / countUserMessages / appendChatMessageOnce all refuse a foreign (org, user) — a foreign tenant reads not-found, never a transcript or the session's public access token	Yes
2	No duplicate mid-stream turn (audit critical)	`dashboardAgentDurableResume.test.ts`	Full: a streamed-then-resumed turn finalises in place and appends nothing; row count and the position allocator both pinned	Yes
3	Crash-resume reconstructs state	`dashboardAgentDurableResume.test.ts`	Full: replay keeps the mid-turn append, finalises the turn's own message, loses no messages, and rebuilds the session cursor read back via getSession	—
4	Mid-stream refresh resumes in-flight turn (Last-Event-ID)	`dashboardAgentDurableResume.test.ts`	Seam-only: the cursor getSession hands a refreshed client, and a later turn advances (never appends) it. Client-side reconnect / Last-Event-ID replay is already covered in `packages/trigger-sdk/src/v3/chat.test.ts` — not duplicated	—
5	Snapshot write-failure path	`dashboardAgentDurableResume.test.ts`	Full at this seam: a persistTurn that throws commits nothing (no rows, allocator untouched, cursor unchanged — the version-mismatch case), and the retry replays with no loss	—
6	`.out` trimming / OOM retry restarts cleanly	`dashboardAgentDurableResume.test.ts`	Seam-only: a restarted turn that re-sends its snapshot loses no data and doubles nothing. `.out` trimming and the OOM restart itself are inside the closed primitive (not reachable)	—

The "Full" vs "Seam-only" column is the honest distinction: full means the whole mechanism is exercised from the repos we own; seam-only means we pin the store contract the primitive depends on, and the primitive-internal half lives where we can't reach it.

Key decisions

The two criticals were control-broken first. Isolation: removing the organizationId filter from getChatMessages leaks org A's transcript to the owner's user id under another org — the test fails at toBeNull(). No-duplicate: removing the stored-id drop in storeChatMessages makes a replayed persistTurn over-reserve positions (next free slot jumps 3 → 7) — the test fails on the allocator assertion. Both reverted.
Real Postgres, no mocks. testcontainers against an actual table, so the store contract is proven, not asserted against a stub.

Residual follow-ups

These live inside the closed chat.agent primitive package and can't be unit-tested from the repos we own; the tests above are the store-level backstop they depend on:

The snapshot URL's own auth gate (the audit's snapshot-URL auth gap) — enforced in the primitive; here we prove the webapp store never hands a foreign tenant the PAT it would boot from.
Object-store snapshot write + S2 .in/.out replay at the transport level.
.out trimming never dropping in-flight data, and the OOM restart mechanism itself.

Testing

pnpm run test --filter webapp — dashboardAgentTenantIsolation.test.ts and dashboardAgentDurableResume.test.ts.

A chat/session belongs to one (org, user) pair. Pin that every store read — getChatMessages, getSession, chatExists, listChats, countUserMessages — and appendChatMessageOnce refuse a foreign tenant, so a chatId from another org reads as not-found and never leaks a transcript or the session's public access token. TRI-11166.

The primitive resumes a turn by replaying its snapshot; pin the store seam that replay lands on: a streamed-then-resumed turn is not double-appended, a crash mid-turn keeps the mid-turn append and rebuilds the session cursor, a failed write commits nothing and the retry replays with no loss, and an OOM restart replays idempotently. TRI-11166.

changeset-bot · 2026-08-10T10:39:00Z

⚠️ No Changeset found

Latest commit: 074da82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-08-10T10:39:07Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fa7bdf82-e900-48fb-a6ae-1f42d4c0f3ce

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…o test/chat-agent-durability-tri-11166

pkg-pr-new · 2026-08-10T11:09:35Z

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@f06235c

trigger.dev

npm i https://pkg.pr.new/trigger.dev@f06235c

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@f06235c

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@f06235c

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@f06235c

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@f06235c

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@f06235c

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@f06235c

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@f06235c

commit: f06235c

…o test/chat-agent-durability-tri-11166

devin-ai-integration

Devin Review found 1 potential issue.

kathiekiwi added 2 commits August 10, 2026 10:37

Merge remote-tracking branch 'origin/feat/query-safety-tri-11165' int…

c42002b

…o test/chat-agent-durability-tri-11166

Merge remote-tracking branch 'origin/feat/query-safety-tri-11165' int…

b9610f8

…o test/chat-agent-durability-tri-11166

devin-ai-integration Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread apps/webapp/test/dashboardAgentDurableResume.test.ts

merge: propagate review fixes from feat/query-safety-tri-11165

b1463c2

This comment was marked as resolved.

Sign in to view

kathiekiwi added 4 commits August 10, 2026 15:43

merge: propagate wave-2 review fixes from feat/query-safety-tri-11165

6db1133

merge: propagate org-purge best-effort from feat/query-safety-tri-11165

d7321e5

merge: propagate review-comment fixes from feat/query-safety-tri-11165

f06235c

merge: propagate second-pass fixes from feat/query-safety-tri-11165

074da82

samejr approved these changes Aug 11, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

test(webapp): chat.agent durability regression suite - #4550

test(webapp): chat.agent durability regression suite#4550
kathiekiwi wants to merge 9 commits into
feat/query-safety-tri-11165from
test/chat-agent-durability-tri-11166

kathiekiwi commented Aug 10, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Aug 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading

Review skipped

Uh oh!

pkg-pr-new Bot commented Aug 10, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

kathiekiwi commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What & why

Stack

What's inside

Key decisions

Residual follow-ups

Testing

Uh oh!

changeset-bot Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

pkg-pr-new Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kathiekiwi commented Aug 10, 2026 •

edited

Loading

changeset-bot Bot commented Aug 10, 2026 •

edited

Loading

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading

pkg-pr-new Bot commented Aug 10, 2026 •

edited

Loading