feat(webapp): billing limits — pause, reject, recovery, and settings UI#3996
Open
kathiekiwi wants to merge 7 commits into
Open
feat(webapp): billing limits — pause, reject, recovery, and settings UI#3996kathiekiwi wants to merge 7 commits into
kathiekiwi wants to merge 7 commits into
Conversation
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (41)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (39)
📜 Recent review details⏰ Context from checks skipped due to timeout. (25)
WalkthroughThis PR implements a billing limits feature that lets organizations configure a monthly compute spend cap. When the cap is reached, a billing platform webhook triggers a grace period during which billable environments are paused; new task triggers are rejected once the grace period ends. A recovery flow lets users increase or remove the limit and choose to resume queued runs or accept cancellation. A Redis-backed worker periodically reconciles environment pause state against billing platform data. The feature adds a new 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Add the EnvironmentPauseSource enum and migration, plus the billing-limit platform client wrappers and schemas.
Configure a spend limit, manage billing alerts, and surface org-wide banners.
Converge billable environments to paused via webhook and a reconciliation worker; block manual resume.
Reject triggers with a 422 once entitlement reports no access, and bust the entitlement cache on state changes.
Recovery UI and durable resolve: cancel queued runs before unpausing, with reconciliation as a safety net.
Optionally cancel in-progress runs on limit hit via a deduplicated bulk-cancel job.
kathiekiwi
force-pushed
the
feature/billing-limits
branch
from
5c1a4bf to
ac87dcd
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
force-pushed
the
feature/billing-limits
branch
from
ac87dcd to
80b0a02
Compare
kathiekiwi
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
force-pushed
the
feature/billing-limits
branch
from
80b0a02 to
18bce2f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
force-pushed
the
feature/billing-limits
branch
from
18bce2f to
c338591
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
force-pushed
the
feature/billing-limits
branch
from
c338591 to
31b6df9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
force-pushed
the
feature/billing-limits
branch
from
31b6df9 to
3200c8a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
force-pushed
the
feature/billing-limits
branch
from
3200c8a to
7763a7a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
force-pushed
the
feature/billing-limits
branch
from
7763a7a to
6d9aa23
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
force-pushed
the
feature/billing-limits
branch
from
6d9aa23 to
cc28bfd
Compare
… tests Add the usage-bar marker, documentation, and test coverage.
kathiekiwi
force-pushed
the
feature/billing-limits
branch
from
cc28bfd to
2a89262
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Billing Limits to the webapp.
Customers can set a monthly spend cap. When usage crosses the limit, billable environments enter a grace period. If the limit is not resolved before grace expires, new triggers are rejected until the organization increases or removes the limit.
The webapp consumes billing-limit state from the billing platform and enforces it across environments, queues, and trigger creation.
Depends on the matching cloud billing PR.
User-facing changes
Billing Limits settings
New
/settings/billing-limitspage replaces the standalone billing-alerts page.Configure:
Configure billing alerts and notification emails.
Resolve active billing limits by increasing or removing the limit.
Org-wide banners
Adds banners for:
Usage page
Shows the configured billing limit on the spend chart.
Enforcement
Billable environments are paused when an org enters grace.
New triggers are rejected once grace expires.
Billing-limit pauses cannot be manually resumed.
New environments created during grace/rejected inherit the correct paused state.
Recovery supports:
Infrastructure
BILLING_LIMITas an environment pause source.Test plan
queueandnew_only).Notes
isConfigured: falsemeans no billing limit has been configured yet.mode: "none"means the customer explicitly opted out.