Skip to content

Billing limits#3996

Draft
kathiekiwi wants to merge 8 commits into
mainfrom
feature/billing-limits
Draft

Billing limits#3996
kathiekiwi wants to merge 8 commits into
mainfrom
feature/billing-limits

Conversation

@kathiekiwi

Copy link
Copy Markdown
Collaborator

Closes #

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

[Describe the steps you took to test this change]


Changelog

[Short description of what has changed]


Screenshots

[Screenshots]

💯

@changeset-bot

changeset-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 80b0a02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 296b6d61-c190-4184-ae78-587fb47eab47

📥 Commits

Reviewing files that changed from the base of the PR and between ac87dcd and 80b0a02.

📒 Files selected for processing (24)
  • apps/webapp/app/components/billing/BillingAlertsSection.tsx
  • apps/webapp/app/components/billing/OrgBanner.tsx
  • apps/webapp/app/components/billing/billingAlertsFormat.ts
  • apps/webapp/app/components/billing/selectOrgBanner.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/route.tsx
  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.hit.ts
  • apps/webapp/app/runEngine/validators/validateProductionEntitlement.server.ts
  • apps/webapp/app/services/billingLimit.schemas.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/BillingLimitBulkCancelService.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolveCoordinator.server.ts
  • apps/webapp/app/v3/services/billingLimit/getInitialEnvPauseStateForBillingLimit.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
  • apps/webapp/app/v3/services/pauseEnvironment.server.ts
  • apps/webapp/test/billingAlertsFormat.test.ts
  • apps/webapp/test/billingLimitBulkCancelInProgress.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/test/billingLimitConvergeResolve.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitsRoute.test.ts
  • apps/webapp/test/orgBanner.test.ts
✅ Files skipped from review due to trivial changes (1)
  • apps/webapp/test/billingLimitConvergeResolve.test.ts
🚧 Files skipped from review as they are similar to previous changes (17)
  • apps/webapp/app/runEngine/validators/validateProductionEntitlement.server.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.hit.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolveCoordinator.server.ts
  • apps/webapp/app/components/billing/selectOrgBanner.ts
  • apps/webapp/test/billingLimitBulkCancelInProgress.test.ts
  • apps/webapp/app/components/billing/OrgBanner.tsx
  • apps/webapp/app/v3/services/pauseEnvironment.server.ts
  • apps/webapp/test/billingAlertsFormat.test.ts
  • apps/webapp/test/billingLimitsRoute.test.ts
  • apps/webapp/app/v3/services/billingLimit/getInitialEnvPauseStateForBillingLimit.server.ts
  • apps/webapp/app/v3/services/billingLimit/BillingLimitBulkCancelService.server.ts
  • apps/webapp/app/components/billing/BillingAlertsSection.tsx
  • apps/webapp/app/services/billingLimit.schemas.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/route.tsx
  • apps/webapp/app/components/billing/billingAlertsFormat.ts
📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
🧰 Additional context used
📓 Path-based instructions (11)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead

Import from @trigger.dev/sdk when writing Trigger.dev tasks. Never use @trigger.dev/sdk/v3 or deprecated client.defineJob

Files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use zod for validation in packages/core and apps/webapp

Files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use function declarations instead of default exports

**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamic imports. Only use dynamic import() when circular dependencies cannot be resolved, code splitting is needed for performance, or the module must be loaded conditionally at runtime
Import subpaths only from packages/core (@trigger.dev/core), never import from the root

Files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
**/*.{test,spec}.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use vitest for all tests in the Trigger.dev repository

Files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)

**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries

Files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
apps/webapp/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

apps/webapp/**/*.{ts,tsx}: Access environment variables through the env export of env.server.ts instead of directly accessing process.env
Use subpath exports from @trigger.dev/core package instead of importing from the root @trigger.dev/core path

Use named constants for sentinel/placeholder values (e.g. const UNSET_VALUE = '__unset__') instead of raw string literals scattered across comparisons

Files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
apps/webapp/**/*.test.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

Do not import env.server.ts directly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable

For testable code, never import env.server.ts in test files. Pass configuration as options instead (e.g., realtimeClient.server.ts takes config as constructor arg, realtimeClientGlobal.server.ts creates singleton with env config)

Files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
**/*.test.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.test.{ts,tsx}: Never mock anything in tests - use testcontainers instead
Test files should be placed next to source files (e.g., MyService.ts -> MyService.test.ts)

Files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
**/*.{js,ts,tsx,jsx,css,json,md}

📄 CodeRabbit inference engine (AGENTS.md)

Use Prettier for code formatting and run pnpm run format before committing

Files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
**/*.test.{js,ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.test.{js,ts,tsx}: Test files should live beside the files under test and use descriptive describe and it blocks
Use vitest for unit testing
Tests should avoid mocks or stubs and use helpers from @internal/testcontainers when Redis or Postgres are needed

Files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
apps/webapp/**/*.server.ts

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

apps/webapp/**/*.server.ts: Never use request.signal for detecting client disconnects. Use getRequestAbortSignal() from app/services/httpAsyncStorage.server.ts instead, which is wired directly to Express res.on('close') and fires reliably
Access environment variables via env export from app/env.server.ts. Never use process.env directly
Always use findFirst instead of findUnique in Prisma queries. findUnique has an implicit DataLoader that batches concurrent calls and has active bugs even in Prisma 6.x (uppercase UUIDs returning null, composite key SQL correctness issues, 5-10x worse performance). findFirst is never batched and avoids this entire class of issues

Files:

  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
🧠 Learnings (19)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).

Applied to files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.

Applied to files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.

Applied to files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.

Applied to files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.

Applied to files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).

Applied to files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
📚 Learning: 2026-05-07T12:25:18.271Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.

Applied to files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-05-28T20:02:10.647Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.

Applied to files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.

Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.

Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.

Applied to files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.

Applied to files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.

Applied to files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.

Applied to files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.

Applied to files:

  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-03-26T09:02:07.973Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3274
File: apps/webapp/app/services/runsReplicationService.server.ts:922-924
Timestamp: 2026-03-26T09:02:07.973Z
Learning: When parsing Trigger.dev task run annotations in server-side services, keep `TaskRun.annotations` strictly conforming to the `RunAnnotations` schema from `trigger.dev/core/v3`. If the code already uses `RunAnnotations.safeParse` (e.g., in a `#parseAnnotations` helper), treat that as intentional/necessary for atomic, schema-accurate annotation handling. Do not recommend relaxing the annotation payload schema or using a permissive “passthrough” parse path, since the annotations are expected to be written atomically in one operation and should not contain partial/legacy payloads that would require a looser parser.

Applied to files:

  • apps/webapp/app/services/upsertBranch.server.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.

Applied to files:

  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
📚 Learning: 2026-03-10T17:56:20.938Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3201
File: apps/webapp/app/v3/services/setSeatsAddOn.server.ts:25-29
Timestamp: 2026-03-10T17:56:20.938Z
Learning: Do not implement local userId-to-organizationId authorization checks inside org-scoped service classes (e.g., SetSeatsAddOnService, SetBranchesAddOnService) in the web app. Rely on route-layer authentication (requireUserId(request)) and org membership enforcement via the _app.orgs.$organizationSlug layout route. Any userId/organizationId that reaches these services from org-scoped routes has already been validated. Apply this pattern across all org-scoped services to avoid redundant auth checks and maintain consistency.

Applied to files:

  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
📚 Learning: 2026-03-29T19:16:28.864Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3291
File: apps/webapp/app/v3/featureFlags.ts:53-65
Timestamp: 2026-03-29T19:16:28.864Z
Learning: When reviewing TypeScript code that uses Zod v3, treat `z.coerce.*()` schemas as their direct Zod type (e.g., `z.coerce.boolean()` returns a `ZodBoolean` with `_def.typeName === "ZodBoolean"`) rather than a `ZodEffects`. Only `.preprocess()`, `.refine()`/`.superRefine()`, and `.transform()` are expected to wrap schemas in `ZodEffects`. Therefore, in reviewers’ logic like `getFlagControlType`, do not flag/unblock failures that require unwrapping `ZodEffects` when the input schema is a `z.coerce.*` schema.

Applied to files:

  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
📚 Learning: 2026-06-09T16:27:26.195Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3878
File: apps/webapp/app/v3/services/computeTemplateCreation.server.ts:0-0
Timestamp: 2026-06-09T16:27:26.195Z
Learning: When working in triggerdotdev/trigger.dev code related to worker-group/region default resolution (e.g., defaultWorkerInstanceGroupId handling used by getGlobalDefaultWorkerGroup, getDefaultWorkerGroupForProject, and RegionsPresenter), do NOT add org-level featureFlags overrides in only one resolution site. That can cause template creation routing/decisions to diverge from actual run routing. If org-level override of the default region/worker group is required, it must be centralized in getGlobalDefaultWorkerGroup so every resolution path remains aligned.

Applied to files:

  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
📚 Learning: 2026-05-14T08:21:07.614Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3614
File: apps/webapp/app/v3/mollifier/mollifierGate.server.ts:48-52
Timestamp: 2026-05-14T08:21:07.614Z
Learning: When using Trigger.dev v3 feature flags in the webapp, prefer the existing per-org gating mechanism supported by `flag()` via the `overrides` argument. Pass `Organization.featureFlags` (from `environment.organization.featureFlags`) as the `overrides` value; overrides must take precedence over the global `featureFlag` row. Do not require schema changes or add an `orgId` field to `FlagsOptions` for per-org gating—use the overrides pattern consistently (e.g., in gate flows like `resolveOrgFlag` and any server code that threads `environment.organization.featureFlags` into the gate call).

Applied to files:

  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
🔇 Additional comments (6)
apps/webapp/app/services/upsertBranch.server.ts (1)

157-157: LGTM!

apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts (1)

2-2: LGTM!

Also applies to: 62-79

apps/webapp/test/billingLimitConvergeEnvironments.test.ts (1)

58-82: LGTM!

apps/webapp/test/billingLimitEnvCreatePause.test.ts (1)

60-71: LGTM!

apps/webapp/test/billingLimitReconcileTick.test.ts (1)

78-107: LGTM!

apps/webapp/test/orgBanner.test.ts (1)

22-30: LGTM!

Also applies to: 32-39


Walkthrough

This PR implements a billing limits feature that lets organizations configure a monthly compute spend cap. When the cap is reached, a billing platform webhook triggers a grace period during which billable environments are paused; new task triggers are rejected once the grace period ends. A recovery flow lets users increase or remove the limit and choose to resume queued runs or accept cancellation. A Redis-backed worker periodically reconciles environment pause state against billing platform data. The feature adds a new /settings/billing-limits settings page that consolidates limit configuration, alert thresholds, and the recovery panel, replacing the old /settings/billing-alerts route (which now redirects). The unified OrgBanner component replaces the prior UpgradePrompt and EnvironmentBanner components with a selector-driven switch over all banner states.

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is an uncompleted template with all sections blank, no issue reference, and all checklist items unchecked. Complete all template sections: add issue reference, check applicable items, document testing steps, provide changelog summary, and include relevant screenshots.
Docstring Coverage ⚠️ Warning Docstring coverage is 19.40% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Billing limits' is vague and lacks specificity about the nature of the changes. Expand the title to clearly indicate the main change, such as 'Add billing limits feature with configuration UI and enforcement' or 'Implement billing limits and alerts management system'.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/billing-limits

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 17

🧹 Nitpick comments (4)
apps/webapp/app/env.server.ts (1)

1474-1474: ⚡ Quick win

Default to explicit opt-in ("0") for the new worker flag.

Per codebase conventions, new background worker feature flags should hard-default to "0" rather than inheriting from a parent flag like WORKER_ENABLED. The current default could cause the billing limit worker to auto-start unexpectedly on upgrade for deployments that already have WORKER_ENABLED set, introducing unplanned background load.

Suggested fix
-    BILLING_LIMIT_WORKER_ENABLED: z.string().default(process.env.WORKER_ENABLED ?? "true"),
+    BILLING_LIMIT_WORKER_ENABLED: z.string().default("0"),

Based on learnings: "In apps/*/app/env.server.ts, any new background/periodic worker feature flag should hard-default to '0' (explicit opt-in) rather than inheriting from a parent flag."

Source: Learnings

apps/webapp/app/v3/services/billingLimit/billingLimitReconciliation.server.ts (1)

67-75: ⚡ Quick win

Sequential billing-limit lookups will slow reconciliation as org count grows.

At Line 73 and Line 83, getBillingLimit() is awaited serially in loops. Consider bounded parallelism (Promise.all + limiter) to keep reconcile ticks timely.

Also applies to: 77-85

apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/route.tsx (1)

95-97: ⚡ Quick win

Add an inline note explaining why primary prisma is required here.

These lookups correctly use prisma.organization.findFirst(...); adding a one-line comment will reduce future regressions back to $replica in auth-scoped slug resolution paths.

Based on learnings: slug→organization resolution for authorization scope should stay on primary Prisma because replica lag can lead to unscoped RBAC checks.

Also applies to: 189-191

Source: Learnings

apps/webapp/app/components/billing/selectOrgBanner.ts (1)

3-10: ⚡ Quick win

Replace runtime enum with a string-union constant type.

Using export enum OrgBannerKind here conflicts with the repo TypeScript guideline and adds avoidable runtime enum output.

♻️ Suggested change
-export enum OrgBannerKind {
-  LimitRejected = "limit-rejected",
-  LimitGrace = "limit-grace",
-  NoLimitConfigured = "no-limit",
-  Upgrade = "upgrade",
-  EnvironmentWarning = "env-warning",
-  None = "none",
-}
+export const ORG_BANNER_KIND = {
+  LimitRejected: "limit-rejected",
+  LimitGrace: "limit-grace",
+  NoLimitConfigured: "no-limit",
+  Upgrade: "upgrade",
+  EnvironmentWarning: "env-warning",
+  None: "none",
+} as const;
+
+export type OrgBannerKind = (typeof ORG_BANNER_KIND)[keyof typeof ORG_BANNER_KIND];

As per coding guidelines, **/*.{ts,tsx}: “Use types over interfaces for TypeScript” and “Avoid using enums; prefer string unions or const objects instead.”

Source: Coding guidelines


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c7c9a3c5-ee1c-4334-b40a-d0b9aca60dd8

📥 Commits

Reviewing files that changed from the base of the PR and between 315baf2 and 5c1a4bf.

📒 Files selected for processing (81)
  • .server-changes/billing-limits.md
  • apps/webapp/app/components/billing/AnimatedOrgBannerBar.tsx
  • apps/webapp/app/components/billing/BillingAlertsSection.tsx
  • apps/webapp/app/components/billing/BillingLimitConfigSection.tsx
  • apps/webapp/app/components/billing/BillingLimitRecoveryPanel.tsx
  • apps/webapp/app/components/billing/BillingLimitResolveProgress.tsx
  • apps/webapp/app/components/billing/OrgBanner.tsx
  • apps/webapp/app/components/billing/UpgradePrompt.tsx
  • apps/webapp/app/components/billing/billingAlertsFormat.ts
  • apps/webapp/app/components/billing/billingLimitFormat.ts
  • apps/webapp/app/components/billing/selectOrgBanner.ts
  • apps/webapp/app/components/layout/AppLayout.tsx
  • apps/webapp/app/components/navigation/EnvironmentBanner.tsx
  • apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx
  • apps/webapp/app/components/primitives/AnimatedCallout.tsx
  • apps/webapp/app/components/primitives/PageHeader.tsx
  • apps/webapp/app/entry.server.tsx
  • apps/webapp/app/env.server.ts
  • apps/webapp/app/hooks/useOrganizations.ts
  • apps/webapp/app/hooks/useScrollContainerToTop.ts
  • apps/webapp/app/models/organization.server.ts
  • apps/webapp/app/presenters/OrganizationsPresenter.server.ts
  • apps/webapp/app/presenters/v3/EnvironmentVariablesPresenter.server.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-alerts/route.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/billingLimitsRevalidation.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/billingLimitsRoute.server.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/route.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.usage/route.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug/route.tsx
  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.hit.ts
  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.resolve.ts
  • apps/webapp/app/routes/storybook.callout/route.tsx
  • apps/webapp/app/runEngine/validators/triggerTaskValidator.ts
  • apps/webapp/app/runEngine/validators/validateProductionEntitlement.server.ts
  • apps/webapp/app/services/billingLimit.schemas.ts
  • apps/webapp/app/services/platform.v3.server.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/utils/pathBuilder.ts
  • apps/webapp/app/v3/billingLimitWorker.server.ts
  • apps/webapp/app/v3/outOfEntitlementError.server.ts
  • apps/webapp/app/v3/services/billingLimit/BillingLimitBulkCancelService.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitCancelInProgressRuns.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitConstants.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironmentsService.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitConvergeResolve.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitHit.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolve.types.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolveCoordinator.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolveFailure.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitReconcileQueue.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitReconcileTarget.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitReconciliation.server.ts
  • apps/webapp/app/v3/services/billingLimit/getBillingLimitQueuedRunCount.server.ts
  • apps/webapp/app/v3/services/billingLimit/getInitialEnvPauseStateForBillingLimit.server.ts
  • apps/webapp/app/v3/services/billingLimit/manualPauseEnvironmentGuard.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
  • apps/webapp/app/v3/services/pauseEnvironment.server.ts
  • apps/webapp/app/v3/services/triggerTask.server.ts
  • apps/webapp/server.ts
  • apps/webapp/test/billingAlertsFormat.test.ts
  • apps/webapp/test/billingLimit.schemas.test.ts
  • apps/webapp/test/billingLimitBulkCancelInProgress.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironmentsService.test.ts
  • apps/webapp/test/billingLimitConvergeResolve.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitHit.test.ts
  • apps/webapp/test/billingLimitPauseEnvironment.test.ts
  • apps/webapp/test/billingLimitQueuedRuns.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitReconciliation.test.ts
  • apps/webapp/test/billingLimitTriggerEntitlement.test.ts
  • apps/webapp/test/billingLimitsRoute.test.ts
  • apps/webapp/test/orgBanner.test.ts
  • docs/how-to-reduce-your-spend.mdx
  • internal-packages/database/prisma/migrations/20260614120000_add_environment_pause_source_billing_limit/migration.sql
  • internal-packages/database/prisma/schema.prisma
💤 Files with no reviewable changes (2)
  • apps/webapp/app/components/billing/UpgradePrompt.tsx
  • apps/webapp/app/components/navigation/EnvironmentBanner.tsx

Comment thread apps/webapp/app/components/billing/BillingAlertsSection.tsx
Comment thread apps/webapp/app/components/billing/OrgBanner.tsx
Comment thread apps/webapp/app/components/billing/selectOrgBanner.ts Outdated
Comment thread apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts Outdated
Comment thread apps/webapp/app/v3/services/pauseEnvironment.server.ts
Add the EnvironmentPauseSource enum and migration, plus the billing-limit platform client wrappers and schemas.
Configure a spend limit, manage billing alerts, and surface org-wide banners.
Converge billable environments to paused via webhook and a reconciliation worker; block manual resume.
Reject triggers with a 422 once entitlement reports no access, and bust the entitlement cache on state changes.
Recovery UI and durable resolve: cancel queued runs before unpausing, with reconciliation as a safety net.
Optionally cancel in-progress runs on limit hit via a deduplicated bulk-cancel job.
… tests

Add the usage-bar marker, documentation, and test coverage.
@kathiekiwi kathiekiwi force-pushed the feature/billing-limits branch from 5c1a4bf to ac87dcd Compare June 22, 2026 09:05
@pkg-pr-new

pkg-pr-new Bot commented Jun 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@ac87dcd

trigger.dev

npm i https://pkg.pr.new/trigger.dev@ac87dcd

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@ac87dcd

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@ac87dcd

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@ac87dcd

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@ac87dcd

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@ac87dcd

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@ac87dcd

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@ac87dcd

commit: ac87dcd

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx (1)

185-203: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Wrap environment-pause / environment-resume case bodies in braces.

Lines 187 and 196 violate noSwitchDeclarations because the const pauseService and const resumeService declarations are unscoped at the case level. Switch cases share scope, so these declarations could leak to other cases.

Compare with the queue-pause/queue-resume cases below (lines 204-231), which correctly wrap their entire bodies in braces. Remove the nested braces and wrap each case body in a single outer block:

🔧 Suggested fix
 case "environment-pause":
+case "environment-pause": {
   const pauseService = new PauseEnvironmentService();
-  {
-    const result = await pauseService.call(environment, "paused");
-    if (!result.success) {
-      return redirectWithErrorMessage(redirectPath, request, result.error);
-    }
+  const result = await pauseService.call(environment, "paused");
+  if (!result.success) {
+    return redirectWithErrorMessage(redirectPath, request, result.error);
   }
   return redirectWithSuccessMessage(redirectPath, request, "Environment paused");
+}
 case "environment-resume":
+case "environment-resume": {
   const resumeService = new PauseEnvironmentService();
-  {
-    const result = await resumeService.call(environment, "resumed");
-    if (!result.success) {
-      return redirectWithErrorMessage(redirectPath, request, result.error);
-    }
+  const result = await resumeService.call(environment, "resumed");
+  if (!result.success) {
+    return redirectWithErrorMessage(redirectPath, request, result.error);
   }
   return redirectWithSuccessMessage(redirectPath, request, "Environment resumed");
+}

Source: Linters/SAST tools


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9320da15-5344-4918-b7d0-22ed4d221bcc

📥 Commits

Reviewing files that changed from the base of the PR and between 5c1a4bf and ac87dcd.

📒 Files selected for processing (81)
  • .server-changes/billing-limits.md
  • apps/webapp/app/components/billing/AnimatedOrgBannerBar.tsx
  • apps/webapp/app/components/billing/BillingAlertsSection.tsx
  • apps/webapp/app/components/billing/BillingLimitConfigSection.tsx
  • apps/webapp/app/components/billing/BillingLimitRecoveryPanel.tsx
  • apps/webapp/app/components/billing/BillingLimitResolveProgress.tsx
  • apps/webapp/app/components/billing/OrgBanner.tsx
  • apps/webapp/app/components/billing/UpgradePrompt.tsx
  • apps/webapp/app/components/billing/billingAlertsFormat.ts
  • apps/webapp/app/components/billing/billingLimitFormat.ts
  • apps/webapp/app/components/billing/selectOrgBanner.ts
  • apps/webapp/app/components/layout/AppLayout.tsx
  • apps/webapp/app/components/navigation/EnvironmentBanner.tsx
  • apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx
  • apps/webapp/app/components/primitives/AnimatedCallout.tsx
  • apps/webapp/app/components/primitives/PageHeader.tsx
  • apps/webapp/app/entry.server.tsx
  • apps/webapp/app/env.server.ts
  • apps/webapp/app/hooks/useOrganizations.ts
  • apps/webapp/app/hooks/useScrollContainerToTop.ts
  • apps/webapp/app/models/organization.server.ts
  • apps/webapp/app/presenters/OrganizationsPresenter.server.ts
  • apps/webapp/app/presenters/v3/EnvironmentVariablesPresenter.server.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-alerts/route.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/billingLimitsRevalidation.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/billingLimitsRoute.server.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/route.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.usage/route.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug/route.tsx
  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.hit.ts
  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.resolve.ts
  • apps/webapp/app/routes/storybook.callout/route.tsx
  • apps/webapp/app/runEngine/validators/triggerTaskValidator.ts
  • apps/webapp/app/runEngine/validators/validateProductionEntitlement.server.ts
  • apps/webapp/app/services/billingLimit.schemas.ts
  • apps/webapp/app/services/platform.v3.server.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/utils/pathBuilder.ts
  • apps/webapp/app/v3/billingLimitWorker.server.ts
  • apps/webapp/app/v3/outOfEntitlementError.server.ts
  • apps/webapp/app/v3/services/billingLimit/BillingLimitBulkCancelService.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitCancelInProgressRuns.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitConstants.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironmentsService.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitConvergeResolve.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitHit.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolve.types.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolveCoordinator.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolveFailure.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitReconcileQueue.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitReconcileTarget.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitReconciliation.server.ts
  • apps/webapp/app/v3/services/billingLimit/getBillingLimitQueuedRunCount.server.ts
  • apps/webapp/app/v3/services/billingLimit/getInitialEnvPauseStateForBillingLimit.server.ts
  • apps/webapp/app/v3/services/billingLimit/manualPauseEnvironmentGuard.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
  • apps/webapp/app/v3/services/pauseEnvironment.server.ts
  • apps/webapp/app/v3/services/triggerTask.server.ts
  • apps/webapp/server.ts
  • apps/webapp/test/billingAlertsFormat.test.ts
  • apps/webapp/test/billingLimit.schemas.test.ts
  • apps/webapp/test/billingLimitBulkCancelInProgress.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironmentsService.test.ts
  • apps/webapp/test/billingLimitConvergeResolve.test.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitHit.test.ts
  • apps/webapp/test/billingLimitPauseEnvironment.test.ts
  • apps/webapp/test/billingLimitQueuedRuns.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/test/billingLimitReconciliation.test.ts
  • apps/webapp/test/billingLimitTriggerEntitlement.test.ts
  • apps/webapp/test/billingLimitsRoute.test.ts
  • apps/webapp/test/orgBanner.test.ts
  • docs/how-to-reduce-your-spend.mdx
  • internal-packages/database/prisma/migrations/20260614120000_add_environment_pause_source_billing_limit/migration.sql
  • internal-packages/database/prisma/schema.prisma
💤 Files with no reviewable changes (2)
  • apps/webapp/app/components/navigation/EnvironmentBanner.tsx
  • apps/webapp/app/components/billing/UpgradePrompt.tsx
✅ Files skipped from review due to trivial changes (7)
  • apps/webapp/app/entry.server.tsx
  • apps/webapp/app/presenters/v3/EnvironmentVariablesPresenter.server.ts
  • .server-changes/billing-limits.md
  • apps/webapp/app/v3/services/billingLimit/getBillingLimitQueuedRunCount.server.ts
  • apps/webapp/test/billingLimit.schemas.test.ts
  • docs/how-to-reduce-your-spend.mdx
  • apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx
🚧 Files skipped from review as they are similar to previous changes (70)
  • internal-packages/database/prisma/migrations/20260614120000_add_environment_pause_source_billing_limit/migration.sql
  • apps/webapp/app/hooks/useScrollContainerToTop.ts
  • apps/webapp/test/orgBanner.test.ts
  • apps/webapp/app/components/billing/BillingLimitResolveProgress.tsx
  • apps/webapp/test/billingLimitQueuedRuns.test.ts
  • apps/webapp/test/billingLimitTriggerEntitlement.test.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/billingLimitsRevalidation.ts
  • apps/webapp/app/components/billing/billingLimitFormat.ts
  • apps/webapp/app/presenters/OrganizationsPresenter.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitCancelInProgressRuns.server.ts
  • apps/webapp/test/billingLimitReconciliation.test.ts
  • apps/webapp/test/billingLimitReconcileTick.test.ts
  • apps/webapp/app/components/billing/selectOrgBanner.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolve.types.ts
  • apps/webapp/test/billingLimitEnvCreatePause.test.ts
  • apps/webapp/test/billingLimitConvergeEnvironmentsService.test.ts
  • apps/webapp/test/billingLimitHit.test.ts
  • apps/webapp/app/v3/services/triggerTask.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitReconcileTarget.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolveCoordinator.server.ts
  • apps/webapp/app/v3/services/pauseEnvironment.server.ts
  • apps/webapp/app/v3/outOfEntitlementError.server.ts
  • apps/webapp/app/v3/services/billingLimit/manualPauseEnvironmentGuard.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitConvergeResolve.server.ts
  • apps/webapp/app/utils/pathBuilder.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolveFailure.server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironmentsService.server.ts
  • apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
  • apps/webapp/test/billingLimitConvergeResolve.test.ts
  • apps/webapp/app/components/layout/AppLayout.tsx
  • apps/webapp/test/billingLimitBulkCancelInProgress.test.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitHit.server.ts
  • apps/webapp/test/billingLimitPauseEnvironment.test.ts
  • apps/webapp/app/runEngine/validators/triggerTaskValidator.ts
  • apps/webapp/server.ts
  • apps/webapp/app/v3/services/billingLimit/billingLimitReconcileQueue.server.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.usage/route.tsx
  • apps/webapp/app/v3/services/billingLimit/billingLimitConstants.ts
  • apps/webapp/app/hooks/useOrganizations.ts
  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.hit.ts
  • apps/webapp/test/billingLimitConvergeEnvironments.test.ts
  • apps/webapp/app/routes/storybook.callout/route.tsx
  • apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts
  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.resolve.ts
  • apps/webapp/test/billingLimitsRoute.test.ts
  • apps/webapp/app/components/billing/BillingLimitRecoveryPanel.tsx
  • apps/webapp/app/components/primitives/PageHeader.tsx
  • apps/webapp/app/v3/services/billingLimit/billingLimitReconciliation.server.ts
  • apps/webapp/app/runEngine/validators/validateProductionEntitlement.server.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/billingLimitsRoute.server.ts
  • apps/webapp/app/v3/billingLimitWorker.server.ts
  • apps/webapp/test/billingAlertsFormat.test.ts
  • apps/webapp/app/components/billing/OrgBanner.tsx
  • apps/webapp/app/services/billingLimit.schemas.ts
  • internal-packages/database/prisma/schema.prisma
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-alerts/route.tsx
  • apps/webapp/app/models/organization.server.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug/route.tsx
  • apps/webapp/app/components/billing/AnimatedOrgBannerBar.tsx
  • apps/webapp/app/components/primitives/AnimatedCallout.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/route.tsx
  • apps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
  • apps/webapp/app/v3/services/billingLimit/getInitialEnvPauseStateForBillingLimit.server.ts
  • apps/webapp/app/services/upsertBranch.server.ts
  • apps/webapp/app/env.server.ts
  • apps/webapp/app/components/billing/BillingLimitConfigSection.tsx
  • apps/webapp/app/components/billing/BillingAlertsSection.tsx
  • apps/webapp/app/v3/services/billingLimit/BillingLimitBulkCancelService.server.ts
  • apps/webapp/app/components/billing/billingAlertsFormat.ts
  • apps/webapp/app/services/platform.v3.server.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (26)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
  • GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
  • GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
  • GitHub Check: Build and publish previews
  • GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead

Import from @trigger.dev/sdk when writing Trigger.dev tasks. Never use @trigger.dev/sdk/v3 or deprecated client.defineJob

Files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
{packages/core,apps/webapp}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use zod for validation in packages/core and apps/webapp

Files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use function declarations instead of default exports

**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamic imports. Only use dynamic import() when circular dependencies cannot be resolved, code splitting is needed for performance, or the module must be loaded conditionally at runtime
Import subpaths only from packages/core (@trigger.dev/core), never import from the root

Files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)

**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries

Files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
apps/webapp/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

apps/webapp/**/*.{ts,tsx}: Access environment variables through the env export of env.server.ts instead of directly accessing process.env
Use subpath exports from @trigger.dev/core package instead of importing from the root @trigger.dev/core path

Use named constants for sentinel/placeholder values (e.g. const UNSET_VALUE = '__unset__') instead of raw string literals scattered across comparisons

Files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
**/*.{js,ts,tsx,jsx,css,json,md}

📄 CodeRabbit inference engine (AGENTS.md)

Use Prettier for code formatting and run pnpm run format before committing

Files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
apps/webapp/**/*.{tsx,jsx}

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

Only use useCallback/useMemo for context provider values, expensive derived data that is a dependency elsewhere, or stable refs required by a dependency array. Don't wrap ordinary event handlers or trivial computations

Files:

  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
🧠 Learnings (14)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).

Applied to files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.

Applied to files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.

Applied to files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.

Applied to files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.

Applied to files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).

Applied to files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.

Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.

Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.

Applied to files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.

Applied to files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.

Applied to files:

  • apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
📚 Learning: 2026-02-03T18:27:40.429Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 2994
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables/route.tsx:553-555
Timestamp: 2026-02-03T18:27:40.429Z
Learning: In apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables/route.tsx, the menu buttons (e.g., Edit with PencilSquareIcon) in the TableCellMenu are intentionally icon-only with no text labels as a compact UI pattern. This is a deliberate design choice for this route; preserve the icon-only behavior for consistency in this file.

Applied to files:

  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-02-11T16:37:32.429Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3019
File: apps/webapp/app/components/primitives/charts/Card.tsx:26-30
Timestamp: 2026-02-11T16:37:32.429Z
Learning: In projects using react-grid-layout, avoid relying on drag-handle class to imply draggability. Ensure drag-handle elements only affect dragging when the parent grid item is configured draggable in the layout; conditionally apply cursor styles based on the draggable prop. This improves correctness and accessibility.

Applied to files:

  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-04-02T19:18:26.255Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3319
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions/route.tsx:179-189
Timestamp: 2026-04-02T19:18:26.255Z
Learning: In this repo’s route components that render the Inspector `ResizablePanelGroup` panels, it’s acceptable to pass `collapsed={!isShowingInspector}` together with a no-op `onCollapseChange={() => {}}` when panel visibility is intentionally controlled only by route parameters (e.g., `*Param` search/route params) rather than user drag/collapse interactions. Do not flag an empty/no-op `onCollapseChange` as “missing wiring” in these cases; only flag it when collapse state is expected to change based on user interaction.

Applied to files:

  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-05-12T21:04:00.184Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.sessions._index/route.tsx:40-42
Timestamp: 2026-05-12T21:04:00.184Z
Learning: In triggerdotdev/trigger.dev route loader implementations (Remix `route.tsx` files under `apps/webapp/app/routes/**`), follow the existing convention for missing/unauthorized environment lookups: when `findEnvironmentBySlug` (or the equivalent env resolver) returns a falsy value, handle it by throwing `new Error("Environment not found")` rather than returning a `404` `Response` (i.e., do not flag this as “missing 404 response”). Changing the error-to-404 convention is a cross-cutting refactor and should be left out of individual PRs unless the PR explicitly addresses that broader migration.

Applied to files:

  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-05-08T21:00:20.973Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3538
File: apps/webapp/app/components/primitives/Resizable.tsx:60-78
Timestamp: 2026-05-08T21:00:20.973Z
Learning: In the triggerdotdev/trigger.dev codebase, treat Zod as a boundary validation tool (API handlers, request/response validation, and storage/DB read/write validation), not as inline render-time validation inside React components/primitive UI code. For render-time guards, prefer small manual type-narrowing checks (e.g., a short predicate like ~10–20 lines) over importing Zod into UI primitives, to avoid per-render schema-parse overhead and unnecessary abstraction. Use the manual guard approach unless you truly need schema validation at a boundary; only then introduce Zod.

Applied to files:

  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
🪛 Biome (2.5.0)
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx

[error] 196-196: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.

(lint/correctness/noSwitchDeclarations)

🔇 Additional comments (8)
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts (7)

1-7: LGTM!


9-11: LGTM!


14-19: LGTM!


21-30: LGTM!


33-34: LGTM!


36-36: LGTM!


32-32: No action needed—bustBillingLimitCaches is intentionally synchronous.

The function is a regular (non-async) function that triggers cache invalidation as a fire-and-forget operation. Internal calls to platformCache.billingLimit.remove() and platformCache.entitlement.remove() return Promises with .catch() handlers, but they are not awaited by design. This allows queue operations on subsequent lines to proceed without delay while cache invalidation happens asynchronously in the background.

			> Likely an incorrect or invalid review comment.
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx (1)

13-13: LGTM!

Also applies to: 360-362

Replace the invalid @trigger.dev/platform/v3 import so billing limit typecheck passes in CI.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kathiekiwi kathiekiwi force-pushed the feature/billing-limits branch from ac87dcd to 80b0a02 Compare June 22, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant