fix(dashboard-agent): stop reporting a queue as missing when only its kind was guessed wrong

The metrics route answers an unknown queue with zeroes, so asking for the wrong kind read as an idle queue. get_queue now tries the other kind before believing them.

Author: kathiekiwi

apps/webapp/app/components/dashboard-agent/view-actions.test.ts

@@ -1,7 +1,12 @@
 import type { ActionsBlockAction } from "@internal/dashboard-agent-contracts";
 import { readFileSync } from "node:fs";
 import { describe, expect, it } from "vitest";
-import { cardAlreadyOffersWatch, renderableActions, withoutWatchActions } from "./view-actions";
+import {
+  answerContinuesAfter,
+  cardAlreadyOffersWatch,
+  renderableActions,
+  withoutWatchActions,
+} from "./view-actions";
 
 const watchAction: ActionsBlockAction = {
   label: "Set up a watch",
@@ -16,7 +21,6 @@ const watchAction: ActionsBlockAction = {
     },
   },
 };
-import { answerContinuesAfter, renderableActions } from "./view-actions";
 
 const askAction: ActionsBlockAction = {
   label: "Investigate it",

internal-packages/dashboard-agent/src/__snapshots__/prompt-prefix.test.ts.snap

@@ -4,34 +4,34 @@ exports[`the prefix stays inside its budget > matches the committed measurement
 {
   "assistant": {
     "prompt": {
-      "chars": 24349,
-      "estimatedTokens": 6087,
+      "chars": 24504,
+      "estimatedTokens": 6126,
     },
     "tools": {
       "chars": 49210,
       "count": 24,
       "estimatedTokens": 12303,
     },
     "total": {
-      "chars": 73560,
-      "estimatedTokens": 18390,
-      "fingerprint": "881ce5e7",
+      "chars": 73715,
+      "estimatedTokens": 18429,
+      "fingerprint": "376f30ba",
     },
   },
   "code": {
     "prompt": {
-      "chars": 27104,
-      "estimatedTokens": 6776,
+      "chars": 27259,
+      "estimatedTokens": 6815,
     },
     "tools": {
       "chars": 52219,
       "count": 28,
       "estimatedTokens": 13055,
     },
     "total": {
-      "chars": 79324,
-      "estimatedTokens": 19831,
-      "fingerprint": "d1322cde",
+      "chars": 79479,
+      "estimatedTokens": 19870,
+      "fingerprint": "2cdf079b",
     },
   },
 }

internal-packages/dashboard-agent/src/tool-api.ts

@@ -44,6 +44,31 @@ import type { InvestigationRenderer } from "./tool-investigations";
  * The API read tools, in the frozen key order `dashboardAgentToolSchemas` declares:
  * a different order is a different cached prompt prefix.
  */
+/**
+ * Whether a metrics answer carries no evidence the queue exists. Zeroes across the board
+ * are what the route returns for a name it has never seen, and also what a genuinely idle
+ * queue looks like — so this only decides whether to try the other queue kind, never what
+ * to tell the user.
+ */
+export function queueMetricsAreEmpty(data: unknown): boolean {
+  const d = data as {
+    peakQueued?: number;
+    startedCount?: number;
+    throttledCount?: number;
+    depthTrend?: unknown[];
+    waitMs?: { p50?: number | null; p95?: number | null };
+  } | null;
+  if (!d) return true;
+  return (
+    (d.peakQueued ?? 0) === 0 &&
+    (d.startedCount ?? 0) === 0 &&
+    (d.throttledCount ?? 0) === 0 &&
+    (d.depthTrend ?? []).length === 0 &&
+    d.waitMs?.p50 == null &&
+    d.waitMs?.p95 == null
+  );
+}
+
 export function buildApiTools(args: {
   ctx: DashboardAgentToolContext;
   client: DashboardAgentApiClient;
@@ -316,20 +341,35 @@ export function buildApiTools(args: {
     get_queue: tool({
       ...getQueueSchema,
       execute: async ({ queue, type, period }) => {
-        const sp = new URLSearchParams({ type: type ?? "task" });
-        if (period) sp.append("period", period);
-        // Double-encoded: a task queue's ClickHouse name carries a `task/` prefix, and
-        // the route un-escapes `%2F` back to `/` itself.
-        const result = await envApiGet(
-          `/api/v1/queues/${encodeURIComponent(queue)}/metrics?${sp.toString()}`
-        );
-        if (!result) return { error: "No current environment is available to read queues from." };
-        if (!result.ok) {
+        // The metrics route answers an unknown queue with zeroes rather than a 404, so a
+        // wrong `type` reads exactly like an idle queue — and the wrong half of that pair
+        // is easy to pick, since a named queue and a task's own queue look alike. Try the
+        // other kind before believing the zeroes, and say which one answered.
+        const read = async (kind: "task" | "custom") => {
+          const sp = new URLSearchParams({ type: kind });
+          if (period) sp.append("period", period);
+          // Double-encoded: a task queue's ClickHouse name carries a `task/` prefix, and
+          // the route un-escapes `%2F` back to `/` itself.
+          const result = await envApiGet(
+            `/api/v1/queues/${encodeURIComponent(queue)}/metrics?${sp.toString()}`
+          );
+          return result;
+        };
+
+        const first = await read(type ?? "task");
+        if (!first) return { error: "No current environment is available to read queues from." };
+        if (!first.ok) {
           return {
-            error: `Couldn't get metrics for the ${queue} queue (status ${result.status}).`,
+            error: `Couldn't get metrics for the ${queue} queue (status ${first.status}).`,
           };
         }
-        return result.data;
+        if (queueMetricsAreEmpty(first.data)) {
+          const other = await read(type === "custom" ? "task" : "custom");
+          if (other?.ok && !queueMetricsAreEmpty(other.data)) {
+            return { ...(other.data as object), queueType: type === "custom" ? "task" : "custom" };
+          }
+        }
+        return { ...(first.data as object), queueType: type ?? "task" };
       },
     }),
 

internal-packages/dashboard-agent/src/tool-queue.test.ts

@@ -0,0 +1,31 @@
+import { describe, expect, it } from "vitest";
+import { queueMetricsAreEmpty } from "./tool-api";
+
+/**
+ * The metrics route answers an unknown queue with zeroes rather than a 404, so asking for
+ * the wrong queue kind reads exactly like an idle queue. `get_queue` retries with the other
+ * kind before believing that, which is what stops "no queue named email-sends exists" being
+ * said about a queue holding thousands of runs.
+ */
+describe("queueMetricsAreEmpty", () => {
+  const zeroes = {
+    peakQueued: 0,
+    startedCount: 0,
+    throttledCount: 0,
+    depthTrend: [],
+    waitMs: { p50: null, p95: null },
+  };
+
+  it("treats an all-zero answer as no evidence the queue exists", () => {
+    expect(queueMetricsAreEmpty(zeroes)).toBe(true);
+    expect(queueMetricsAreEmpty(null)).toBe(true);
+  });
+
+  it("takes any single sign of life as evidence", () => {
+    expect(queueMetricsAreEmpty({ ...zeroes, peakQueued: 4800 })).toBe(false);
+    expect(queueMetricsAreEmpty({ ...zeroes, startedCount: 3 })).toBe(false);
+    expect(queueMetricsAreEmpty({ ...zeroes, throttledCount: 1 })).toBe(false);
+    expect(queueMetricsAreEmpty({ ...zeroes, depthTrend: [0, 0] })).toBe(false);
+    expect(queueMetricsAreEmpty({ ...zeroes, waitMs: { p50: 0, p95: null } })).toBe(false);
+  });
+});