merge: base-misc review fixes (M2, M10a, H8, H13, M10r, ai-help, sweep-cron gate)

Author: kathiekiwi

.server-changes/agent-body-cap-task-id.md

@@ -0,0 +1,6 @@
+---
+area: webapp
+type: fix
+---
+
+Triggering a task whose id contains "dashboard-agent" is no longer subject to the smaller chat request size limit, so larger payloads go through as expected.

.server-changes/report-freshness-window.md

@@ -0,0 +1,6 @@
+---
+area: webapp
+type: fix
+---
+
+Health reports no longer show as "fresh" when the underlying data is actually older than the freshness window.

apps/webapp/app/presenters/v3/reports/ReportPresenter.server.ts

@@ -6,13 +6,17 @@ import {
   type UnkeyCache,
 } from "@internal/cache";
 import { type AuthenticatedEnvironment } from "~/services/apiAuth.server";
+import { HEALTH_THRESHOLDS } from "./health/health-core";
 import { REPORT_REGISTRY, type ReportLoader } from "./report-registry";
 import { type ReportViewModel } from "./report-view-model";
 
 const DEFAULT_PERIOD = "1h";
 
-/** How long a finished report stays reusable. */
-export const REPORT_CACHE_TTL_MS = 90_000;
+/**
+ * How long a finished report stays reusable. Capped at the liveness fresh window so a
+ * cached report can never render "fresh" while its telemetry is already stale.
+ */
+export const REPORT_CACHE_TTL_MS = HEALTH_THRESHOLDS.liveness.freshMs;
 
 /** How many report, environment and period triples one instance keeps. */
 const REPORT_CACHE_MAX_ENTRIES = 500;

apps/webapp/app/presenters/v3/reports/health/health-messages.ts

@@ -34,7 +34,7 @@ const FINDING_REASONS: Record<string, string> = {
   "flow/unknown": "flow can't be assessed — the telemetry is stale",
   "flow/flow_unmeasured": "flow can't be assessed — the queue depth couldn't be measured",
   "execution/healthy": "completing normally", // collapsed
-  "execution/healthy@expanded": "the runs that DO start are fine",
+  "execution/healthy@expanded": "runs are executing normally",
   // liveness is telemetry freshness
   "liveness/fresh": "fresh — telemetry current, updated {age} ago",
   "liveness/lagging": "lagging — telemetry last updated {age} ago",

apps/webapp/app/routes/projects.$projectRef.ai-help.ts

@@ -38,7 +38,7 @@ export async function loader({ params, request }: LoaderFunctionArgs) {
   const query = url.searchParams.get("q");
 
   if (!query) {
-    return new Response("No query", { status: 404 });
+    return new Response("No query", { status: 400 });
   }
 
   const newUrl = new URL(

apps/webapp/app/services/dashboardAgentBodyCap.server.ts

@@ -16,7 +16,10 @@ const INGRESS_SLACK_BYTES = 8 * 1024;
 
 export const DASHBOARD_AGENT_MAX_INGRESS_BYTES = MAX_MESSAGE_BODY_BYTES + INGRESS_SLACK_BYTES;
 
-const AGENT_PATH = /\/dashboard-agent(\/|$)/;
+// The agent's own routes only: the `/api/v1/dashboard-agent/…` endpoints and the
+// `/…/env/<env>/dashboard-agent…` chat resources. Anchored so a task named
+// `dashboard-agent` (`/api/v1/tasks/dashboard-agent/trigger`) is not capped.
+const AGENT_PATH = /^\/api\/v1\/dashboard-agent(\/|$)|\/env\/[^/]+\/dashboard-agent(\/|$)/;
 
 /** Methods that can carry one. GET and HEAD cannot, and streaming them would be wasted work. */
 const BODY_METHODS = new Set(["POST", "PUT", "PATCH", "DELETE"]);

apps/webapp/app/v3/commonWorker.server.ts

@@ -39,6 +39,11 @@ function initializeWorker() {
 
   logger.debug(`👨‍🏭 Initializing common worker at host ${env.COMMON_WORKER_REDIS_HOST}`);
 
+  // Only schedule the agent maintenance cron where the agent is actually set up. Otherwise
+  // its sweeps hit a missing schema and drip a dead-letter entry every run.
+  const dashboardAgentConfigured =
+    env.DASHBOARD_AGENT_ENABLED === "1" || Boolean(env.DASHBOARD_AGENT_DATABASE_URL);
+
   const worker = new RedisWorker({
     name: "common-worker",
     redisOptions,
@@ -152,8 +157,7 @@ function initializeWorker() {
       "dashboardAgent.maintenance": {
         schema: CronSchema,
         visibilityTimeoutMs: 60_000 * 5,
-        cron: "*/5 * * * *",
-        jitterInMs: 30_000,
+        ...(dashboardAgentConfigured ? { cron: "*/5 * * * *", jitterInMs: 30_000 } : {}),
         retry: {
           maxAttempts: 1,
         },

apps/webapp/app/v3/detectQueryTables.ts

@@ -103,6 +103,9 @@ export function detectQueryTables(query: string, allowedTableNames: Set<string>)
         visitSelectSet(tableExpr as SelectSetQuery);
       }
     }
+    // The `ON expr` can embed a SELECT that reads a real table, e.g.
+    // `JOIN x ON id IN (SELECT … FROM runs)`.
+    scanForSubqueries(node.constraint);
     if (node.next_join) visitJoin(node.next_join);
   }
 

apps/webapp/test/__snapshots__/reportRenderParity.test.ts.snap

@@ -148,4 +148,17 @@ describe("the dashboard agent's ingress cap", () => {
     expect(response.status).toBe(200);
     expect(buffered()).toBe(size);
   });
+
+  it("does not cap a task whose id is literally dashboard-agent", async () => {
+    const { url, buffered } = await listen();
+    const size = DASHBOARD_AGENT_MAX_INGRESS_BYTES + 1024;
+
+    const response = await fetch(`${url}/api/v1/tasks/dashboard-agent/trigger`, {
+      method: "POST",
+      body: "x".repeat(size),
+    });
+
+    expect(response.status).toBe(200);
+    expect(buffered()).toBe(size);
+  });
 });