Skip to content

Commit c8f01a3

Browse files
d-csclaude
andcommitted
chore(run-ops split): strip test-plan enumeration scaffolding from pr11 activation tests
Remove Test A–F enumeration prefixes from the run-ops cascade-cleanup comments and the RED/GREEN TDD framing from the ProjectAlert control-plane FK reconciliation test header. Comment-only; no product logic, test behavior, or migration SQL changed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 1ac3548 commit c8f01a3

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

apps/webapp/test/v3/runOpsMigration/runOpsCascadeCleanup.server.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ describe("RunOpsCascadeCleanupService", () => {
384384
}
385385
);
386386

387-
// Test A: env cleanup over both writers empties the subgraph on BOTH DBs + BulkActionItem on the
387+
// Env cleanup over both writers empties the subgraph on BOTH DBs + BulkActionItem on the
388388
// control-plane DB; a sibling scope survives.
389389
heteroPostgresTest(
390390
"cleanupEnvironment empties the subgraph across both writers, isolating a sibling env",
@@ -422,7 +422,7 @@ describe("RunOpsCascadeCleanupService", () => {
422422
}
423423
);
424424

425-
// Test B: project cleanup over both writers.
425+
// Project cleanup over both writers.
426426
heteroPostgresTest(
427427
"cleanupProject empties the subgraph across both writers, isolating a sibling project",
428428
async ({ prisma14, prisma17 }) => {
@@ -459,7 +459,7 @@ describe("RunOpsCascadeCleanupService", () => {
459459
}
460460
);
461461

462-
// Test C: idempotency — a second cleanup returns all-zero counts and does not throw on either DB.
462+
// Idempotency — a second cleanup returns all-zero counts and does not throw on either DB.
463463
heteroPostgresTest(
464464
"cleanupEnvironment is idempotent on a re-run across both FK configs",
465465
async ({ prisma14, prisma17 }) => {
@@ -496,7 +496,7 @@ describe("RunOpsCascadeCleanupService", () => {
496496
}
497497
);
498498

499-
// Test D: FK-retained vs FK-dropped fixtures reach an identical run-subgraph end-state.
499+
// FK-retained vs FK-dropped fixtures reach an identical run-subgraph end-state.
500500
heteroPostgresTest(
501501
"FK-retained and FK-dropped fixtures reach an identical end-state after cleanup",
502502
async ({ prisma14, prisma17 }) => {
@@ -522,7 +522,7 @@ describe("RunOpsCascadeCleanupService", () => {
522522
}
523523
);
524524

525-
// Test E: single-DB mode — the same client passed twice de-dups so the pass runs once.
525+
// Single-DB mode — the same client passed twice de-dups so the pass runs once.
526526
heteroPostgresTest(
527527
"single-DB: the same client passed twice de-dups so the delete pass runs exactly once",
528528
async ({ prisma14 }) => {
@@ -558,7 +558,7 @@ describe("RunOpsCascadeCleanupService", () => {
558558
}
559559
);
560560

561-
// Test F: the two-writer split — an env whose rows straddle both DBs (cuid runs on the LEGACY DB,
561+
// The two-writer split — an env whose rows straddle both DBs (cuid runs on the LEGACY DB,
562562
// ksuid runs on the NEW DB) is fully cleaned by one call; a single-writer service leaks orphans.
563563
heteroPostgresTest(
564564
"two-writer fan-out cleans a split env on both DBs; single-writer leaves orphans",

internal-packages/run-store/src/PostgresRunStore.controlPlaneAlertFk.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// on the dedicated run-ops DB (prisma17), so `projectAlert.create({ taskRunId: <ksuid> })` on
33
// control-plane (prisma14) violates the FK and the alert is silently dropped. After the FK drop +
44
// @relation removal the create succeeds; the read path resolves the run via runStore.findRun.
5-
// Asserts the create SUCCEEDS — RED (FK violation) before the fix, GREEN after.
5+
// Asserts the create succeeds: it fails with an FK violation before the fix and succeeds after.
66

77
import { heteroRunOpsPostgresTest } from "@internal/testcontainers";
88
import type { PrismaClient } from "@trigger.dev/database";

0 commit comments

Comments
 (0)