fix(cli,core): fail indexing on duplicate webhook ids

Two webhook() declarations sharing an id used to silently overwrite each other in the worker manifest. Indexing now fails with the colliding ids and their file paths, matching how duplicate task ids are already handled.

Author: ericallam

packages/cli-v3/src/entryPoints/dev-index-worker.ts

@@ -17,6 +17,7 @@ import { readFile } from "node:fs/promises";
 import sourceMapSupport from "source-map-support";
 import { registerResources } from "../indexing/registerResources.js";
 import { reportTaskIdCollisions } from "../indexing/reportTaskIdCollisions.js";
+import { reportWebhookIdCollisions } from "../indexing/reportWebhookIdCollisions.js";
 import { env } from "std-env";
 import { normalizeImportPath } from "../utilities/normalizeImportPath.js";
 import { detectRuntimeVersion } from "@trigger.dev/core/v3/build";
@@ -127,6 +128,11 @@ if (await reportTaskIdCollisions(safeSend)) {
   process.exit(0);
 }
 
+if (await reportWebhookIdCollisions(safeSend)) {
+  await new Promise<void>((resolve) => setTimeout(resolve, 10));
+  process.exit(0);
+}
+
 let tasks = await convertSchemasToJsonSchemas(resourceCatalog.listTaskManifests());
 
 // If the config has retry defaults, we need to apply them to all tasks that don't have any retry settings

packages/cli-v3/src/entryPoints/managed-index-worker.ts

@@ -17,6 +17,7 @@ import { readFile } from "node:fs/promises";
 import sourceMapSupport from "source-map-support";
 import { registerResources } from "../indexing/registerResources.js";
 import { reportTaskIdCollisions } from "../indexing/reportTaskIdCollisions.js";
+import { reportWebhookIdCollisions } from "../indexing/reportWebhookIdCollisions.js";
 import { env } from "std-env";
 import { normalizeImportPath } from "../utilities/normalizeImportPath.js";
 import { detectRuntimeVersion } from "@trigger.dev/core/v3/build";
@@ -121,6 +122,11 @@ if (await reportTaskIdCollisions(safeSend)) {
   process.exit(0);
 }
 
+if (await reportWebhookIdCollisions(safeSend)) {
+  await new Promise<void>((resolve) => setTimeout(resolve, 10));
+  process.exit(0);
+}
+
 let tasks = await convertSchemasToJsonSchemas(resourceCatalog.listTaskManifests());
 
 // If the config has retry defaults, we need to apply them to all tasks that don't have any retry settings

packages/cli-v3/src/indexing/indexWorkerManifest.ts

@@ -1,6 +1,7 @@
 import { execPathForRuntime } from "@trigger.dev/core/v3/build";
 import {
   DuplicateTaskIdsError,
+  DuplicateWebhookIdsError,
   TaskIndexingImportError,
   TaskMetadataParseError,
   UncaughtExceptionError,
@@ -94,6 +95,13 @@ export async function indexWorkerManifest({
           child.kill("SIGKILL");
           break;
         }
+        case "WEBHOOKS_FAILED_TO_INDEX": {
+          clearTimeout(timeout);
+          resolved = true;
+          reject(new DuplicateWebhookIdsError(message.payload.collisions));
+          child.kill("SIGKILL");
+          break;
+        }
         case "UNCAUGHT_EXCEPTION": {
           clearTimeout(timeout);
           resolved = true;

packages/cli-v3/src/indexing/reportWebhookIdCollisions.ts

@@ -0,0 +1,28 @@
+import { indexerToWorkerMessages, resourceCatalog } from "@trigger.dev/core/v3";
+import { sendMessageInCatalog } from "@trigger.dev/core/v3/zodMessageHandler";
+
+/**
+ * If the indexer registered any duplicate webhook ids (across files), report
+ * them to the parent via WEBHOOKS_FAILED_TO_INDEX and return true. Callers must
+ * stop indexing (skip INDEX_COMPLETE) when this returns true.
+ */
+export async function reportWebhookIdCollisions(
+  send: (message: unknown) => void
+): Promise<boolean> {
+  const collisions = resourceCatalog.listWebhookIdCollisions();
+
+  if (collisions.length === 0) {
+    return false;
+  }
+
+  await sendMessageInCatalog(
+    indexerToWorkerMessages,
+    "WEBHOOKS_FAILED_TO_INDEX",
+    { collisions },
+    async (msg) => {
+      send(msg);
+    }
+  );
+
+  return true;
+}

packages/core/src/v3/errors.ts

@@ -606,6 +606,37 @@ export class DuplicateTaskIdsError extends Error {
   }
 }
 
+function formatDuplicateWebhookIds(collisions: TaskIdCollision[]): string {
+  const lines = collisions.map(({ id, filePaths }) => {
+    const distinct = Array.from(new Set(filePaths));
+
+    if (distinct.length === 1) {
+      return `  - "${id}" found more than once in ${distinct[0]}`;
+    }
+
+    const last = distinct[distinct.length - 1];
+    const head = distinct.slice(0, -1).join(", ");
+
+    return `  - "${id}" found in ${head} and ${last}`;
+  });
+
+  return [
+    "Duplicate webhook ids detected:",
+    "",
+    ...lines,
+    "",
+    "Webhook ids must be unique across your project. Please rename one of them.",
+  ].join("\n");
+}
+
+export class DuplicateWebhookIdsError extends Error {
+  constructor(public readonly collisions: TaskIdCollision[]) {
+    super(formatDuplicateWebhookIds(collisions));
+
+    this.name = "DuplicateWebhookIdsError";
+  }
+}
+
 export class UnexpectedExitError extends Error {
   constructor(
     public code: number,

packages/core/src/v3/schemas/messages.ts

@@ -43,6 +43,10 @@ export const indexerToWorkerMessages = {
     version: z.literal("v1").default("v1"),
     collisions: z.array(z.object({ id: z.string(), filePaths: z.array(z.string()) })),
   }),
+  WEBHOOKS_FAILED_TO_INDEX: z.object({
+    version: z.literal("v1").default("v1"),
+    collisions: z.array(z.object({ id: z.string(), filePaths: z.array(z.string()) })),
+  }),
   UNCAUGHT_EXCEPTION: UncaughtExceptionMessage,
 };