Merge branch 'feat/dashboard-agent-ui' into feat/dashboard-agent-flows-watch

Author: kathiekiwi

apps/webapp/app/components/dashboard-agent/report-sparkline.tsx

@@ -140,7 +140,11 @@ export function ReportHeadline({
 }) {
   return (
     <p className="flex items-start gap-2 text-sm">
-      <ReportSeverityIcon severity={severity} tone={tone} className="mt-1.5 shrink-0" />
+      <ReportSeverityIcon
+        severity={severity}
+        tone={tone}
+        className={cn("shrink-0", (tone ?? severity) === "warn" ? "mt-1" : "mt-0.5")}
+      />
       <span>
         <span className={cn("font-medium", SEVERITY_TEXT[tone ?? severity])}>{phrase}</span>
         {continuation ? <span className="text-text-bright"> — {continuation}</span> : null}
@@ -170,7 +174,7 @@ export function ReportFindingLine({
     <p className="grid grid-cols-[1rem_4.5rem_minmax(0,1fr)] items-start gap-x-2">
       <ReportSeverityIcon severity={severity} tone={tone} className="mt-0.5" />
       <span className="mt-px text-xs uppercase tracking-wide text-text-dimmed">{type}</span>
-      <span className={cn("-mt-1 text-sm", bright ? "text-text-bright" : "text-text-dimmed")}>
+      <span className={cn("-mt-0.5 text-sm", bright ? "text-text-bright" : "text-text-dimmed")}>
         {text}
       </span>
     </p>

apps/webapp/app/presenters/v3/reports/report-layout.test.ts

@@ -0,0 +1,55 @@
+import { describe, expect, it } from "vitest";
+import { buildReportLayout, type LayoutViewModel } from "./report-layout";
+import { reportMessages } from "./report-messages";
+
+const livenessMetric = {
+  id: "liveness",
+  value: 21 * 60 * 1000,
+  unit: "ms" as const,
+  severity: "crit" as const,
+};
+
+function vmWith(findings: LayoutViewModel["findings"]): LayoutViewModel {
+  return {
+    title: "health",
+    scope: "prod",
+    period: "last 60 min",
+    windowMinutes: 60,
+    summary: { severity: "crit", statements: [] },
+    findings,
+    metrics: [livenessMetric],
+    footer: [],
+  };
+}
+
+const livenessFinding = {
+  type: "liveness",
+  severity: "crit" as const,
+  reason: "stale",
+  metricIds: ["liveness"],
+};
+
+describe("buildReportLayout self-evident findings", () => {
+  it("drops the metric row of a non-hero finding whose only metric is its own line", () => {
+    const layout = buildReportLayout(
+      vmWith([
+        { type: "execution", severity: "crit", reason: "failures_up", metricIds: [] },
+        livenessFinding,
+      ]),
+      reportMessages("health")
+    );
+
+    const liveness = layout.findings.find((f) => f.type === "liveness");
+    expect(liveness?.text).toContain("no telemetry in 21m");
+    expect(liveness?.expanded).toBe(false);
+    expect(liveness?.metrics).toEqual([]);
+  });
+
+  it("keeps the metric row when that finding is the hero", () => {
+    const layout = buildReportLayout(vmWith([livenessFinding]), reportMessages("health"));
+
+    expect(layout.hero?.type).toBe("liveness");
+    expect(layout.hero?.expanded).toBe(true);
+    expect(layout.hero?.metrics.map((m) => m.id)).toEqual(["liveness"]);
+  });
+});

apps/webapp/app/presenters/v3/reports/report-layout.ts

@@ -445,7 +445,12 @@ function findingLayout(
 ): LayoutFinding {
   // A finding whose reason says "we can't say" shows no evidence: the numbers behind it are
   // placeholders. Otherwise the hero is always expanded, and the rest only when degraded.
-  const expanded = !UNASSESSABLE_REASONS.has(finding.reason) && (hero || finding.severity !== "ok");
+  // A self-evident finding's one metric only repeats its own line ("stale — no telemetry in 21m"
+  // over "liveness 21m"); as the hero that line is the headline, so the row is its only evidence.
+  const selfEvident = finding.metricIds.length === 1 && finding.metricIds[0] === finding.type;
+  const expanded =
+    !UNASSESSABLE_REASONS.has(finding.reason) &&
+    (hero || (finding.severity !== "ok" && !selfEvident));
 
   const metrics = expanded
     ? finding.metricIds

apps/webapp/vitest.config.ts

@@ -20,6 +20,7 @@ export default defineConfig({
       "app/utils/**/*.test.ts",
       "app/components/dashboard-agent/**/*.test.ts",
       "app/components/queues/**/*.test.ts",
+      "app/presenters/v3/reports/**/*.test.ts",
     ],
     // *.e2e.test.ts: smoke matrix, run via vitest.e2e.config.ts.
     // *.e2e.full.test.ts: full auth suite, runs via vitest.e2e.full.config.ts