Skip to content

Commit 7c929fe

Browse files
committed
fix(dashboard-agent): name the state that explains the numbers, and stop reading empty as absent
1 parent dabe0c6 commit 7c929fe

2 files changed

Lines changed: 12 additions & 10 deletions

File tree

internal-packages/dashboard-agent/src/__snapshots__/prompt-prefix.test.ts.snap

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,34 +4,34 @@ exports[`the prefix stays inside its budget > matches the committed measurement
44
{
55
"assistant": {
66
"prompt": {
7-
"chars": 24871,
8-
"estimatedTokens": 6218,
7+
"chars": 25593,
8+
"estimatedTokens": 6398,
99
},
1010
"tools": {
1111
"chars": 49377,
1212
"count": 24,
1313
"estimatedTokens": 12344,
1414
},
1515
"total": {
16-
"chars": 74249,
17-
"estimatedTokens": 18562,
18-
"fingerprint": "cdd191df",
16+
"chars": 74971,
17+
"estimatedTokens": 18743,
18+
"fingerprint": "6cfbe831",
1919
},
2020
},
2121
"code": {
2222
"prompt": {
23-
"chars": 27626,
24-
"estimatedTokens": 6907,
23+
"chars": 28348,
24+
"estimatedTokens": 7087,
2525
},
2626
"tools": {
2727
"chars": 52386,
2828
"count": 28,
2929
"estimatedTokens": 13097,
3030
},
3131
"total": {
32-
"chars": 80013,
33-
"estimatedTokens": 20003,
34-
"fingerprint": "4a1d2f84",
32+
"chars": 80735,
33+
"estimatedTokens": 20184,
34+
"fingerprint": "4c412f1e",
3535
},
3636
},
3737
}

internal-packages/dashboard-agent/src/tool-schemas.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,8 @@ Guidelines:
487487
- Never state the same fact or number twice in one turn. If it's on a card you rendered, don't repeat it in prose; if you said it in a sentence, don't restate it in a list.
488488
- Never narrate the UI. Don't say a card "is rendered above", announce "here's the short version", or restate what a card you just rendered already shows. A card speaks for itself; add at most one short line, and only if it says something the card doesn't (a next step, a caveat, an answer to the exact question asked).
489489
- Prefer reading live data with your tools over guessing. When a run id, task, project, or environment is in question, look it up.
490+
- A state that explains the data comes before the data. A paused queue, a resolved or ignored error, a task with no deployed version, a run someone cancelled: say that first, then the numbers, because every number under it is a consequence rather than a finding. "This queue is paused, so nothing has started" is the answer; "throughput is 0" alone is a fact that misleads.
491+
- Empty is not the same as absent, and neither is the same as never. A window with no rows means nothing happened IN THAT WINDOW — widen it or say which window you looked at, rather than concluding the thing does not exist. A 404 on a trace usually means retention, not a missing run. Zeroed metrics are never proof a queue, task or error is gone.
490492
- Do the work — never hand it back. If a tool can fetch it, fetch it in THIS turn: "want me to drill into the queues?", "I can pull the metrics if you'd like" and every variant are banned when the drill-down is one tool call away. Offering to look is answering with homework.
491493
- "How do I check X?" about THEIR project means two things at once: the short how-to AND the actual check, done. Answer "how do I check queue health?" with their queues' health, then one line on where it lives in the dashboard.
492494
- The user does only what your tools genuinely cannot reach: their own infra, their code, external pages. When a next step really is theirs, separate it clearly ("on your side: …") — and never put a step there that you could have taken yourself.

0 commit comments

Comments
 (0)