Skip to content

Commit 6e9bda0

Browse files
d-csclaude
andcommitted
chore(run-ops split): strip plan-enumeration labels from replication comments/test names
Remove the internal plan-enumeration labels from runs-replication comments and test names, keeping the behavioral descriptions intact. Comment/label hygiene only; no product logic or test behavior changed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 29a7ea0 commit 6e9bda0

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

apps/webapp/app/services/runsReplicationInstance.server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ function initializeRunsReplicationInstance() {
151151
]);
152152

153153
if (env.RUN_REPLICATION_ENABLED === "1") {
154-
// Shape B (construct-after-gate): resolve the async split gate ONCE at boot, and
154+
// Construct-after-gate: resolve the async split gate ONCE at boot, and
155155
// when both sources are enabled rebuild `service` with sources[] before starting.
156156
// The legacy-only instance above is never started in the dual path (no slot/lock
157157
// taken). runsReplicationService.server.ts is untouched. The create route also calls

apps/webapp/test/runsReplicationService.part8.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ describe("RunsReplicationService (part 8/8) - dual-source dedup", () => {
194194
}
195195
);
196196

197-
// Case A - reverse-order independence (Step 4.1).
197+
// Case A - reverse-order independence.
198198
// Same run in both sources, but we flush the NEW (gen-1) snapshot FIRST, then the LEGACY
199199
// (gen-0) snapshot. The gen-1 winner must survive regardless of arrival order - the collapse
200200
// is FINAL-time and ordered by _version (composed origin generation), not by arrival time.
@@ -362,7 +362,7 @@ describe("RunsReplicationService (part 8/8) - dual-source dedup", () => {
362362
}
363363
);
364364

365-
// Case B - per-source independence / no cross-contamination (Step 4.2).
365+
// Case B - per-source independence / no cross-contamination.
366366
// Two DIFFERENT runs: run X lives ONLY in the legacy/gen-0 DB, run Y lives ONLY in the
367367
// new/gen-1 DB. BOTH must appear in ClickHouse exactly once with their own status. This proves
368368
// (a) BOTH sources became leader and streamed (a single-leader regression would drop one run),

apps/webapp/test/runsReplicationService.part9.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ describe("RunsReplicationService (part 9/9) - per-source replication-lag attribu
200200
}
201201
);
202202

203-
// Step 1.4: single-source passthrough. When a single source is used, the lag
203+
// Single-source passthrough. When a single source is used, the lag
204204
// histogram records exactly one `source` label value (the source's id).
205205
replicationContainerTest(
206206
"records a single source label in single-source mode",

0 commit comments

Comments
 (0)