fix(webapp): show the first webhook delivery in the live feed without a reload

The deliveries live feed no longer stops polling while the list is empty, so the first delivery appears on its own instead of only after a manual refresh. The new-delivery watermark is already seeded when the list is empty, so polling an empty list is safe.

Author: ericallam

apps/webapp/app/components/webhookDeliveries/v1/useDeliveriesLiveReload.ts

@@ -61,11 +61,9 @@ function isNewDeliveriesCheckTick(tick: number) {
 
 function useNewDeliveriesDetection({
   deliveries,
-  hasAnyDeliveries,
   isLoading,
 }: {
   deliveries: ListedDelivery[];
-  hasAnyDeliveries: boolean;
   isLoading: boolean;
 }) {
   const pollTickRef = useRef(0);
@@ -74,7 +72,7 @@ function useNewDeliveriesDetection({
   );
   const [newDeliveriesCount, setNewDeliveriesCount] = useState(0);
 
-  const shouldPollForNewDeliveries = hasAnyDeliveries && !isLoading && newDeliveriesCount < 100;
+  const shouldPollForNewDeliveries = !isLoading && newDeliveriesCount < 100;
 
   const resetNewDeliveriesTracking = useCallback(() => {
     setKnownNewestDeliveryMs(maxCreatedAtMs(deliveries) ?? Date.now());
@@ -109,15 +107,13 @@ function useNewDeliveriesDetection({
 
 export function useDeliveriesLiveReload({
   deliveries,
-  hasAnyDeliveries,
   isLoading,
   webhookEndpointId,
   organizationSlug,
   projectSlug,
   environmentSlug,
 }: {
   deliveries: ListedDelivery[];
-  hasAnyDeliveries: boolean;
   isLoading: boolean;
   /** Omit to poll across every endpoint in the environment (the cross-endpoint deliveries list). */
   webhookEndpointId?: string;
@@ -141,7 +137,7 @@ export function useDeliveriesLiveReload({
     dismissNewDeliveries,
     checkNewDeliveriesOnTick,
     resetNewDeliveriesTracking,
-  } = useNewDeliveriesDetection({ deliveries, hasAnyDeliveries, isLoading });
+  } = useNewDeliveriesDetection({ deliveries, isLoading });
 
   useEffect(() => {
     setVisibleDeliveries(deliveries);

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.webhooks.$webhookParam/route.tsx

@@ -491,7 +491,6 @@ function LiveDeliveriesTable({
   const { visibleDeliveries, showNewDeliveriesBanner, newDeliveriesCount, dismissNewDeliveries } =
     useDeliveriesLiveReload({
       deliveries: list.deliveries,
-      hasAnyDeliveries: list.deliveries.length > 0,
       isLoading: navigation.state !== "idle",
       webhookEndpointId,
       organizationSlug: organization.slug,
@@ -592,7 +591,6 @@ function ConsoleFeedList({
   const { visibleDeliveries, showNewDeliveriesBanner, newDeliveriesCount, dismissNewDeliveries } =
     useDeliveriesLiveReload({
       deliveries: list.deliveries,
-      hasAnyDeliveries: list.deliveries.length > 0,
       isLoading: navigation.state !== "idle",
       webhookEndpointId,
       organizationSlug: organization.slug,

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.webhooks._index/route.tsx

@@ -194,7 +194,6 @@ function useLiveDeliveries(deliveries: WebhookDeliveryListItem[]) {
   const { visibleDeliveries, showNewDeliveriesBanner, newDeliveriesCount, dismissNewDeliveries } =
     useDeliveriesLiveReload({
       deliveries,
-      hasAnyDeliveries: deliveries.length > 0,
       isLoading: navigation.state !== "idle",
       organizationSlug: organization.slug,
       projectSlug: project.slug,