chore(run-ops split): strip review-scaffolding comments/labels from pr09 presenters

Comment/label hygiene pass over the PR09 presenter read-routing work. No
product logic, assertions, seeds, or test structure changed — only comment
text and test/it titles.

- Remove the SPLIT-NEUTRAL scaffolding comment on TaskDetailPresenter.getActivity.
- Drop `// --- ... ---` comment fencing across the touched test files, keeping
  the behavioral text.
- Strip Task/Step enumeration prefixes from comments and it/test titles, keeping
  the behavioral descriptions.
- Remove Definition-of-Done ("DoD") framing and RED/GREEN TDD phase commentary.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: d-cs

apps/webapp/app/presenters/v3/TaskDetailPresenter.server.ts

@@ -141,8 +141,6 @@ export class TaskDetailPresenter {
     };
   }
 
-  // SPLIT-NEUTRAL: served entirely from ClickHouse (task_runs_v2);
-  // no run-ops Postgres read — single-DB behavior is n-a, RoutingRunStore is not involved.
   async getActivity({
     organizationId,
     projectId,

apps/webapp/test/SpanPresenter.readthrough.test.ts

@@ -208,8 +208,8 @@ function asReplica(prisma: PrismaClient): PrismaClient {
 }
 
 describe("SpanPresenter run-ops/control-plane partition (legacy + new)", () => {
-  // --- Span detail resolves run + children through the run-ops store, region/schedule/session
-  //         on control-plane, no cross-DB join. ---
+  // Span detail resolves run + children through the run-ops store, region/schedule/session
+  // on control-plane, no cross-DB join.
   heteroPostgresTest(
     "findRun hydrates the run through the run-ops store (new-first) and the children-by-parentSpanId set; region/schedule/session resolve from the control-plane client",
     async ({ prisma14, prisma17 }) => {
@@ -297,7 +297,7 @@ describe("SpanPresenter run-ops/control-plane partition (legacy + new)", () => {
     }
   );
 
-  // --- Children set served by runStore.findRuns through the routing store ---
+  // Children set served by runStore.findRuns through the routing store.
   heteroPostgresTest(
     "triggeredRuns (children-by-parentSpanId) is served by runStore.findRuns with the presenter's exact select",
     async ({ prisma14, prisma17 }) => {
@@ -344,7 +344,7 @@ describe("SpanPresenter run-ops/control-plane partition (legacy + new)", () => {
     }
   );
 
-  // --- Old in-retention run served from the legacy replica, never the primary ---
+  // Old in-retention run served from the legacy replica, never the primary.
   heteroPostgresTest(
     "a legacy-residency run resolves through the store's LEGACY slot, which exposes only a replica handle",
     async ({ prisma14, prisma17 }) => {
@@ -377,7 +377,7 @@ describe("SpanPresenter run-ops/control-plane partition (legacy + new)", () => {
     }
   );
 
-  // --- A known-migrated run is not re-probed on legacy ---
+  // A known-migrated run is not re-probed on legacy.
   heteroPostgresTest(
     "a NEW-residency id is served by the NEW slot and the LEGACY slot is never invoked",
     async ({ prisma14, prisma17 }) => {
@@ -417,7 +417,7 @@ describe("SpanPresenter run-ops/control-plane partition (legacy + new)", () => {
     }
   );
 
-  // --- Passthrough (single-DB): NEW and LEGACY slots are the same store over one client ---
+  // Passthrough (single-DB): NEW and LEGACY slots are the same store over one client.
   heteroPostgresTest(
     "single-DB collapses both slots to one PostgresRunStore; the presenter resolves run + children + control-plane from the one client",
     async ({ prisma14 }) => {
@@ -484,7 +484,7 @@ describe("SpanPresenter run-ops/control-plane partition (legacy + new)", () => {
     }
   );
 
-  // --- Cross-seam tree shape: parent on LEGACY (in-retention), child on NEW (born-new) ---
+  // Cross-seam tree shape: parent on LEGACY (in-retention), child on NEW (born-new).
   heteroPostgresTest(
     "parent run on the legacy replica, child run on new — relations resolve across the seam, no cross-DB join",
     async ({ prisma14, prisma17 }) => {

apps/webapp/test/apiRetrieveRunPresenter.readroute.test.ts

@@ -227,9 +227,9 @@ async function seedAttempt(
   });
 }
 
-// Seed a run plus a parent, a root, a child and one attempt — the tree the DoD
-// asserts round-trips. `seedTestRun.ts` only seeds a single root run, so the
-// tree + attempt rows are created inline here (per the plan's seeding note).
+// Seed a run plus a parent, a root, a child and one attempt — the tree that must
+// round-trip. `seedTestRun.ts` only seeds a single root run, so the tree + attempt
+// rows are created inline here.
 async function seedRunWithTree(
   prisma: PrismaClient,
   base: {

apps/webapp/test/apiRunListPresenter.test.ts

@@ -188,7 +188,7 @@ async function createRun(
 }
 
 describe("ApiRunListPresenter public /runs list (PG14 legacy + PG17 new)", () => {
-  // Step 1 + Step 6 (e2e #6): public list serves run-ops rows through the routed store. The
+  // Public list serves run-ops rows through the routed store. The
   // forwarded readThroughDeps thread the dual-DB union into NextRunListPresenter; the public
   // payload (`{ data, pagination }`) must list the NEW ∪ legacy union, proving the public API
   // surfaces routed run-ops rows. The migrated/straggler rows (run_newA/run_newB) live on BOTH
@@ -281,7 +281,7 @@ describe("ApiRunListPresenter public /runs list (PG14 legacy + PG17 new)", () =>
     }
   );
 
-  // Step 2: genuinely-empty env returns { data: [], pagination } without error. Exercises the
+  // Genuinely-empty env returns { data: [], pagination } without error. Exercises the
   // empty-state probe beneath NextRunListPresenter (no rows on either DB; empty CH page).
   replicationContainerTest(
     "genuinely-empty env returns { data: [], pagination } without error",
@@ -326,7 +326,7 @@ describe("ApiRunListPresenter public /runs list (PG14 legacy + PG17 new)", () =>
     }
   );
 
-  // Step 3 / DoD "env scoping unchanged": the control-plane runtimeEnvironment.findMany lookup
+  // Env scoping unchanged: the control-plane runtimeEnvironment.findMany lookup
   // resolves the requested env via the `_replica` handle (NOT routed), with the 4th `environment`
   // arg omitted to force that branch. Result is scoped to the requested env only.
   replicationContainerTest(
@@ -370,7 +370,7 @@ describe("ApiRunListPresenter public /runs list (PG14 legacy + PG17 new)", () =>
     }
   );
 
-  // Step 4 / DoD "passthrough (single-DB)": two-arg-style construction (no readThroughDeps) ->
+  // Passthrough (single-DB): two-arg-style construction (no readThroughDeps) ->
   // NextRunListPresenter receives undefined deps -> byte-identical single-DB path. The public
   // { data, pagination } shape is unchanged.
   replicationContainerTest(

apps/webapp/test/batchListPresenter.readroute.test.ts

@@ -226,7 +226,7 @@ function spyClient(
 const desc = (a: string, b: string) => (a < b ? 1 : a > b ? -1 : 0);
 
 describe("BatchListPresenter run-ops read routing (PG14 control-plane/legacy + PG17 new)", () => {
-  // --- Task 3 Step 1: byte-identical scan + identical ORDER-BY across PG14/PG17 ---
+  // Byte-identical scan + identical ORDER-BY across PG14/PG17.
   heteroPostgresTest(
     "raw paginated scan is byte-identical and identically ordered across PG14 and PG17 (both directions, with/without cursor)",
     async ({ prisma14, prisma17 }) => {
@@ -292,7 +292,7 @@ describe("BatchListPresenter run-ops read routing (PG14 control-plane/legacy + P
     }
   );
 
-  // --- Task 3 Step 2: split scan merge serves new + legacy in one keyset-ordered page ---
+  // Split scan merge serves new + legacy in one keyset-ordered page.
   heteroPostgresTest(
     "split scan merges new (PG17) + legacy (PG14) rows under the keyset order; legacy read only when new does not fill the page",
     async ({ prisma14, prisma17 }) => {
@@ -338,7 +338,7 @@ describe("BatchListPresenter run-ops read routing (PG14 control-plane/legacy + P
     }
   );
 
-  // --- Task 3 Step 3: project resolves on control-plane; no cross-seam join ---
+  // Project resolves on control-plane; no cross-seam join.
   heteroPostgresTest(
     "project resolves on the control-plane handle (PG14); BatchTaskRun scan reads run-ops only",
     async ({ prisma14, prisma17 }) => {
@@ -367,7 +367,7 @@ describe("BatchListPresenter run-ops read routing (PG14 control-plane/legacy + P
     }
   );
 
-  // --- Task 3 Step 4: empty-state probe is dual-DB during the window ---
+  // Empty-state probe is dual-DB during the window.
   heteroPostgresTest(
     "empty-state probe reads new then legacy replica: true when legacy has a batch, false when both empty",
     async ({ prisma14, prisma17 }) => {
@@ -396,7 +396,7 @@ describe("BatchListPresenter run-ops read routing (PG14 control-plane/legacy + P
     }
   );
 
-  // --- Task 3 Step 5: single-DB passthrough collapses to one handle ---
+  // Single-DB passthrough collapses to one handle.
   postgresTest(
     "passthrough (no readRoute): scan + probe + project all read the single handle; legacy closures never invoked",
     async ({ prisma }) => {
@@ -434,7 +434,6 @@ describe("BatchListPresenter run-ops read routing (PG14 control-plane/legacy + P
     }
   );
 
-  // RED before fix: $queryRaw across clients → P2010/42601 "$1". GREEN after: typed findMany.
   heteroRunOpsPostgresTest(
     "scan against dedicated RunOpsPrismaClient (splitEnabled): returns batches from new DB",
     async ({ prisma14, prisma17 }) => {

apps/webapp/test/batchPresenter.test.ts

@@ -137,7 +137,7 @@ function makeEnvResolver(controlPlane: PrismaClient) {
 }
 
 describe("BatchPresenter read-through (PG14 legacy + PG17 new)", () => {
-  // DoD: batch detail resolves on run-ops NEW (split on). Legacy replica is never probed.
+  // Batch detail resolves on run-ops NEW (split on). Legacy replica is never probed.
   heteroPostgresTest(
     "resolves a NEW-resident batch and never probes the legacy replica",
     async ({ prisma14, prisma17 }) => {
@@ -182,7 +182,7 @@ describe("BatchPresenter read-through (PG14 legacy + PG17 new)", () => {
     }
   );
 
-  // DoD: batch detail resolves on run-ops OLD/legacy READ REPLICA (split on, in-retention).
+  // Batch detail resolves on run-ops OLD/legacy READ REPLICA (split on, in-retention).
   // Cross-version round-trip: PG14 legacy -> presenter, JSON error payload byte-identical.
   heteroPostgresTest(
     "resolves a legacy-only batch via the legacy READ REPLICA, byte-identical",
@@ -239,7 +239,7 @@ describe("BatchPresenter read-through (PG14 legacy + PG17 new)", () => {
     }
   );
 
-  // DoD: post-termination / not-found yields the normal "Batch not found".
+  // Post-termination / not-found yields the normal "Batch not found".
   heteroPostgresTest(
     "throws the normal not-found when the batch is absent from both stores",
     async ({ prisma14, prisma17 }) => {
@@ -259,7 +259,7 @@ describe("BatchPresenter read-through (PG14 legacy + PG17 new)", () => {
     }
   );
 
-  // DoD: env decoupling parity for a DEVELOPMENT env (userName branch).
+  // Env decoupling parity for a DEVELOPMENT env (userName branch).
   heteroPostgresTest(
     "resolves the DEVELOPMENT env userName separately from the run-ops batch row",
     async ({ prisma14, prisma17 }) => {
@@ -287,7 +287,7 @@ describe("BatchPresenter read-through (PG14 legacy + PG17 new)", () => {
 });
 
 describe("BatchPresenter single-DB passthrough", () => {
-  // DoD passthrough line + self-host collapse: one plain read, legacy closure never invoked.
+  // Passthrough + self-host collapse: one plain read, legacy closure never invoked.
   containerTest(
     "single-DB resolves the batch with one plain read and never touches the legacy boundary",
     async ({ prisma }) => {

apps/webapp/test/nextRunListPresenter.readthrough.test.ts

@@ -172,9 +172,9 @@ function throwingFindFirst(prisma: PrismaClient, label: string): PrismaClient {
 const callOptions = (ctx: SeedContext) => ({ projectId: ctx.projectId, pageSize: 10 });
 
 describe("NextRunListPresenter dual-DB empty-state probe + routed hydrate (legacy + new Postgres)", () => {
-  // --- no-false-empty. Runs ONLY on legacy, none on new. Empty CH page -> listRuns returns [].
+  // no-false-empty. Runs ONLY on legacy, none on new. Empty CH page -> listRuns returns [].
   // splitEnabled true. The probe misses NEW, falls through to the legacy replica and finds the
-  // row, so the dashboard must NOT show "no runs". ---
+  // row, so the dashboard must NOT show "no runs".
   replicationContainerTest(
     "no-false-empty: runs only on the legacy replica still report hasAnyRuns true",
     async ({ clickhouseContainer, redisOptions, postgresContainer, prisma, network }) => {
@@ -217,10 +217,10 @@ describe("NextRunListPresenter dual-DB empty-state probe + routed hydrate (legac
     }
   );
 
-  // --- new-DB short-circuit. A run on NEW, legacy replica wrapped so its taskRun.findFirst
+  // new-DB short-circuit. A run on NEW, legacy replica wrapped so its taskRun.findFirst
   // throws. Empty CH page. The probe answers from NEW and must NEVER fall through to legacy. The
   // post-migration straggler is the same shape: present on NEW, absent from LEGACY, legacy never
-  // invoked. ---
+  // invoked.
   replicationContainerTest(
     "new-DB short-circuit: hasAnyRuns answered from the new DB without touching the legacy replica",
     async ({ clickhouseContainer, redisOptions, postgresContainer, prisma, network }) => {
@@ -263,8 +263,8 @@ describe("NextRunListPresenter dual-DB empty-state probe + routed hydrate (legac
     }
   );
 
-  // --- genuinely empty. Nothing on either DB. Empty CH page. splitEnabled true. Both
-  // probes run and return null -> the true empty state is preserved. ---
+  // genuinely empty. Nothing on either DB. Empty CH page. splitEnabled true. Both
+  // probes run and return null -> the true empty state is preserved.
   replicationContainerTest(
     "genuinely empty: both DBs empty reports hasAnyRuns false",
     async ({ clickhouseContainer, redisOptions, postgresContainer, prisma, network }) => {
@@ -301,11 +301,11 @@ describe("NextRunListPresenter dual-DB empty-state probe + routed hydrate (legac
     }
   );
 
-  // --- passthrough single-DB (two-arg ctor). One `prisma`, seed a run, empty CH page.
+  // passthrough single-DB (two-arg ctor). One `prisma`, seed a run, empty CH page.
   // splitEnabled defaults false -> exactly one plain findFirst against the single handle; the
   // split branch (new/legacy) is structurally never entered (no second handle is injected).
   // Also covers "served from the replica only" — the ctor exposes no legacy-writer field, so a
-  // no-primary-read guarantee is structural. ---
+  // no-primary-read guarantee is structural.
   replicationContainerTest(
     "passthrough single-DB: two-arg ctor finds the run via the single handle",
     async ({ clickhouseContainer, redisOptions, postgresContainer, prisma }) => {
@@ -332,15 +332,15 @@ describe("NextRunListPresenter dual-DB empty-state probe + routed hydrate (legac
     }
   );
 
-  // --- list hydrate flows through the routed store: split, non-empty CH id-set whose rows are
+  // list hydrate flows through the routed store: split, non-empty CH id-set whose rows are
   // split across NEW + the legacy replica. result.runs must be the union, id-desc ordered. This
   // proves the deps are threaded so the routed store is actually used.
   // We assert the rows that DO surface (the full union, since legacy is probed for any id that
   // misses on NEW).
   // The migrated runs (run_newA/run_newB) live on BOTH DBs with the same id + friendlyId but a
   // DISTINGUISHING taskIdentifier: "my-task" on legacy, "my-task-NEW" on new. #hydrateRunsByIds
   // takes NEW rows first and only probes legacy for ids NOT on NEW, so a migrated row can only
-  // carry "my-task-NEW" if it was served from the threaded newClient (new DB) — asserted below. ---
+  // carry "my-task-NEW" if it was served from the threaded newClient (new DB) — asserted below.
   replicationContainerTest(
     "list hydrate flows through the routed store: result.runs is the NEW + legacy union, id-desc",
     async ({ clickhouseContainer, redisOptions, postgresContainer, prisma, network }) => {

apps/webapp/test/presenters/TestTaskPresenter.readthrough.test.ts

@@ -202,7 +202,7 @@ function throwingLegacyReplica(prisma: PrismaClient): PrismaClient {
 }
 
 describe("TestTaskPresenter recent-payloads read-through (PG14 legacy + PG17 new)", () => {
-  // --- DoD line + payloadType parity: split union of NEW + legacy-replica, JSON-only, createdAt desc ---
+  // payloadType parity: split union of NEW + legacy-replica, JSON-only, createdAt desc.
   replicationContainerTest(
     "split mode hydrates the 10-most-recent CH id-set as the union of NEW + legacy-replica rows, payloadType filtered, createdAt desc",
     async ({ clickhouseContainer, redisOptions, postgresContainer, prisma, network }) => {
@@ -312,7 +312,7 @@ describe("TestTaskPresenter recent-payloads read-through (PG14 legacy + PG17 new
     }
   );
 
-  // --- Old in-retention run served from the legacy READ REPLICA only (no legacyWriter field exists) ---
+  // Old in-retention run served from the legacy READ REPLICA only (no legacyWriter field exists).
   replicationContainerTest(
     "an in-retention legacy-only run hydrates from the legacy replica handle",
     async ({ clickhouseContainer, redisOptions, postgresContainer, prisma, network }) => {
@@ -369,7 +369,7 @@ describe("TestTaskPresenter recent-payloads read-through (PG14 legacy + PG17 new
     }
   );
 
-  // --- Passthrough (single-DB): one plain store read, the legacy replica never touched ---
+  // Passthrough (single-DB): one plain store read, the legacy replica never touched.
   replicationContainerTest(
     "single-DB passthrough hydrates from one store read and never touches the legacy replica",
     async ({ clickhouseContainer, redisOptions, postgresContainer, prisma }) => {
@@ -428,7 +428,7 @@ describe("TestTaskPresenter recent-payloads read-through (PG14 legacy + PG17 new
     }
   );
 
-  // --- SCHEDULED-source parity: same hydrate path, ScheduledRun mapping exercised ---
+  // SCHEDULED-source parity: same hydrate path, ScheduledRun mapping exercised.
   replicationContainerTest(
     "SCHEDULED task: split union parses to ScheduledRun shape identically to single-DB",
     async ({ clickhouseContainer, redisOptions, postgresContainer, prisma, network }) => {

apps/webapp/test/realtime/clickHouseRunListResolver.test.ts

@@ -130,7 +130,7 @@ function throwingTaskRunFindMany(prisma: PrismaClient): PrismaClient {
 }
 
 describe("ClickHouseRunListResolver (realtime run-list id-set, split-neutral)", () => {
-  // --- resolves the CH id-set with NO TaskRun PG hydrate ---
+  // resolves the CH id-set with NO TaskRun PG hydrate.
   replicationContainerTest(
     "resolves the ClickHouse id-set for run-ops rows without ever reading TaskRun in Postgres",
     async ({ clickhouseContainer, redisOptions, postgresContainer, prisma }) => {
@@ -168,7 +168,7 @@ describe("ClickHouseRunListResolver (realtime run-list id-set, split-neutral)",
     }
   );
 
-  // --- CH filter is split-neutral (ids independent of PG residency) ---
+  // CH filter is split-neutral (ids independent of PG residency).
   replicationContainerTest(
     "returns the same id-set regardless of which Postgres the rows are hydrated from (CH-only path)",
     async ({ clickhouseContainer, redisOptions, postgresContainer, prisma, network }) => {
@@ -223,7 +223,7 @@ describe("ClickHouseRunListResolver (realtime run-list id-set, split-neutral)",
     }
   );
 
-  // --- single-DB passthrough; no legacy/known-migrated probe on this path ---
+  // single-DB passthrough; no legacy/known-migrated probe on this path.
   replicationContainerTest(
     "single-DB passthrough returns the CH id-set and never hydrates TaskRun",
     async ({ clickhouseContainer, redisOptions, postgresContainer, prisma }) => {
@@ -255,7 +255,7 @@ describe("ClickHouseRunListResolver (realtime run-list id-set, split-neutral)",
     }
   );
 
-  // --- a far-future straggler's id surfaces from the CH id-set ---
+  // a far-future straggler's id surfaces from the CH id-set.
   replicationContainerTest(
     "surfaces a far-future delayed run's id from the CH id-set",
     async ({ clickhouseContainer, redisOptions, postgresContainer, prisma }) => {
@@ -299,7 +299,7 @@ describe("ClickHouseRunListResolver (realtime run-list id-set, split-neutral)",
     }
   );
 
-  // --- tag match is contains-ALL (tagsMatch: "all" -> hasAll), authoritative ---
+  // tag match is contains-ALL (tagsMatch: "all" -> hasAll), authoritative.
   // The sibling runReader.server.ts JSDoc still calls RunListFilter.tags "Contains-ANY"; that is
   // stale. The resolver passes tagsMatch: "all" and the live CH repo maps
   // it to hasAll, so contains-ALL is the real behavior — assert that, not the JSDoc.
@@ -345,7 +345,7 @@ describe("ClickHouseRunListResolver (realtime run-list id-set, split-neutral)",
     }
   );
 
-  // --- environment scoping: the CH filter excludes other environments ---
+  // environment scoping: the CH filter excludes other environments.
   // Doubles as a structural proof that an accidental hydrate would NOT change the id-set: rows on a
   // different env are not returned because CH filters by environment_id, not because PG was read.
   replicationContainerTest(