Skip to content

Commit 5490e38

Browse files
d-csclaude
andcommitted
chore(run-ops): fix lint/format for main lint rules
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent a5a89c5 commit 5490e38

9 files changed

Lines changed: 20 additions & 22 deletions

File tree

apps/webapp/app/runEngine/services/createBatch.server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import type { InitializeBatchOptions } from "@internal/run-engine";
22
import { type CreateBatchRequestBody, type CreateBatchResponse } from "@trigger.dev/core/v3";
3-
import { BatchId, RunId } from "@trigger.dev/core/v3/isomorphic";
3+
import { RunId } from "@trigger.dev/core/v3/isomorphic";
44
import { type BatchTaskRun, Prisma } from "@trigger.dev/database";
55
import { Evt } from "evt";
66
import { prisma, type PrismaClientOrTransaction } from "~/db.server";

apps/webapp/app/runEngine/services/triggerTask.server.test.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,11 @@ import { RunEngine } from "@internal/run-engine";
2828
import { setupAuthenticatedEnvironment, setupBackgroundWorker } from "@internal/run-engine/tests";
2929
import { assertNonNullable, containerTest } from "@internal/testcontainers";
3030
import { trace } from "@opentelemetry/api";
31-
import { IOPacket } from "@trigger.dev/core/v3";
32-
import { RunId } from "@trigger.dev/core/v3/isomorphic";
33-
import { TaskRun } from "@trigger.dev/database";
31+
import type { IOPacket } from "@trigger.dev/core/v3";
32+
import type { TaskRun } from "@trigger.dev/database";
3433
import { IdempotencyKeyConcern } from "~/runEngine/concerns/idempotencyKeys.server";
3534
import { DefaultQueueManager } from "~/runEngine/concerns/queues.server";
36-
import {
35+
import type {
3736
EntitlementValidationParams,
3837
MaxAttemptsValidationParams,
3938
ParentRunValidationParams,

apps/webapp/app/services/runsRepository/runsRepository.server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { type Prisma, TaskRunStatus } from "@trigger.dev/database";
88
import parseDuration from "parse-duration";
99
import { z } from "zod";
1010
import { timeFilters } from "~/components/runs/v3/SharedFilters";
11-
import { type PrismaClient, type PrismaClientOrTransaction } from "~/db.server";
11+
import { type PrismaClientOrTransaction } from "~/db.server";
1212
import { runStore as defaultRunStore } from "~/v3/runStore.server";
1313
import { startActiveSpan } from "~/v3/tracer.server";
1414
import { ClickHouseRunsRepository } from "./clickhouseRunsRepository.server";

apps/webapp/app/v3/services/alerts/deliverAlert.server.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,9 @@ import { generateFriendlyId } from "~/v3/friendlyIdentifiers";
5050
import { fromPromise } from "neverthrow";
5151
import { BaseService } from "../baseService.server";
5252
import { CURRENT_API_VERSION } from "~/api/versions";
53-
import {
54-
ControlPlaneResolver,
55-
controlPlaneResolver as defaultControlPlaneResolver,
56-
} from "~/v3/runOpsMigration/controlPlaneResolver.server";
53+
import type { RunStore } from "@internal/run-store";
54+
import type { ControlPlaneResolver } from "~/v3/runOpsMigration/controlPlaneResolver.server";
55+
import { controlPlaneResolver as defaultControlPlaneResolver } from "~/v3/runOpsMigration/controlPlaneResolver.server";
5756

5857
// Run-ops scalars read off `alert.taskRun` downstream. The control-plane fields (env type/branch,
5958
// lockedBy file/export, lockedToVersion version) are resolved via the resolver and stitched on
@@ -137,7 +136,7 @@ export class DeliverAlertService extends BaseService {
137136
opts: {
138137
prisma?: PrismaClientOrTransaction;
139138
replica?: PrismaClientOrTransaction;
140-
runStore?: import("@internal/run-store").RunStore;
139+
runStore?: RunStore;
141140
controlPlaneResolver?: ControlPlaneResolver;
142141
} = {}
143142
) {

apps/webapp/app/v3/services/alerts/performTaskRunAlerts.server.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,8 @@ import { type RunStore } from "@internal/run-store";
22
import { type Prisma, type ProjectAlertChannel } from "@trigger.dev/database";
33
import { type PrismaClientOrTransaction, type prisma } from "~/db.server";
44
import { alertsWorker } from "~/v3/alertsWorker.server";
5-
import {
6-
ControlPlaneResolver,
7-
controlPlaneResolver as defaultControlPlaneResolver,
8-
} from "~/v3/runOpsMigration/controlPlaneResolver.server";
5+
import type { ControlPlaneResolver } from "~/v3/runOpsMigration/controlPlaneResolver.server";
6+
import { controlPlaneResolver as defaultControlPlaneResolver } from "~/v3/runOpsMigration/controlPlaneResolver.server";
97
import { BaseService } from "../baseService.server";
108
import { DeliverAlertService } from "./deliverAlert.server";
119

apps/webapp/test/performTaskRunAlertsStoreRouting.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ describe("PerformTaskRunAlertsService store routing (hetero)", () => {
231231
);
232232

233233
// Org/project/env + a PARENT env + the alert channel are control-plane → the control-plane DB.
234-
const { project, organization, runtimeEnvironment } = await seedProject(prisma14, "cp");
234+
const { project, organization } = await seedProject(prisma14, "cp");
235235
// A branch env whose parent type drives the channel filter (parentEnvironmentType ?? type).
236236
const parentEnv = await prisma14.runtimeEnvironment.create({
237237
data: {

apps/webapp/test/runsRepositoryCpres.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ vi.mock("~/db.server", () => ({
1212
import { heteroRunOpsPostgresTest } from "@internal/testcontainers";
1313
import { buildRunStore } from "~/v3/runStore.server";
1414
import type { RunOpsPrismaClient } from "@internal/run-ops-database";
15-
import { PrismaClient } from "@trigger.dev/database";
15+
import type { PrismaClient } from "@trigger.dev/database";
1616
import { BulkActionId, RunId } from "@trigger.dev/core/v3/isomorphic";
1717
import { convertRunListInputOptionsToFilterRunsOptions } from "~/services/runsRepository/runsRepository.server";
1818

apps/webapp/test/sessions.readthrough.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { heteroRunOpsPostgresTest, postgresTest } from "@internal/testcontainers
1313
import { buildRunStore } from "~/v3/runStore.server";
1414
import { generateKsuidId } from "@trigger.dev/core/v3/isomorphic";
1515
import type { RunOpsPrismaClient } from "@internal/run-ops-database";
16-
import { PrismaClient } from "@trigger.dev/database";
16+
import type { PrismaClient } from "@trigger.dev/database";
1717
import {
1818
resolveSessionByIdOrExternalId,
1919
serializeSessionsWithFriendlyRunIds,

apps/webapp/test/setup.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import { config } from "dotenv";
44
import path from "node:path";
55
import { vi } from "vitest";
6+
import type * as IORedisModule from "ioredis";
7+
import type * as TaskMetadataCacheModule from "~/services/taskMetadataCache.server";
68

79
config({ path: path.resolve(__dirname, "../.env") });
810

@@ -56,7 +58,7 @@ const noopProxy = () =>
5658
// command (tests against live testcontainers) connects on first command
5759
// exactly as before.
5860
vi.mock("ioredis", async (importOriginal) => {
59-
const actual = await importOriginal<typeof import("ioredis")>();
61+
const actual = await importOriginal<typeof IORedisModule>();
6062

6163
// Normalize ioredis's overloaded ctor args — (), (port), (path),
6264
// (port, host), (opts), (port, opts), (port, host, opts), (path, opts) —
@@ -127,9 +129,9 @@ vi.mock("~/v3/services/tracePubSub.server", async () => {
127129
// leaves TASK_META_CACHE_REDIS_HOST unset and gets the Noop implementation;
128130
// pin the Noop cache here so env-configured local runs behave identically.
129131
vi.mock("~/services/taskMetadataCacheInstance.server", async () => {
130-
const { NoopTaskMetadataCache } = await vi.importActual<
131-
typeof import("~/services/taskMetadataCache.server")
132-
>("~/services/taskMetadataCache.server");
132+
const { NoopTaskMetadataCache } = await vi.importActual<typeof TaskMetadataCacheModule>(
133+
"~/services/taskMetadataCache.server"
134+
);
133135
return { taskMetadataCacheInstance: new NoopTaskMetadataCache() };
134136
});
135137

0 commit comments

Comments
 (0)